Stripe element add new card #473

cdolm92 · 2018-11-07T00:13:27Z

What

Credit card field in "Add Card" screen should use STPPaymentCardTextField Stripe element, and it is configured to look like the designs.

See 👀

TODO ⏰

CC Image Color is different from design @dannyalright
Snapshot Tests
Should 'Use Camera' be included in this? @nnekab
Feedback

* add card view controller * transition to add new card and uibarbuttons * settings style applied to add new card screen * changed keyboard style for textfields * view controller tests * placeholder for cardholder name textfield * Record new screenshots * new strings, added strings as place holder and text label * pr feedback - inferring type for cancel button tintcolor * pr feedback - keypath, no more lenses * swiftlint fix * new snapshots

cdolm92 · 2018-11-07T00:24:09Z

Kickstarter-iOS/Views/Controllers/AddNewCardViewController.swift

+      |> \.borderColor .~ nil
+      |> \.font .~ .ksr_body()
+      |> \.cursorColor .~ .ksr_green_700
+      |> \.placeholderColor .~  UIColor(red: 0.0, green: 0.0, blue: 0.0, alpha: 0.17)


This is what I saw in the design for the placeholder text color should I be using . ksr_grey_500?

is that a design question? I'm not really sure I understand it. Do you mean the blinking cursor? The placeholder text is greyscale

dnywh · 2018-11-08T14:11:09Z

CC Image Color is different from design

It's different because you're using the one from Stripe. Right? That's cool by me.

* Adding emailIsVerified * Renaming GraphUserEmail * ViewModel tests * ChangeEmailViewController tests * Strings, swiftlint * Strings & new screenshots * Cleanup * PR comments * PR updates * Test naming

dnywh · 2018-11-12T22:37:56Z

Looking good visually. Any way we can get the CVC text to line up to the same right-margin as the Name in the field above? I'm guessing not, as it probably gets its positing from the card number and expiry date.

Could you please tell me the color for the placeholder? It's the default iOS color for placeholder text, right?

cdolm92 · 2018-11-12T22:50:16Z

The color is UIColor.lightGrayColor or #AAAAAA. It's not the default iOS Color for placeholder text. This is the default for the stripe element placeholder text.

ifbarrera

One small comment! Looks good otherwise

ifbarrera · 2018-11-12T22:43:44Z

Kickstarter-iOS/Views/Controllers/AddNewCardViewController.swift

+
+    _ = self.cardholderNameLabel
+      |> \.text %~ { _ in Strings.Cardholder_name() }
+      |> \.textColor .~ .ksr_text_dark_grey_900


Can we use settingsTitleLabelStyle so it's consistent with our other form fields in Settings?

going to use settingsSectionLabelStyle because we want the text color to be .ksr_text_dark_grey_900

cdolm92 · 2018-11-13T16:11:15Z

@ifbarrera @kickstarter/native-squad g2g?

dnywh · 2018-11-13T16:14:04Z

Could we hold off until our after our color call?

…

On Tue, Nov 13, 2018 at 11:11 AM Christella ***@***.***> wrote: @ifbarrera <https://github.com/ifbarrera> @kickstarter/native-squad <https://github.com/orgs/kickstarter/teams/native-squad> g2g? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#473 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC9f-Ye_ocW1jCMGP2EjQ2Ote3ibC5_Eks5uuu8sgaJpZM4YRie3> .

ifbarrera · 2018-11-14T16:08:28Z

@cdolm92 can you make this PR against feature-payment-methods? Lgtm after that 👍

…e-element-addNewCard

…arter/ios-oss into stripe-element-addNewCard

* New card screen ui (#471) * add card view controller * transition to add new card and uibarbuttons * settings style applied to add new card screen * changed keyboard style for textfields * view controller tests * placeholder for cardholder name textfield * Record new screenshots * new strings, added strings as place holder and text label * pr feedback - inferring type for cancel button tintcolor * pr feedback - keypath, no more lenses * swiftlint fix * new snapshots * Payment methods (#457) * Stripe element add new card (#473) * New card screen ui (#471) * add card view controller * transition to add new card and uibarbuttons * settings style applied to add new card screen * changed keyboard style for textfields * view controller tests * placeholder for cardholder name textfield * Record new screenshots * new strings, added strings as place holder and text label * pr feedback - inferring type for cancel button tintcolor * pr feedback - keypath, no more lenses * swiftlint fix * new snapshots * new stppaymentcardtextfield showing * wip - placeholder colors * snapshot tests * Email undeliverable/unverified (#478) * Adding emailIsVerified * Renaming GraphUserEmail * ViewModel tests * ChangeEmailViewController tests * Strings, swiftlint * Strings & new screenshots * Cleanup * PR comments * PR updates * Test naming * pr feedback * new snapshots * new placeholder colors * new snapshots * Delete payment methods (#479) * Add payment method deletion * Test datasource * Test view model * Clean-up and address PR feedback * Rename credit card -> payment method * Fix test * Add credit card implementation (#503) * Email undeliverable/unverified (#478) * Adding emailIsVerified * Renaming GraphUserEmail * ViewModel tests * ChangeEmailViewController tests * Strings, swiftlint * Strings & new screenshots * Cleanup * PR comments * PR updates * Test naming * Use correct function to log events in crash logs (#481) * Use correct function to log events in crash logs * Fix indentation * changed ui colors for textfield text and font size of text label * vm and work on enabling save * wip- get stripe token * wip- payment source mutation * wip- keyboard response * wip- getting a stripe error here * wip- error fix w/ publishable key, error banner showing * wip- saving with error and keyboard functionality * wip- updating card immediately * wip * wip - ACs met * wip - refactor in view model, made IDs testable, begane VM tests * wip -refactor on vm/vmtest * wip -refactor deleted comments on vmt * wip -snapshot tests * swiftlint fixes * renaming/refactor, corrected paymentmethodstests * pr feedback * swiftlint fixes * changed function name * indentation * Payment methods event tracking (#496) * Reverted code that deleted SettingsNewsletters from Storyboard.swift * swiftlint * Reverted code to instantiate settings newsletters vc on tests * Alphabetized storyboard enum * Settings payments colors (#530) * Unsupported Credit Cards (#561) * Viewmodel logic for unsupported cards * Tests and accessibility fixes * Simplify add card button * Screenshots and string updates * Cleanup design and remove logs * Improving comment message * Removing filter debug builds * Addressing PR comments * Updating payment methods screenshots * Screenshots * Possible fix for alignment issues * Moving iOS 10 handling to output signal closure * Remove line * Renaming * Last cleanup * Strings & Asset update * Switching from unsupported to supported * Zipcode field in Add New Card screen (#566) * Viewmodel logic for unsupported cards * Tests and accessibility fixes * Simplify add card button * Screenshots and string updates * Cleanup design and remove logs * Improving comment message * Removing filter debug builds * Addressing PR comments * Updating payment methods screenshots * Screenshots * Possible fix for alignment issues * Moving iOS 10 handling to output signal closure * Remove line * Renaming * Last cleanup * Shared styled form field * Adding functionality for zipcode form field * More functionality * View model & screenshot tests * Swiftlint * Cleanup * Improving test and cleanup * PR feedback and autocapitalizing zipcode * Regenerating ChangePassword screenshots * [Payment methods] CVC bug fix (#574) * wip * wip * wip * wip-swiftlint * moved CreatePaymentSourceEnvelope to its own file, Mockservice * swiftlint fix * deleted unnecesary debugging code * new paymentsource temploate and vm tests * swiftlint fix * fixed vm test * PR feedback * update schema * [Payment methods] Minor bug fixes (#579) * tableViewIsEditing false and show banner after dismiss * Swiftlint * Adding StripePublishableKey to example file * Update publishableKey test * Spacing * Point-free helper * [Payment Methods] Update padding and image view size (#581) * Update padding and image view size * Update stack view's spacing * Update snapshots * Use layoutMargins to set the padding * [Payment methods] Disable edit button if no payment methods (#586) * [Payment methods] Bugs & visual fixes (#578) * Adding custom UITableViewHeader and always calling reload data on viewDidLoad * Updating screenshots * Cleanup autolayout warnings * Screenshots * PR comments * No autolayout for footer view * Cleanup * Remove intrinsicContentSize * Tableview appears without delay fix (#587) * Fix header/footer auto sizing * Update header background color * Update snapshots * Screenshots again * Updating constraint priority to resolve ambiguity * [Payment methods] Refresh payment methods table view properly (#588) * Refresh payment methods table view properly * Remove reference to weak self * Rename delegate methods * [Payment methods] Refetch payment methods on viewDidLoad or explicitly (by delegate) (#591) * Do not refresh on viewWillAppear * Use optional string to avoid unnecessary initializer * Bring back viewWillAppear signal to better reflect view controller's lifecycle state * [Payment methods] A11y - Credit card name (#593) * Add card name to the a11y label * Add comment * [Payment Methods] Design Fixes (#592) * Design fixes * Fresh screenshots ✨ * Remove recordMode * Deleting stale screenshots * Re-add accidentally deleted line * update strings * [Payment Methods] Support optional card type and error handling for payment methods (#596) * Optional card type, payment methods load error * Optional support for imageName * Fix accessibility label * Fix merge conflict spacing * Swiftlint * Implementing PR suggestions * Fixed bug that shows wrong expiration date (#595) * [Payment Methods] Add New Card Design Fixes (#594) * error message present and return key to done * removed error message banner for incomplete payment details * new snapshots for correct insets * [Payment methods] Optimistically disable edit button on card deletion (#589) * Disable edit button optimistically, use stored cards in result from card deletion * Fix issue where edit button is not re-enabled upon the failed deletion of the last card. * Remove unnecessary .init * Add skipRepeats() to editButtonIsEnabled signal. * Fixing potential reference cycles (#598)

cdolm92 added 3 commits November 5, 2018 16:52

new stppaymentcardtextfield showing

4954afc

wip - placeholder colors

2725bcc

cdolm92 commented Nov 7, 2018

View reviewed changes

justinswart force-pushed the feature-payment-methods branch 2 times, most recently from c8df8f8 to 6f90116 Compare November 8, 2018 18:40

cdolm92 changed the base branch from feature-payment-methods to master November 12, 2018 15:55

Merge remote-tracking branch 'oss/master' into stripe-element-addNewCard

550e5a8

cdolm92 changed the title ~~[WIP] Stripe element add new card~~ Stripe element add new card Nov 12, 2018

snapshot tests

1cdbc41

cdolm92 added the needs review label Nov 12, 2018

cdolm92 requested review from Scollaco and ifbarrera November 12, 2018 21:54

Email undeliverable/unverified (#478)

e3cd226

* Adding emailIsVerified * Renaming GraphUserEmail * ViewModel tests * ChangeEmailViewController tests * Strings, swiftlint * Strings & new screenshots * Cleanup * PR comments * PR updates * Test naming

ifbarrera reviewed Nov 12, 2018

View reviewed changes

cdolm92 added 3 commits November 13, 2018 10:47

pr feedback

4b75b2f

Merge remote-tracking branch 'oss/master' into stripe-element-addNewCard

96b3c16

new snapshots

1be1f8f

cdolm92 added 2 commits November 13, 2018 11:36

new placeholder colors

7971fd6

new snapshots

34da51a

cdolm92 requested review from justinswart and dusi November 13, 2018 23:21

cdolm92 changed the base branch from master to feature-payment-methods November 14, 2018 16:13

Merge remote-tracking branch 'oss/feature-payment-methods' into strip…

588c4c5

…e-element-addNewCard

cdolm92 added 2 commits November 14, 2018 13:19

fixed duplicate IDs in Storyboard

918d530

Merge branch 'stripe-element-addNewCard' of https://github.com/kickst…

0817e30

…arter/ios-oss into stripe-element-addNewCard

cdolm92 merged commit 94d368a into feature-payment-methods Nov 14, 2018

cdolm92 deleted the stripe-element-addNewCard branch November 14, 2018 18:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stripe element add new card #473

Stripe element add new card #473

cdolm92 commented Nov 7, 2018 •

edited

cdolm92 Nov 7, 2018

dnywh Nov 8, 2018

dnywh commented Nov 8, 2018

dnywh commented Nov 12, 2018

cdolm92 commented Nov 12, 2018

ifbarrera left a comment

ifbarrera Nov 12, 2018

cdolm92 Nov 12, 2018

cdolm92 commented Nov 13, 2018

dnywh commented Nov 13, 2018 via email

ifbarrera commented Nov 14, 2018

Stripe element add new card #473

Stripe element add new card #473

Conversation

cdolm92 commented Nov 7, 2018 • edited

What

See 👀

TODO ⏰

cdolm92 Nov 7, 2018

Choose a reason for hiding this comment

dnywh Nov 8, 2018

Choose a reason for hiding this comment

dnywh commented Nov 8, 2018

dnywh commented Nov 12, 2018

cdolm92 commented Nov 12, 2018

ifbarrera left a comment

Choose a reason for hiding this comment

ifbarrera Nov 12, 2018

Choose a reason for hiding this comment

cdolm92 Nov 12, 2018

Choose a reason for hiding this comment

cdolm92 commented Nov 13, 2018

dnywh commented Nov 13, 2018 via email

ifbarrera commented Nov 14, 2018

cdolm92 commented Nov 7, 2018 •

edited