Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stripe element add new card #473

Merged
merged 14 commits into from
Nov 14, 2018
Merged

Stripe element add new card #473

merged 14 commits into from
Nov 14, 2018

Commits on Nov 5, 2018

  1. New card screen ui (#471) 

    * add card view controller

* transition to add new card and uibarbuttons

* settings style applied to add new card screen

* changed keyboard style for textfields

* view controller tests

* placeholder for cardholder name textfield

* Record new screenshots

* new strings, added strings as place holder and text label

* pr feedback - inferring type for cancel button tintcolor

* pr feedback - keypath, no more lenses

* swiftlint fix

* new snapshots
    @cdolm92
    cdolm92 committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    18ec495 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. new stppaymentcardtextfield showing

    @cdolm92
    cdolm92 committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    4954afc View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2018

  1. wip - placeholder colors

    @cdolm92
    cdolm92 committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    2725bcc View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2018

  1. Merge remote-tracking branch 'oss/master' into stripe-element-addNewCard

    @cdolm92
    cdolm92 committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    550e5a8 View commit details
    Browse the repository at this point in the history

  2. snapshot tests

    @cdolm92
    cdolm92 committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    1cdbc41 View commit details
    Browse the repository at this point in the history

  3. Email undeliverable/unverified (#478) 

    * Adding emailIsVerified

* Renaming GraphUserEmail

* ViewModel tests

* ChangeEmailViewController tests

* Strings, swiftlint

* Strings & new screenshots

* Cleanup

* PR comments

* PR updates

* Test naming
    @ifbarrera
    ifbarrera committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    e3cd226 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2018

  1. pr feedback

    @cdolm92
    cdolm92 committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    4b75b2f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'oss/master' into stripe-element-addNewCard

    @cdolm92
    cdolm92 committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    96b3c16 View commit details
    Browse the repository at this point in the history

  3. new snapshots

    @cdolm92
    cdolm92 committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    1be1f8f View commit details
    Browse the repository at this point in the history

  4. new placeholder colors

    @cdolm92
    cdolm92 committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    7971fd6 View commit details
    Browse the repository at this point in the history

  5. new snapshots

    @cdolm92
    cdolm92 committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    34da51a View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2018

  1. Merge remote-tracking branch 'oss/feature-payment-methods' into strip… 

    …e-element-addNewCard
    @cdolm92
    cdolm92 committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    588c4c5 View commit details
    Browse the repository at this point in the history

  2. fixed duplicate IDs in Storyboard

    @cdolm92
    cdolm92 committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    918d530 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'stripe-element-addNewCard' of https://github.com/kickst… 

    …arter/ios-oss into stripe-element-addNewCard
    @cdolm92
    cdolm92 committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    0817e30 View commit details
    Browse the repository at this point in the history