♿️ [Dynamic Type] Navigation bar title #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dusi should we also disable dynamic type for the Explore Navigation Title Search Bar Placeholder |
|
Yes, I was thinking about those as a separate piece of work since that's a custom component, not a navigation bar style. If we'd prefer to have that work as part of this PR I would have to properly create a card and add it to our sprint (this fix came out of trying to figure out what's wrong and due to its triviality I've opened a PR hoping this will make it easier in the future to take on that work). |
dusi
force-pushed
the
feature-settings-dynamic-type-navigation-bar
branch
from
a90dc8f
to
0e26201
Compare
justinswart
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Uses default (system) font for the navigation bar title in order to prevent from allowing resizing when the font size changes.
🤔 Why
More native behaviour.
👀 See
♿️ Accessibility