π²[Native Checkout] Description Cell User Interaction #668
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import Foundation | ||
| import KsApi | ||
| import Prelude | ||
| import ReactiveSwift | ||
| import ReactiveExtensions | ||
| import Result | ||
|
|
||
| public protocol PledgeDescriptionCellViewModelInputs { | ||
| func configureWith(estimatedDeliveryDate: String) | ||
| func tapped() | ||
|
There was a problem hiding this comment. Can we use a more specific name for this input? Maybe |
||
| } | ||
|
|
||
| public protocol PledgeDescriptionCellViewModelOutputs { | ||
| var estimatedDeliveryText: Signal<String, NoError> { get } | ||
| var presentTrustAndSafety: Signal<Void, NoError> { get } | ||
| } | ||
|
|
||
| public protocol PledgeDescriptionCellViewModelType { | ||
| var inputs: PledgeDescriptionCellViewModelInputs { get } | ||
| var outputs: PledgeDescriptionCellViewModelOutputs { get } | ||
| } | ||
|
|
||
| public final class PledgeDescriptionCellViewModel: PledgeDescriptionCellViewModelType, | ||
| PledgeDescriptionCellViewModelInputs, PledgeDescriptionCellViewModelOutputs { | ||
|
|
||
| public init() { | ||
| self.estimatedDeliveryText = self.estimatedDeliveryDateProperty.signal | ||
|
|
||
| self.presentTrustAndSafety = self.tappedProperty.signal | ||
| } | ||
|
|
||
| private let estimatedDeliveryDateProperty = MutableProperty<String>("") | ||
| public func configureWith(estimatedDeliveryDate: String) { | ||
| self.estimatedDeliveryDateProperty.value = estimatedDeliveryDate | ||
| } | ||
| private let tappedProperty = MutableProperty(()) | ||
| public func tapped() { | ||
| self.tappedProperty.value = () | ||
| } | ||
|
|
||
| public let estimatedDeliveryText: Signal<String, NoError> | ||
| public let presentTrustAndSafety: Signal<Void, NoError> | ||
|
|
||
| public var inputs: PledgeDescriptionCellViewModelInputs { return self } | ||
| public var outputs: PledgeDescriptionCellViewModelOutputs { return self } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import XCTest | ||
| @testable import KsApi | ||
| @testable import Library | ||
| @testable import ReactiveExtensions_TestHelpers | ||
| import Prelude | ||
| import Result | ||
|
|
||
| internal final class PledgeDescriptionCellViewModelTests: TestCase { | ||
| private let vm: PledgeDescriptionCellViewModelType = PledgeDescriptionCellViewModel() | ||
|
|
||
| private let estimatedDeliveryText = TestObserver<String, NoError>() | ||
| private let presentTrustAndSafety = TestObserver<Void, NoError>() | ||
|
|
||
| override func setUp() { | ||
| super.setUp() | ||
|
|
||
| self.vm.outputs.estimatedDeliveryText.observe(estimatedDeliveryText.observer) | ||
| self.vm.outputs.presentTrustAndSafety.observe(presentTrustAndSafety.observer) | ||
| } | ||
|
|
||
| func testEstimatedDeliveryDate() { | ||
| let estimatedDelivery = 1468527587.32843 | ||
|
|
||
| let date = Format.date(secondsInUTC: estimatedDelivery, template: "MMMMyyyy", timeZone: UTCTimeZone) | ||
|
|
||
| self.vm.inputs.configureWith(estimatedDeliveryDate: date) | ||
| self.estimatedDeliveryText.assertValues(["July 2016"], "Emits the estimated delivery date") | ||
| } | ||
|
|
||
| func testPresentTrustAndSafety() { | ||
| self.vm.inputs.tapped() | ||
| self.presentTrustAndSafety.assertDidEmitValue() | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the closure here? Or can't we just do
private lazy var spacerView = UIView(frame: .zero)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! We actually don't need the closure. So there's going to be a number of places that we can change this. I think the function stuff is a hangover from having set local vars in that scope before to set properties on it, but seeing as we pipe forward to set these things it can all be done in-line.