🦡 [App Badges] Set badge count on activities tab bar item #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-icon-set-badge # Conflicts: # Kickstarter-iOS/ViewModels/RootViewModel.swift # Kickstarter-iOS/ViewModels/RootViewModelTests.swift
justinswart
changed the title
dusi
reviewed
May 31, 2019
). Maybe even in a separate PR.
| @@ -375,3 +391,13 @@ extension TabBarItem: Equatable { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func activitiesBadgeValue() -> String? { | |||
| @@ -4,7 +4,10 @@ import Prelude | |||
| import ReactiveSwift | |||
| import UIKit | |||
|
|
|||
| public let maxBadgeValue = 99 | |||
There was a problem hiding this comment.
Since we're only using this constant from the function bellow does it still make sense to have it here (as oppose to inside the function)?
If you think it's better to have it as a global constant how about we extract this to Constants.swift or something and maybe make it an enum?
|
|
||
| guard count > 0 else { return nil } | ||
|
|
||
| let plusSign = AppEnvironment.current.application.applicationIconBadgeNumber > maxBadgeValue ? "+" : "" |
There was a problem hiding this comment.
Also looks like we're repeating some code here..how about
private func activitiesBadgeValue() -> String? {
let applicationIconBadgeNumber = AppEnvironment.current.application.applicationIconBadgeNumber
let count = min(applicationIconBadgeNumber, maxBadgeValue)
guard count > 0 else { return nil }
let plusSign = applicationIconBadgeNumber > maxBadgeValue ? "+" : ""
return "\(count)\(plusSign)"
}| @@ -43,19 +43,3 @@ final class UIViewControllerURLTests: TestCase { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
@dusi good point, will address a11y in a separate PR 👍 |
…e-icon-set-badge # Conflicts: # Library/UIViewController+URLTests.swift
justinswart
added a commit
that referenced
this pull request
Jun 17, 2019
* 🦡 [App Badges] Set badge count on activities tab bar item (#694) * Set badge value on app launch based on current applicationIconBadgeNumber * Add MockApplication.swift * Move constant to within function, improve coalescing * SwiftFormat * 🦡 [App Badges] Update badge value on push and lifecycle events (#698) * Update and clear unseen activity count on lifecycle events, push, user session * Update badge value on current user updated instead of session started, clear value on activities refresh * Fix tests * Only clear activity count when we know that one is set, set badge value while on activities tab, update user in environment * Remove redundant withEnvironment * Prevent infinite loop * Camel-case test functions * Do not update user in environment if logged out * Add logged out test * 🦡 [App Badges] Improve voice-over support for badge value (#706) * Add Strings.activities_badge_value_plus * Handle badge value correctly when voice over is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Sets the app's current badge count value on the activities tab bar item.
This is part of a larger body of work to bring badging to the app. Future PR's will include:
🤔 Why
We've allowed for badges in the app for some time now but work has recently been done to support this on the back-end. This brings additional functionality to allow us to display the amount of unread activities in the app and to mark them as read via GraphQL.
🛠 How
AppEnvironment.current.application.applicationIconBadgeNumberwhich isUIApplication.shared.applicationIconBadgeNumbervia ourApplicationTypeprotocol onAppEnvironment.99and display a+if this value exceeds that.0or less.👀 See
✅ Acceptance criteria
UIApplication.shared.applicationIconBadgeNumberon app launch.99+is shown for an amount greater than99.