🦡 [App Badges] Feature #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set badge value on app launch based on current applicationIconBadgeNumber * Add MockApplication.swift * Move constant to within function, improve coalescing * SwiftFormat
* Update and clear unseen activity count on lifecycle events, push, user session * Update badge value on current user updated instead of session started, clear value on activities refresh * Fix tests * Only clear activity count when we know that one is set, set badge value while on activities tab, update user in environment * Remove redundant withEnvironment * Prevent infinite loop * Camel-case test functions * Do not update user in environment if logged out * Add logged out test
Generated by 🚫 Danger |
* Add Strings.activities_badge_value_plus * Handle badge value correctly when voice over is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Brings improved app badging to the app.
🔀 Merged so far:
#694 Display count on activities tab bar item
#698 Update badge value on push and lifecycle events
#706 Improve voice-over support for badge value
⏰ TODO