-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π©βπ¬ [Investment Day] - Test Suite Cleanup #731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool cool! Just the one suggestion.
@@ -71,11 +69,16 @@ internal class TestCase: FBSnapshotTestCase { | |||
} | |||
|
|||
internal func preferredSimulatorCheck() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep this as:
internal func preferredSimulatorCheck() {
guard
let identifier = ProcessInfo().environment["SIMULATOR_MODEL_IDENTIFIER"],
["iPhone10,1", "iPhone10,4"].contains(identifier),
#available(iOS 12.0, *)
else {
fatalError("Please only test and record screenshots on an iPhone 8 simulator running iOS 12")
}
}
and then can we add this to TestCase
:
override var recordMode: Bool {
willSet(newValue) {
if newValue {
preferredSimulatorCheck()
}
}
}
This will only perform the preferredSimulatorCheck()
when we are actually recording screenshots and not just running unit tests.
You can then remove the line calling preferredSimulatorCheck()
from setUp()
in TestCase.swift
π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to remove preferredSimulatorCheck()
from line 35 of TestCase
@Scollaco @ifbarrera @cdolm92 please note that you can now test on any SIM you want (iPhone SE, iPhone X, etc. without running into Hope this will help make your day to day experience better. Thanks @justinswart for the idea! |
π² What
VoiceOver
thorough the codebase1Password
support (as oppose to a whole OS version support)π€ Why
We need to clean up once in a while..
Also the adoption of our
isOSVersionAvailable
API wasn't as big as we assumed mostly due to some limiting factors. The#available
API from Apple is way better in this regard. We haven't been able to adopt this widely mostly due to the following limitations..We could not use
β Acceptance criteria
1Password
button shows up and allows login using the1Password
extension oniOS 11
with1Password.app
installed