-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π²[Native Checkout] Pledge Error State CTA #753
Merged
Merged
Changes from 4 commits
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
05bbd8a
wip project states
cdolm92 92a772f
wip project states button colors and label showing up
cdolm92 ea877dd
wip project states button height fix
cdolm92 6d683dc
wip, manage button
cdolm92 15e074f
wip setting up vm for states
cdolm92 4d7e56c
wip setting up vm for states
cdolm92 dd9ec41
wip for reward title in manage state
cdolm92 eefe409
wip - refactor and vm tests
cdolm92 fe5f0d3
Merge branch 'feature-native-checkout' of https://github.com/kickstarβ¦
cdolm92 03efd50
wip - getting reward title now
cdolm92 cced1e6
wip - amount and reward formatted for manage state
cdolm92 64a8d49
wip
cdolm92 17563db
wip- deleted backer banner
cdolm92 b20e616
wip- swiftlint fixes
cdolm92 a99489e
Merge branch 'feature-native-checkout' of https://github.com/kickstarβ¦
cdolm92 5d34bc2
wip - got view layer back
cdolm92 fd1bfdd
wip - refactor and renaming
cdolm92 7b583df
wip - snapshot tests
cdolm92 e29225f
wip
cdolm92 70db98a
wip- corrected shipping amount in manage state
cdolm92 026c304
wip- final and alphabetize files
cdolm92 86fb7d2
Merge branch 'feature-native-checkout' of https://github.com/kickstarβ¦
cdolm92 6e3b73a
pr feedback -move stylings to bindStyles()
cdolm92 9eea1a9
smapshot tests
cdolm92 3f643b4
manage and view rewards strings added
cdolm92 3e4e464
using new strings
cdolm92 cde68d2
vm tests fix
cdolm92 db15830
swift format
cdolm92 cbd9ad3
wip- fix pledge
cdolm92 c881491
revert strings
cdolm92 0257061
backer banner is back
cdolm92 b719a30
snapshots
cdolm92 cc391cc
refactor- was not using user
cdolm92 dd4581a
light refactor
cdolm92 0127edb
refactor and snapshot test correction
cdolm92 838dc60
swiftlint fix
cdolm92 c00e4a5
new snapshots
cdolm92 8cce6f9
remove images from new snapshots
cdolm92 53e9290
remove image
cdolm92 3be29bc
Merge branch 'cta-project-states' of https://github.com/kickstarter/iβ¦
cdolm92 3a48577
wip - fix state
cdolm92 a44d702
case
cdolm92 e86d42f
fix logic is there
cdolm92 24b00d6
fix vm tests are passing
cdolm92 cd4a326
Merge branch 'feature-native-checkout' of https://github.com/kickstarβ¦
cdolm92 ca08db7
snapshot tests fixed
cdolm92 c092f74
snapshot tests fix for error state
cdolm92 c686804
strings for error state
cdolm92 f151c39
vm refactor
cdolm92 e597ac6
vm refactor title text
cdolm92 b06feec
undid change
cdolm92 6bc920e
swift format
cdolm92 425270a
fix button width
cdolm92 013d3a5
new snapshots
cdolm92 7f59096
design feedback, new snapshots
cdolm92 7e8da8d
swift format
cdolm92 01f8a61
added spacing
cdolm92 5479451
renamed a stackview
cdolm92 e48bfd3
capitalized
cdolm92 8d4a673
capitalized
cdolm92 0e6df1c
fixes
cdolm92 f102379
Merge branch 'feature-native-checkout' of https://github.com/kickstarβ¦
ifbarrera 3557bef
Cleaning up screenshots, fixing issues with merge conflict
ifbarrera 5bc65dd
Formatting
ifbarrera 7364ab2
Revert unneeded project template
ifbarrera 1933e08
Cleaning up the snapshot configurations so theyβre more consistent frβ¦
ifbarrera 4978002
Formatting
ifbarrera 3045c43
Line length
ifbarrera 82cd0cb
Line length again
ifbarrera 8a9f3ca
Merge branch 'cta-error-pledge-state' of https://github.com/kickstartβ¦
cdolm92 c0f25d7
new snapshots
cdolm92 b00d851
requested changes
cdolm92 3cf816e
fixed reward title missing
cdolm92 f973a8c
fixed snapshot failures
cdolm92 3df1286
new snapshots
cdolm92 e5b8f24
swift format
cdolm92 8917e53
swift lint fix
cdolm92 a865187
Merge branch 'feature-native-checkout' of https://github.com/kickstarβ¦
cdolm92 7c7678e
swift format
cdolm92 302860f
pr feedback and snapshot test for error state
cdolm92 8e52e12
name change to minHeight and minWidth
cdolm92 a88c6ed
snapshot tests for error state
cdolm92 577fb91
constant name change
cdolm92 ecb2745
snapshot correction
cdolm92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+1.89 KB
(100%)
...acker_LiveProject_Error_NativeCheckout_Enabled_lang_en_device_phone4inch@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2.24 KB
(100%)
...ker_LiveProject_Error_NativeCheckout_Enabled_lang_en_device_phone5_5inch@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2.51 KB
(100%)
...ker_LiveProject_Error_NativeCheckout_Enabled_lang_en_device_phone5_8inch@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use
combos(Language.allLanguages, Device.allCases)
so it's consistent with the rest of the tests in this file? I know it generates tons of screenshots, but this is a high-value piece of UI that would be useful to have fully covered in all languages and screens sizes