-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💲[Native Checkout] Update pledge button copy #788
Conversation
# Conflicts: # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_de_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_de_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_de_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_en_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_en_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_en_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_es_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_es_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_es_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_fr_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_fr_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_fr_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_ja_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_ja_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_ja_device_phone5_8inch@2x.png
) | ||
|
||
return Strings.rewards_title_pledge_reward_currency_or_more(reward_currency: minimumFormattedAmount) | ||
private func nonBackedPledgeButtonTitle(project _: Project, reward: Reward) -> String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still using project
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks, I'll remove it!
"Pledge £6 or more", | ||
"Pledge £6 or more", | ||
"Pledge £6 or more", | ||
"Select", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use Strings.Select()
, Strings.No_longer_available()
, and Strings.Make_a_pledge_without_a_reward()
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is an interesting question. I realize we've been fairly inconsistent in tests with this but I'd like to actually do a sweep sometime to change every String
assertion to be explicit rather than through Strings.*
. I think the reason being that if the underlying string changes we'd actually want our tests to fail and for us to validate whether the test needs to be updated 🤔
cc @Scollaco @ifbarrera for discussion.
"Pledge £6 or more", | ||
"Pledge £6 or more", | ||
"Pledge £6 or more", | ||
"Select", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛥
📲 What
Updates the pledge button copy on the reward cell:
Pledge X or more
->Select
NoReward
:Pledge $1 or more
->Make a pledge without a reward
🤔 Why
This is the preferred copy, we're also moving away from displaying dynamic text in buttons.
🛠 How
Updated the copy, tests and snapshot tests.
👀 See
✅ Acceptance criteria
Select
for all available rewards exceptNoReward
.Make a pledge without a reward
for allNoReward
s.