💲[Native Checkout] Update pledge button copy #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_de_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_de_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_de_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_en_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_en_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_en_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_es_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_es_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_es_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_fr_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_fr_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_fr_device_phone5_8inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_ja_device_pad@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_ja_device_phone4_7inch@2x.png # Screenshots/_64/Kickstarter_Framework_iOSTests.RewardsCollectionViewControllerTests/testRewards_NonBacker_LiveProject_lang_ja_device_phone5_8inch@2x.png
cdolm92
suggested changes
Aug 9, 2019
| ) | ||
|
|
||
| return Strings.rewards_title_pledge_reward_currency_or_more(reward_currency: minimumFormattedAmount) | ||
| private func nonBackedPledgeButtonTitle(project _: Project, reward: Reward) -> String { |
There was a problem hiding this comment.
Are we still using project here?
There was a problem hiding this comment.
Ah thanks, I'll remove it!
| "Pledge £6 or more", | ||
| "Pledge £6 or more", | ||
| "Pledge £6 or more", | ||
| "Select", |
There was a problem hiding this comment.
Can we use Strings.Select(), Strings.No_longer_available(), and Strings.Make_a_pledge_without_a_reward() instead?
There was a problem hiding this comment.
So this is an interesting question. I realize we've been fairly inconsistent in tests with this but I'd like to actually do a sweep sometime to change every String assertion to be explicit rather than through Strings.*. I think the reason being that if the underlying string changes we'd actually want our tests to fail and for us to validate whether the test needs to be updated 🤔
cc @Scollaco @ifbarrera for discussion.
| "Pledge £6 or more", | ||
| "Pledge £6 or more", | ||
| "Pledge £6 or more", | ||
| "Select", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Updates the pledge button copy on the reward cell:
Pledge X or more->SelectNoReward:Pledge $1 or more->Make a pledge without a reward🤔 Why
This is the preferred copy, we're also moving away from displaying dynamic text in buttons.
🛠 How
Updated the copy, tests and snapshot tests.
👀 See
✅ Acceptance criteria
Selectfor all available rewards exceptNoReward.Make a pledge without a rewardfor allNoRewards.