Remove Rewards Collection View Custom Centering Behavior #793
Conversation
| @@ -161,8 +161,7 @@ final class PledgeCTAContainerView: UIView { | |||
| self.activityIndicator.centerXAnchor.constraint(equalTo: self.layoutMarginsGuide.centerXAnchor), | |||
| self.activityIndicator.centerYAnchor.constraint(equalTo: self.layoutMarginsGuide.centerYAnchor), | |||
| self.pledgeCTAButton.heightAnchor.constraint(greaterThanOrEqualToConstant: Layout.Button.minHeight), | |||
| self.pledgeCTAButton.widthAnchor.constraint(greaterThanOrEqualToConstant: Layout.Button.minWidth), | |||
| self.rootStackView.topAnchor.constraint(equalTo: self.layoutMarginsGuide.topAnchor) | |||
There was a problem hiding this comment.
This constraint was causing warnings because it conflicts with the constraints applied here:
ifbarrera
force-pushed
the
remove-custom-centering
branch
from
ed6c895
to
a4626a7
Compare
| super.viewWillTransition(to: size, with: coordinator) | ||
|
|
||
| self.flowLayout?.invalidateLayout() | ||
| if itemSize != layout.itemSize { |
There was a problem hiding this comment.
Is it necessary to compare the sizes? Trying to understand what's going on in here...
There was a problem hiding this comment.
It is. Basically during one of the layout passes, the adjustedContentInsets change, and our itemSize depends on those contentInset values. In order to make sure the itemSize has all the update-to-date values (and so that it's the right height), we need to do this check.
Kickstarter-iOS/Views/Controllers/RewardsCollectionViewController.swift
Outdated
Show resolved
Hide resolved
| extension RewardsCollectionViewController { | ||
| override func scrollViewDidScroll(_ scrollView: UIScrollView) { | ||
| self.collectionView.visibleCells.compactMap { $0 as? RewardCell }.forEach { | ||
| $0.cancelDepress() |
There was a problem hiding this comment.
Is cancelDepress still being used?
There was a problem hiding this comment.
Oh good catch. Hmm @justinswart can you describe the effect of this? I'm not seeing any issues when removing it, the "depress" action seems to cancel when you lift up your finger.
There was a problem hiding this comment.
This was for when you begin dragging the carousel, Danny wanted the card to lift again as you pan. I was mostly indifferent about it.
| self.pledgeButton.rac.hidden = self.viewModel.outputs.pledgeButtonHidden | ||
| self.gradientView.rac.hidden = self.viewModel.outputs.gradientHidden |
There was a problem hiding this comment.
In regards to consistency should this signal be named gradientViewHidden?
There was a problem hiding this comment.
-
Looks like @justinswart is OK with removing the
cancelDepressaction -
Did you see my question about
ksr_insertSubviewInParentor was it missed on the conversation tab? -
Just noticed something weird that I wanted to double check...are we aware of the fact that
hiddenPledgeHiddenConstraints(basically a getter for the array of constraints) causes a side effect by callingself.addBottomViewsMarginConstraints(with: self.layoutMarginsGuide)?
Cc @Scollaco since he seems to be the author of this line.
📲 What
This PR removes our custom "hidden scroll view" implementation of the cell-centering behavior and replaces it with
UIScrollViews out-of-the-box free-scrolling behavior.🤔 Why
To simplify rewards browsing for the first release of this redesign.
🛠 How
UIScrollViewUIScrollViewDelegateimplementation👀 See
✅ Acceptance criteria