-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Native Checkout] CTAs polish #800
Conversation
…ios-button-polish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just the one suggestion really.
self.actionsStackViewAxis = Signal.merge( | ||
self.viewDidLoadProperty.signal, | ||
self.viewWillTransitionProperty.signal | ||
).map { _ in AppEnvironment.current.device.orientation.isPortrait ? .vertical : .horizontal } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead of inspecting the orientation we actually want to check the UITraitCollection
's sizeClass
.
So this would be horizontalSizeClass == .regular
and for this we would have an input for traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
📲 What
This PR addresses the following:
🤔 Why
Closing out small visual issues found during the consolidation of Checkout button styles throughout the rest of the app.
👀 See
See snapshots below.
♿️ Accessibility
✅ Acceptance criteria
See All [CATEGORY] projects
button.⏰ TODO