Determine "Apple Pay capable" based on available card types from the project #805
Conversation
…apple-pay-capable
…apple-pay-capable
| "VISA", | ||
| "DISCOVER", | ||
| "JCB", | ||
| "DINERS", |
There was a problem hiding this comment.
Note that DINERS is actually not a supportedNetwork according to Apple Pay, so it's filtered out.
| @@ -4,6 +4,7 @@ import Prelude | |||
| import Runes | |||
|
|
|||
| public struct Project { | |||
| public var availableCardTypes: [String]? | |||
There was a problem hiding this comment.
This is optional because the project JSON object we get from the /discover endpoint doesn't have this field (it's only a partial project), and we use the same Project model to decode that payload.
There was a problem hiding this comment.
I suppose we could also consider coalescing an empty array if we wanted this to be non-optional 🤔 but I guess having nil here is more explicit about not having the information rather than there are no available card types.
There was a problem hiding this comment.
Yeah I'd rather keep it nil to make it clear that the info is not available.
| } | ||
|
|
||
| public static func supportedNetworks(for project: Project) -> [PKPaymentNetwork] { | ||
| guard let availableCardTypes = project.availableCardTypes else { |
There was a problem hiding this comment.
availableCardTypes should never be nil in this context, but decided to add a fallback just in case 🤷♀
Generated by 🚫 Danger |
Kickstarter-iOS/Views/Controllers/PledgePaymentMethodsViewController.swift
Outdated
Show resolved
Hide resolved
| @@ -4,6 +4,7 @@ import Prelude | |||
| import Runes | |||
|
|
|||
| public struct Project { | |||
| public var availableCardTypes: [String]? | |||
There was a problem hiding this comment.
I suppose we could also consider coalescing an empty array if we wanted this to be non-optional 🤔 but I guess having nil here is more explicit about not having the information rather than there are no available card types.
justinswart
added
needs review
and removed
blocked
…apple-pay-capable # Conflicts: # KsApi/models/lenses/ProjectLenses.swift
📲 What
Previously, we were determining Apple Pay capabilities from hardcoded logic. This PR updates that logic to instead use the
availableCardTypesfield on the project, and also adds the business logic of showing/hiding the Apple Pay button in the newPledgePaymentMethodsViewController. The logic for determining supported networks is shared, and is now fully tested.🤔 Why
Part of Apple Pay implementation on the new Pledge screen.
🛠 How
We now have a new
availableCardTypesfield on theProjectmodel. We can use this array to determine whichsupportedNetworksto request from the method PassKit functionPKPaymentAuthorizationViewController.canMakePayments(usingNetworks:). There is still fallback logic which mimics the backend logic, in caseavailableCardTypesisnil.✅ Acceptance criteria
⏰ TODO
availableCardTypestrings that are being returned to match the GraphQLCreditCardTypeschema names so this feature will work