-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine "Apple Pay capable" based on available card types from the project #805
Merged
Merged
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5fdf1fd
Adding `availableCardTypes` to the Project model
ifbarrera 458ac89
Merge branch 'master' of https://github.com/kickstarter/ios-oss into …
ifbarrera 57c08f7
More tests
ifbarrera ed45f9f
Cleaning up tests that aren’t needed anymore
ifbarrera cc8655a
Merge branch 'master' of https://github.com/kickstarter/ios-oss into …
ifbarrera 8ca62b7
Formatting
ifbarrera 9761f80
Line length
ifbarrera 8fac14f
cleaning up line breaks
ifbarrera 0fe2775
Adding missing output tests for PledgeViewModel
ifbarrera dc9610a
Cleanup
ifbarrera 1866350
Formatting
ifbarrera 2ab4e91
Merge branch 'master' of https://github.com/kickstarter/ios-oss into …
ifbarrera 6c4c49d
Adding missing lenses
ifbarrera 567e679
Adding handling for all card cases and updating function parameter names
ifbarrera d234cd5
Grouping cases to a single line
ifbarrera eb4d016
Adding test for error reloading payment methods when Apple Pay capable
ifbarrera fb03f7d
Merge branch 'master' into apple-pay-capable
ifbarrera 28350cb
Merge branch 'master' into apple-pay-capable
ifbarrera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is optional because the project JSON object we get from the
/discover
endpoint doesn't have this field (it's only a partial project), and we use the sameProject
model to decode that payload.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we could also consider coalescing an empty array if we wanted this to be non-optional 🤔 but I guess having
nil
here is more explicit about not having the information rather than there are no available card types.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'd rather keep it
nil
to make it clear that the info is not available.