Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-88] Send client_id in request headers #839

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Sep 13, 2019

πŸ“² What

With requests going to the v1 API, we would usually send the client_id as a query param. For /graph requests (which are all POST requests) we'd rather send the client_id in a custom header. For consistency, this PR adds the new custom header to all our requests.

πŸ€” Why

Increased security for /graph requests.

πŸ›  How

Added X-KICKSTARTER-CLIENT to our defaultHeaders.

βœ… Acceptance criteria

This can be tested using Charles proxy.

  • Verify that x-kickstarter-client header appears in /v1 requests (ex. discovery screen)
  • Verify that x-kickstarter-client header appears in /graph query requests (ex. viewing stored cards)
  • Verify that x-kickstarter-client header appears in /graph mutation requests (ex. adding a new stored card)

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@ifbarrera ifbarrera merged commit daf3ede into master Sep 13, 2019
@ifbarrera ifbarrera deleted the graph-requests-client-id branch September 13, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants