[NT-209, NT-156] Pledge Button Interaction (Create Backing) #855
Conversation
…pledge-button-interaction # Conflicts: # Kickstarter-iOS/Views/Controllers/PledgePaymentMethodsViewController.swift
ifbarrera
changed the title
| @@ -4,31 +4,32 @@ public struct CreateBackingInput: GraphMutationInput { | |||
| let amount: String | |||
| let locationId: String? | |||
| let paymentSourceId: String | |||
| let paymentType: String | |||
There was a problem hiding this comment.
Removed paymentType because after chatted with the backend team, it's not really an input field (should always be set to credit_card). They plan on removing the field entirely in the near future.
| refTag: RefTag?, | ||
| paymentSourceId: String | ||
| ) -> CreateBackingInput { | ||
| let pledgeAmountDecimal = Decimal(pledgeAmount) |
There was a problem hiding this comment.
A lot of this is duplicated from CreateApplePayBackingInput - I decided not to refactor out the shared parts because I know we're planning to consolidate the two mutations in the near future. When we do, we can simply merge the differences from CreateApplePayInput into this input.
| .map(CreateBackingInput.input(from:reward:pledgeAmount:selectedShippingRule:refTag:paymentSourceId:)) | ||
| .switchMap { input in | ||
| AppEnvironment.current.apiService.createBacking(input: input) | ||
| .ksr_delay(AppEnvironment.current.apiDelayInterval, on: AppEnvironment.current.scheduler) |
There was a problem hiding this comment.
Notice that we don't care about the result here - since we are moving to a synchronous createBacking mutation, any errors in creating the pledge should come back as regular graph errors.
|
|
||
| func pledgePaymentMethodsViewControllerDidTapPledgeButton( | ||
| _ | ||
| viewController: PledgePaymentMethodsViewController |
There was a problem hiding this comment.
I know how much you love formatting comments but this is strange 😄
|
|
||
| func pledgePaymentMethodsViewControllerDidTapPledgeButton( | ||
| _: | ||
| PledgePaymentMethodsViewController |
| } | ||
|
|
||
| public func toInputDictionary() -> [String: Any] { | ||
| var inputDictionary = [ | ||
| "amount": amount, | ||
| "paymentSourceId": paymentSourceId, | ||
| "paymentType": paymentType, | ||
| // swiftlint:disable:next line_length | ||
| "paymentType": "credit_card", // this is temporary and will be removed once the mutation has been updated |
There was a problem hiding this comment.
I'm guessing we can flag the PaymentType enum for removal too?
There was a problem hiding this comment.
Oh yeah good call.
📲 What
Hooks up the
createBackingmutation to the pledge button to allow users to create backings natively.🤔 Why
So that users can pledge with a stored card.
🛠 How
When the pledge button is tapped, a request is made to the
createBackingmutation which creates the pledge. On success, the user is taken to the "Thanks" screen. If an error occurs, the error is displayed in the message banner on the Pledge Screen.Things to note:
createApplePayBackingmutation into thecreateBackingmutation👀 See
✅ Acceptance criteria
Testing RefParam
createBackingmutation, which should show arefParaminput field a value (ex.discovery_home,recommendations).