-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-227] Cancel Pledge UI #864
Conversation
…cancel-backing-UI # Conflicts: # Kickstarter-iOS/Views/Controllers/CancelPledgeViewController.swift # Kickstarter-iOS/Views/Controllers/CancelPledgeViewControllerTests.swift # Library/ViewModels/CancelPledgeViewModel.swift # Library/ViewModels/CancelPledgeViewModelTests.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor suggestions / questions and than was wondering about UX when a user might have font set to a larger size (maybe on a smaller device) which would result into keyboard overlapping the input field...so the question is - should we remove the top space when the keyboard is on as well (not only when the traits are accessibility+)?
See bellow
Kickstarter-iOS/Views/Controllers/CancelPledgeViewController.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Views/Controllers/CancelPledgeViewController.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Views/Controllers/CancelPledgeViewController.swift
Outdated
Show resolved
Hide resolved
Kickstarter-iOS/Views/Controllers/CancelPledgeViewController.swift
Outdated
Show resolved
Hide resolved
|> \.textAlignment .~ NSTextAlignment.center | ||
|> \.numberOfLines .~ 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These could technically be reused for multi-line centered style
¯_(ツ)_/¯
@@ -34,6 +34,14 @@ public let apricotButtonStyle = baseButtonStyle | |||
<> UIButton.lens.backgroundColor(for: .highlighted) .~ UIColor.ksr_apricot_500.mixDarker(0.12) | |||
<> UIButton.lens.backgroundColor(for: .disabled) .~ UIColor.ksr_apricot_500.mixLighter(0.36) | |||
|
|||
// MARK: - Red | |||
|
|||
public let redButtonStyle = baseButtonStyle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, I removed this previously since we didn't use it
…s-oss into cancel-backing-UI
…cancel-backing-UI
Generated by 🚫 Danger |
I see your point Isabel and I don't have strong feelings so I'd be OK with this approach...one other edge case will be landscape mode where basically the textfield will be completely hidden...I mentioned this because the implementation is in my opinion trivial to achieve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚢 🚢
🚢 🚢 🚢
🚢 🚢 🚢
📲 What
Builds the UI components of the cancel pledge screen. Note that this PR does not include the text field functionality, that will be added as part of the implementation for the full cancel pledge UX.
🤔 Why
For the Cancel Pledge feature.
🛠 How
Adds all UI elements as part of a root stack view. Notice that here I've preferred to use
setCustomSpacing(after)
to tweak spacing between certain views, instead of creating sub-stackviews. Open to feedback on that approach.Note that the following will be addressed in a follow-up PR:
redButtonStyle
are TBD👀 See
Trello, screenshots, external resources?
♿️ Accessibility
✅ Acceptance criteria