Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-514] "View your rewards" creator CTA #939

Merged
merged 7 commits into from
Nov 12, 2019
Merged

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Nov 11, 2019

📲 What

Updates the Pledge CTA to View your rewards if the current user is the creator of the project. This CTA will display regardless of whether the project is live or not.

🤔 Why

So that creators can view their rewards, but not pledge to their own project.

🛠 How

Added a .viewYourRewards state to the PledgeStateCTAType enum and corresponding visual treatment. When the CTA button is tapped, the user is taken to the RewardsCollectionViewController.

👀 See

ey9CtJQud7

♿️ Accessibility

  • Tap targets use minimum of 44x44 pts dimensions
  • Works with VoiceOver
  • Supports Dynamic Type

🏎 Performance

N/A

✅ Acceptance criteria

  • As a creator, navigate to the project page of a project you created. You can do this via Search or via the Dashboard. You should see the CTA button on the project page; it should be black, and say "View your rewards". Tapping the "View your rewards" button should take you to the rewards carousel.

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -112,7 +112,7 @@ public final class ProjectPamphletViewModel: ProjectPamphletViewModelType, Proje
.skipNil()

let shouldGoToRewards = ctaButtonTappedWithType
.filter { $0 == .pledge || $0 == .viewRewards }
.filter { [.pledge, .viewRewards, .viewYourRewards].contains($0) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.contains! my favourite 😅

@ifbarrera ifbarrera assigned justinswart and unassigned cdolm92 Nov 12, 2019
@ifbarrera ifbarrera merged commit 680f982 into master Nov 12, 2019
@ifbarrera ifbarrera deleted the NT-514-view-your-rewards branch November 12, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants