✨ Set download endpoints to use http in dev mode #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankolbman
reviewed
Mar 2, 2021
|
Can you add a description to the PR? |
gsantia
force-pushed
the
download-endpoints
branch
3 times, most recently
from
140297c
to
abb8547
Compare
gsantia
changed the title
gsantia
force-pushed
the
download-endpoints
branch
from
abb8547
to
7ba29db
Compare
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
==========================================
+ Coverage 92.59% 92.73% +0.13%
==========================================
Files 108 108
Lines 4795 4801 +6
==========================================
+ Hits 4440 4452 +12
+ Misses 355 349 -6
Continue to review full report at Codecov.
|
dankolbman
suggested changes
Mar 10, 2021
gsantia
force-pushed
the
download-endpoints
branch
from
7ba29db
to
942ad4b
Compare
gsantia
force-pushed
the
download-endpoints
branch
2 times, most recently
from
a912211
to
033d390
Compare
gsantia
force-pushed
the
download-endpoints
branch
from
033d390
to
2b45747
Compare
dankolbman
suggested changes
Mar 11, 2021
dankolbman
approved these changes
Mar 11, 2021
dankolbman
added a commit
that referenced
this pull request
Apr 7, 2021
## Release 1.16.0 ### Summary - Emojis: 🔥 x1, ⬆️ x1, ✨ x2 - Categories: Removals x1, Ops x1, Additions x2 ### New features and changes - [#610](#610) - 🔥 Remove lingering ego auth fields - [f091a41](f091a41) by [dankolbman](https://github.com/dankolbman) - [#606](#606) - ⬆️ Bump django from 2.2.13 to 2.2.18 - [8ef82bd](8ef82bd) by [dependabot[bot]](https://github.com/apps/dependabot) - [#601](#601) - ✨ Make events in data_review node sortable with EventFilter - [48d03a3](48d03a3) by [XuTheBunny](https://github.com/XuTheBunny) - [#592](#592) - ✨ Set download endpoints to use http in dev mode - [69b1d80](69b1d80) by [gsantia](https://github.com/gsantia)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow developers running the study creator locally to test and use the
/downloadendpoint. This is done by checkingif the
DEVELOPsetting isTrue. If so, returnhttp://instead ofhttps://in the download URLs.Closes #585.