DROOLS-5521: Handle pressing TAB when editing last cell #1006

jomarko · 2020-07-22T12:01:14Z

For more details see https://issues.redhat.com/browse/DROOLS-5521

yesamer

@jomarko Thank you!

jomarko · 2020-07-22T12:15:24Z

Jenkins do full downstream build

jomarko · 2020-07-22T13:18:03Z

Jenkins do full downstream build

jomarko · 2020-07-23T04:06:28Z

failed tests:

org.kie.hacep.KafkaTest.testKafkaLoggerWithStringTest
org.kie.hacep.PodAsReplicaTest.processOneSentMessageAsLeaderAndThenReplicaTest
org.kie.server.integrationtests.common.KieServerContainerCRUDIntegrationTest.initializationError
org.kie.server.integrationtests.common.KieServerIntegrationTest.testScanner[3: JAXB KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.integrationtests.common.KieServerIntegrationTest.testConversationIdHandling[4: JSON KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.integrationtests.common.KieServerIntegrationTest.testScannerStatusOnContainerInfo[4: JSON KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.integrationtests.common.KieServerIntegrationTest.testScannerScanNow[4: JSON KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.integrationtests.common.KieServerIntegrationTest.testGetServerInfo[4: JSON KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.integrationtests.common.KieServerIntegrationTest.testScanner[4: JSON KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.integrationtests.common.KieServerIntegrationTest.testConversationIdHandling[5: XSTREAM KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.integrationtests.common.KieServerIntegrationTest.testScannerStatusOnContainerInfo[5: XSTREAM KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.integrationtests.common.KieServerIntegrationTest.testScannerScanNow[5: XSTREAM KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.integrationtests.common.KieServerIntegrationTest.testGetServerInfo[5: XSTREAM KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.integrationtests.common.KieServerIntegrationTest.testScanner[5: XSTREAM KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.integrationtests.common.jms.ContainerJmsResponseHandlerIntegrationTest.initializationError
org.kie.server.integrationtests.common.rest.RestMalformedRequestIntegrationTest.org.kie.server.integrationtests.common.rest.RestMalformedRequestIntegrationTest
org.kie.server.springboot.samples.KieServerTest.testProcessStartAndWorkOnUserTask
org.kie.server.springboot.samples.KieServerMigrationTest.testProcessStartAndAbort
org.jbpm.kie.services.test.FilteredKModuleDeploymentServiceTest.testMultipleRemotableInPojoJar

jomarko · 2020-07-23T04:06:32Z

Jenkins do full downstream build

jomarko · 2020-07-23T09:11:23Z

Jenkins do full downstream build

jomarko · 2020-07-23T13:02:39Z

Jenkins do full downstream build

jomarko · 2020-07-23T21:03:39Z

Jenkins do full downstream build

jomarko · 2020-07-24T03:35:58Z

Failed tests

org.kie.maven.plugin.ExecModelParameterTest.testNoMavenWithoutDroolsModelCompilerOnClassPathDoNotRunExecModel[3.3.9]
org.kie.maven.plugin.ExecModelParameterTest.testNoMavenWithDroolsModelCompilerOnClassPathDoNotRunExecModel[3.5.0]
org.kie.maven.plugin.ExecModelParameterTest.testDefaultMavenWithDroolsModelCompilerOnClassPathRunsExecModel[3.5.0]
org.kie.server.integrationtests.common.KieServerIntegrationTest.initializationError
org.kie.karaf.itest.DecisionTablesIntegrationTest.testBasic
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[1]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[2]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[3]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[4]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[5]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[6]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[7]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[8]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[9]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[10]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[11]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[13]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[14]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[15]
org.kie.karaf.itest.InstallFeaturesKarafIntegrationTest.testInstallFeature[18]
org.kie.karaf.itest.KieDMNKarafIntegrationTest.testDMNbasic
org.kie.karaf.itest.KieSpringDependencyKarafIntegrationTest.testKieBase
org.kie.karaf.itest.KieSpringMetaInfAppContextKarafIntegrationTest.testKieBase
org.kie.karaf.itest.KieSpringjBPMPersistenceKarafIntegrationTest.testJbpmRuntimeManagerWithPersistence
org.kie.karaf.itest.KieSpringjBPMPersistenceKarafIntegrationTest.testJbpmRuntimeManager
org.kie.karaf.itest.RuntimeManagerFeatureKarafIntegrationTest.testJbpmRuntimeManager
org.kie.karaf.itest.SimpleKieSpringKarafIntegrationTest.testKieSession
org.kie.karaf.itest.SimpleKieSpringKarafIntegrationTest.testKieBase
org.kie.karaf.itest.SimpleKieSpringKarafIntegrationTest.testKieSessionDefaultType
org.kie.karaf.itest.WorkbenchModelsKarafIntegrationTest.buildKieBaseFromSimpleGuidedDTable
org.kie.karaf.itest.WorkbenchModelsKarafIntegrationTest.buildKieBaseFromAdvancedDTableUsingFQCN
org.kie.karaf.itest.blueprint.KieBlueprintDependencyKarafIntegrationTest.testKieBase
org.kie.karaf.itest.blueprint.KieBlueprintImportIntegrationTest.kieElementsExistTest
org.kie.karaf.itest.blueprint.KieBlueprintImportIntegrationTest.kieSessionOldPersonTest
org.kie.karaf.itest.blueprint.KieBlueprintImportIntegrationTest.kieSessionYoungPersonTest
org.kie.karaf.itest.blueprint.KieBlueprintProcessDependencyKarafIntegrationTest.testKieBase
org.kie.karaf.itest.blueprint.KieBlueprintProcessDependencyKarafIntegrationTest.testStartProcess
org.kie.karaf.itest.blueprint.KieBlueprintScannerReimportIntegrationTest.testKieBaseUpdatedByScanNow
org.kie.karaf.itest.blueprint.KieBlueprintScannerReimportIntegrationTest.testKieBaseUpdatedByTimer
org.kie.karaf.itest.camel.kiecamel.KieCamelBlueprintCommandIntegrationTest.testYoungPerson
org.kie.karaf.itest.camel.kiecamel.KieCamelBlueprintCommandIntegrationTest.testOldPerson
org.kie.karaf.itest.camel.kiecamel.KieCamelBlueprintDTIntegrationTest.testFavouriteCheese
org.kie.karaf.itest.camel.kiecamel.KieCamelBlueprintDTIntegrationTest.testNonFavouriteCheese
org.kie.karaf.itest.camel.kiecamel.KieCamelBlueprintIntegrationTest.testYoungPerson
org.kie.karaf.itest.camel.kiecamel.KieCamelBlueprintIntegrationTest.testOldPerson
org.kie.karaf.itest.camel.kiecamel.KieCamelRemoteIntegrationTest.testExecuteCommand
org.kie.karaf.itest.camel.kiecamel.KieCamelRemoteIntegrationTest.testGetProcessDefinition
org.kie.karaf.itest.camel.kiecamel.KieCamelRemoteIntegrationTest.testStartProcess
org.kie.karaf.itest.camel.kiecamel.KieCamelRemoteIntegrationTest.testListContainers
org.kie.karaf.itest.pmml.KiePmmlIntegrationTest.testSetup1
org.kie.hacep.KafkaTest.testKafkaLoggerWithStringTest
org.kie.hacep.PodAsReplicaTest.processOneSentMessageAsLeaderAndThenReplicaTest
org.kie.server.integrationtests.common.KieServerContainerCRUDIntegrationTest.initializationError
org.kie.server.integrationtests.common.jms.ContainerJmsResponseHandlerIntegrationTest.initializationError
org.kie.server.integrationtests.common.rest.RestMalformedRequestIntegrationTest.org.kie.server.integrationtests.common.rest.RestMalformedRequestIntegrationTest
org.kie.server.springboot.samples.KieServerTest.testProcessStartAndWorkOnUserTask
org.kie.server.springboot.samples.KieServerMigrationTest.testProcessStartAndAbort

jomarko · 2020-07-24T03:37:04Z

Jenkins do full downstream build

jstastny-cz · 2020-07-28T12:58:48Z

Jenkins do full downstream build

For more details see https://issues.redhat.com/browse/DROOLS-5521

jomarko · 2020-08-03T09:16:49Z

Jenkins do full downstream build

sonarcloud · 2020-08-03T09:48:03Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

100.0% Coverage
0.0% Duplication

The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

jomarko · 2020-08-04T06:00:31Z

failed tests:

org.kie.server.integrationtests.common.KieServerIntegrationTest.org.kie.server.integrationtests.common.KieServerIntegrationTest
org.kie.server.integrationtests.common.KieServerContainerCRUDIntegrationTest.initializationError
org.kie.server.integrationtests.common.jms.ContainerJmsResponseHandlerIntegrationTest.initializationError
org.kie.server.integrationtests.common.rest.RestMalformedRequestIntegrationTest.org.kie.server.integrationtests.common.rest.RestMalformedRequestIntegrationTest
org.kie.hacep.KafkaTest.testKafkaLoggerWithStringTest
org.kie.hacep.PodAsReplicaTest.processOneSentMessageAsLeaderAndThenReplicaTest
org.kie.server.springboot.samples.KieServerTest.testProcessStartAndWorkOnUserTask
org.kie.server.springboot.samples.KieServerMigrationTest.testProcessStartAndAbort

jomarko · 2020-08-04T06:00:38Z

Jenkins do full downstream build

jomarko · 2020-08-04T11:27:21Z

Failed tests:

org.kie.server.integrationtests.taskassigning.TaskAssigningIntegrationTest.org.kie.server.integrationtests.taskassigning.TaskAssigningIntegrationTest
org.kie.hacep.KafkaTest.testKafkaLoggerWithStringTest
org.kie.hacep.PodAsReplicaTest.processOneSentMessageAsLeaderAndThenReplicaTest
org.kie.server.springboot.samples.KieServerTest.testProcessStartAndWorkOnUserTask
org.kie.server.springboot.samples.KieServerMigrationTest.testProcessStartAndAbort

jomarko · 2020-08-04T11:27:50Z

Jenkins do full downstream build

jomarko · 2020-08-05T08:17:06Z

failed tests:

org.kie.server.integrationtests.jbpm.ExceptionHandlingIntegrationTest.testTransactionExceptionHandlerInSubprocess[0: JAXB KieServicesConfiguration{transport=REST, serverUrl='http://localhost:46272/kie-server-services/services/rest/server'}]
org.kie.server.integrationtests.jbpm.ExceptionHandlingIntegrationTest.testTransactionExceptionHandlerInSubprocess[1: JSON KieServicesConfiguration{transport=REST, serverUrl='http://localhost:46272/kie-server-services/services/rest/server'}]
org.kie.server.integrationtests.jbpm.ExceptionHandlingIntegrationTest.testTransactionExceptionHandlerInSubprocess[2: XSTREAM KieServicesConfiguration{transport=REST, serverUrl='http://localhost:46272/kie-server-services/services/rest/server'}]
org.kie.server.integrationtests.jbpm.ExceptionHandlingIntegrationTest.testTransactionExceptionHandlerInSubprocess[3: JAXB KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.integrationtests.jbpm.ExceptionHandlingIntegrationTest.testTransactionExceptionHandlerInSubprocess[4: JSON KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.integrationtests.jbpm.ExceptionHandlingIntegrationTest.testTransactionExceptionHandlerInSubprocess[5: XSTREAM KieServicesConfiguration{transport=JMS, serverUrl='null'}]
org.kie.server.springboot.samples.KieServerTest.testProcessStartAndWorkOnUserTask
org.kie.server.springboot.samples.KieServerMigrationTest.testProcessStartAndAbort

jstastny-cz · 2020-08-05T10:38:43Z

Failed tests are unrelated to the change - checking with the BC that has been built during the FDB.

jstastny-cz · 2020-08-05T12:44:50Z

Verified the fix in FDB too. Safe to merge.

jomarko changed the title ~~DROOLS-5521: Hanlde pressing TAB when editing last cell~~ DROOLS-5521: Handle pressing TAB when editing last cell Jul 22, 2020

jomarko force-pushed the DROOLS-5521 branch from d4c354a to edd969b Compare July 22, 2020 12:01

jomarko requested a review from jstastny-cz July 22, 2020 12:02

yesamer approved these changes Jul 22, 2020

View reviewed changes

jomarko mentioned this pull request Jul 23, 2020

[7.39.x] DROOLS-5442: Asume column visibility during keyboard navigation #1005

Merged

jstastny-cz approved these changes Jul 23, 2020

View reviewed changes

Jozef Marko added 2 commits August 3, 2020 10:45

DROOLS-5521: Handle pressing TAB when editing last cell

b1448a3

For more details see https://issues.redhat.com/browse/DROOLS-5521

Apply Sonar suggestion

c70b9b2

jomarko force-pushed the DROOLS-5521 branch from bd5c8e0 to c70b9b2 Compare August 3, 2020 08:45

jstastny-cz merged commit 1cf7020 into kiegroup:master Aug 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DROOLS-5521: Handle pressing TAB when editing last cell #1006

DROOLS-5521: Handle pressing TAB when editing last cell #1006

jomarko commented Jul 22, 2020

yesamer left a comment

jomarko commented Jul 22, 2020

jomarko commented Jul 22, 2020

jomarko commented Jul 23, 2020

jomarko commented Jul 23, 2020

jomarko commented Jul 23, 2020

jomarko commented Jul 23, 2020

jomarko commented Jul 23, 2020

jomarko commented Jul 24, 2020

jomarko commented Jul 24, 2020

jstastny-cz commented Jul 28, 2020

jomarko commented Aug 3, 2020

sonarcloud bot commented Aug 3, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 5, 2020

jstastny-cz commented Aug 5, 2020

jstastny-cz commented Aug 5, 2020

DROOLS-5521: Handle pressing TAB when editing last cell #1006

DROOLS-5521: Handle pressing TAB when editing last cell #1006

Conversation

jomarko commented Jul 22, 2020

yesamer left a comment

Choose a reason for hiding this comment

jomarko commented Jul 22, 2020

jomarko commented Jul 22, 2020

jomarko commented Jul 23, 2020

jomarko commented Jul 23, 2020

jomarko commented Jul 23, 2020

jomarko commented Jul 23, 2020

jomarko commented Jul 23, 2020

jomarko commented Jul 24, 2020

jomarko commented Jul 24, 2020

jstastny-cz commented Jul 28, 2020

jomarko commented Aug 3, 2020

sonarcloud bot commented Aug 3, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 5, 2020

jstastny-cz commented Aug 5, 2020

jstastny-cz commented Aug 5, 2020