[7.39.x] DROOLS-5442: Asume column visibility during keyboard navigation #1005

jomarko · 2020-07-22T05:06:17Z

This is a cherry-pick of #998

jomarko · 2020-07-23T04:07:30Z

TODO include also #1006 cherry-pick

DROOLS-5442: Asume column visibility during keyboard navigation (kiegroup#998) DROOLS-5521: Handle pressing TAB when editing last cell For more details see: - https://issues.redhat.com/browse/DROOLS-5521 - https://issues.redhat.com/browse/DROOLS-5442

jomarko · 2020-08-03T10:36:26Z

Jenkins do full downstream build

jomarko · 2020-08-03T15:36:47Z

Jenkins do full downstream build

jomarko · 2020-08-04T06:01:23Z

failed tests:

org.kie.camel.container.integration.tests.remote.KieServicesClientIntegrationTest.testGetKieServerState
org.kie.camel.container.integration.tests.ProcessEngineIntegrationTest.testSignalToProcess
org.kie.camel.container.integration.tests.ProcessEngineIntegrationTest.testStartProcess
org.kie.camel.container.integration.tests.ProcessEngineIntegrationTest.testGetProcessIds
org.kie.camel.container.integration.tests.RuleEngineIntegrationTest.testInsertGetDeleteFact
org.kie.camel.container.integration.tests.RuleEngineIntegrationTest.testSetGetGlobal
org.kie.camel.container.integration.tests.RuleEngineIntegrationTest.testFireAllRules
org.kie.camel.container.integration.tests.RuleEngineIntegrationTest.testRuleEvaluationService
org.kie.camel.container.integration.tests.remote.KieServicesClientIntegrationTest.testGetKieServerInfo
org.kie.camel.container.integration.tests.remote.KieServicesClientIntegrationTest.testGetKieServerInfo
org.kie.camel.container.integration.tests.remote.KieServicesClientIntegrationTest.testGetKieServerInfo
org.kie.camel.container.integration.tests.remote.KieServicesClientIntegrationTest.testDeactivateActivateContainer
org.kie.camel.container.integration.tests.remote.KieServicesClientIntegrationTest.testDeactivateActivateContainer
org.kie.camel.container.integration.tests.remote.KieServicesClientIntegrationTest.testDeactivateActivateContainer
org.kie.camel.container.integration.tests.remote.KieServicesClientIntegrationTest.testListContainers
org.kie.camel.container.integration.tests.remote.KieServicesClientIntegrationTest.testListContainers
org.kie.camel.container.integration.tests.remote.KieServicesClientIntegrationTest.testListContainers
org.kie.camel.container.integration.tests.remote.ProcessClientIntegrationTest.testGetProcessDefinition
org.kie.camel.container.integration.tests.remote.ProcessClientIntegrationTest.testGetProcessDefinition
org.kie.camel.container.integration.tests.remote.ProcessClientIntegrationTest.testGetProcessDefinition
org.kie.camel.container.integration.tests.remote.ProcessClientIntegrationTest.testStartProcess
org.kie.camel.container.integration.tests.remote.ProcessClientIntegrationTest.testStartProcess
org.kie.camel.container.integration.tests.remote.ProcessClientIntegrationTest.testStartProcess
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesById
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesById
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesById
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesByContainerId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesByContainerId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesByContainerId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessByContainerIdProcessId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessByContainerIdProcessId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessByContainerIdProcessId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testListQueries
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testListQueries
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testListQueries
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstances
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstances
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstances
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstancesByStatus
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstancesByStatus
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstancesByStatus
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesByContainerIdWrongId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesByContainerIdWrongId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesByContainerIdWrongId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcesses
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcesses
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcesses
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstanceByInitiator
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstanceByInitiator
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstanceByInitiator
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstancesByContainerId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstancesByContainerId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstancesByContainerId
org.kie.hacep.KafkaTest.basicTest
org.kie.hacep.KafkaTest.testKafkaLoggerWithStringTest
org.kie.hacep.PodAsLeaderSnapshotTest.processMessagesAsLeaderAndCreateSnapshotTest
org.kie.hacep.PodAsLeaderTest.processOneSentMessageAsLeaderTest
org.kie.hacep.PodAsReplicaTest.processOneSentMessageAsLeaderAndThenReplicaTest
org.kie.hacep.RemoteKieSessionImplTest.getFactCountTest
org.kie.hacep.RemoteStreamingKieSessionImplTest.getListKieSessionObjectsWithClassTypeTest
org.kie.hacep.RemoteStreamingKieSessionImplTest.getFactCountTest
org.kie.hacep.RemoteStreamingKieSessionImplTest.getListKieSessionObjectsTest
org.kie.hacep.RemoteStreamingKieSessionImplTest.getListKieSessionObjectsWithNamedQueryTest
org.kie.hacep.SnapshotOnDemandTest.createSnapshotOnDemandTest
org.kie.hacep.core.infra.SnapshotOnDemandUtilsTest.askAKafkaConsumerWithoutServerUpTest
org.kie.hacep.core.infra.SnapshotOnDemandUtilsTest.askASnapshotWithoutServerUpTest
org.kie.hacep.core.infra.utils.ConsumerUtilsCoreTest.lastEventWithoutKafkaUpTest

jomarko · 2020-08-04T06:01:34Z

Jenkins do full downstream build

jomarko · 2020-08-04T11:29:09Z

Failed tests:

org.kie.spring.tests.KieSpringEnvironmentTest.org.kie.spring.tests.KieSpringEnvironmentTest
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryEnvTest.testPersistenceTimer2
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryEnvTest.testPersistenceWorkItemsUserTransaction
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryEnvTest.testPersistenceWorkItems
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryEnvTest.testPersistenceSubProcess
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceTimer2
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceWorkItemsUserTransaction
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceSubProcessWithListeners
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceWorkItems
org.kie.spring.tests.persistence.JPASingleSessionCommandServiceFactoryTest.testPersistenceSubProcess
org.kie.spring.tests.persistence.VariablePersistenceStrategyEnvTest.testPersistenceVariables
org.kie.spring.tests.persistence.VariablePersistenceStrategyEnvTest.testTransactionsRollback
org.kie.spring.tests.persistence.VariablePersistenceStrategyTest.testPersistenceVariables
org.kie.spring.tests.persistence.VariablePersistenceStrategyTest.testTransactionsRollback
org.kie.camel.container.integration.tests.ProcessEngineIntegrationTest.testSignalToProcess
org.kie.camel.container.integration.tests.ProcessEngineIntegrationTest.testStartProcess
org.kie.camel.container.integration.tests.ProcessEngineIntegrationTest.testGetProcessIds
org.kie.camel.container.integration.tests.RuleEngineIntegrationTest.testInsertGetDeleteFact
org.kie.camel.container.integration.tests.RuleEngineIntegrationTest.testSetGetGlobal
org.kie.camel.container.integration.tests.RuleEngineIntegrationTest.testFireAllRules
org.kie.camel.container.integration.tests.RuleEngineIntegrationTest.testRuleEvaluationService
org.kie.camel.container.integration.tests.remote.ProcessClientIntegrationTest.testGetProcessDefinition
org.kie.camel.container.integration.tests.remote.ProcessClientIntegrationTest.testGetProcessDefinition
org.kie.camel.container.integration.tests.remote.ProcessClientIntegrationTest.testGetProcessDefinition
org.kie.camel.container.integration.tests.remote.ProcessClientIntegrationTest.testStartProcess
org.kie.camel.container.integration.tests.remote.ProcessClientIntegrationTest.testStartProcess
org.kie.camel.container.integration.tests.remote.ProcessClientIntegrationTest.testStartProcess
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesById
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesById
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesById
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesByContainerId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesByContainerId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesByContainerId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessByContainerIdProcessId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessByContainerIdProcessId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessByContainerIdProcessId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testListQueries
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testListQueries
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testListQueries
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstances
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstances
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstances
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstancesByStatus
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstancesByStatus
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstancesByStatus
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesByContainerIdWrongId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesByContainerIdWrongId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessesByContainerIdWrongId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcesses
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcesses
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcesses
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstanceByInitiator
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstanceByInitiator
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstanceByInitiator
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstancesByContainerId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstancesByContainerId
org.kie.camel.container.integration.tests.remote.QueryClientIntegrationTest.testFindProcessInstancesByContainerId

jomarko · 2020-08-04T11:29:45Z

Jenkins do full downstream build

jomarko · 2020-08-05T13:00:50Z

failed tests:

org.kie.hacep.KafkaTest.basicTest
org.kie.hacep.KafkaTest.testKafkaLoggerWithStringTest
org.kie.hacep.PodAsLeaderSnapshotTest.processMessagesAsLeaderAndCreateSnapshotTest
org.kie.hacep.PodAsLeaderTest.processOneSentMessageAsLeaderTest
org.kie.hacep.PodAsReplicaTest.processOneSentMessageAsLeaderAndThenReplicaTest
org.kie.hacep.RemoteKieSessionImplTest.getFactCountTest
org.kie.hacep.RemoteStreamingKieSessionImplTest.getListKieSessionObjectsWithClassTypeTest
org.kie.hacep.RemoteStreamingKieSessionImplTest.getFactCountTest
org.kie.hacep.RemoteStreamingKieSessionImplTest.getListKieSessionObjectsTest
org.kie.hacep.RemoteStreamingKieSessionImplTest.getListKieSessionObjectsWithNamedQueryTest
org.kie.hacep.SnapshotOnDemandTest.createSnapshotOnDemandTest
org.kie.hacep.core.infra.SnapshotOnDemandUtilsTest.askAKafkaConsumerWithoutServerUpTest
org.kie.hacep.core.infra.SnapshotOnDemandUtilsTest.askASnapshotWithoutServerUpTest
org.kie.hacep.core.infra.utils.ConsumerUtilsCoreTest.lastEventWithoutKafkaUpTest

sonarcloud · 2020-08-05T14:51:13Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

95.7% Coverage
0.0% Duplication

The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

jomarko · 2020-08-06T04:23:25Z

@mareknovotny the failed test org.kie.bc.DeploymentIT seems be unrelated . Could we please merge? What is your opinion?

Rikkola · 2020-08-06T05:33:08Z

We had green in master. Can't really see how this change breaks anything here.

mareknovotny · 2020-08-06T06:30:35Z

the relevant jobs are:

Linux - Full Downstream Build — Build finished. 64671 tests run, 693 skipped, 1 failed.
Pull Request Execution — Build finished. 6160 tests run, 15 skipped, 1 failed.

jomarko force-pushed the DROOLS-5442-7.39.x branch from 83f99d5 to fdda877 Compare July 23, 2020 08:07

jomarko marked this pull request as ready for review August 3, 2020 10:36

jomarko requested review from Rikkola, yesamer and jstastny-cz August 3, 2020 10:36

yesamer approved these changes Aug 3, 2020

View reviewed changes

Rikkola approved these changes Aug 3, 2020

View reviewed changes

jstastny-cz approved these changes Aug 5, 2020

View reviewed changes

mareknovotny merged commit 098a8e1 into kiegroup:7.39.x Aug 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[7.39.x] DROOLS-5442: Asume column visibility during keyboard navigation #1005

[7.39.x] DROOLS-5442: Asume column visibility during keyboard navigation #1005

jomarko commented Jul 22, 2020

jomarko commented Jul 23, 2020

jomarko commented Aug 3, 2020

jomarko commented Aug 3, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 5, 2020

sonarcloud bot commented Aug 5, 2020

jomarko commented Aug 6, 2020 •

edited

Rikkola commented Aug 6, 2020

mareknovotny commented Aug 6, 2020

[7.39.x] DROOLS-5442: Asume column visibility during keyboard navigation #1005

[7.39.x] DROOLS-5442: Asume column visibility during keyboard navigation #1005

Conversation

jomarko commented Jul 22, 2020

jomarko commented Jul 23, 2020

jomarko commented Aug 3, 2020

jomarko commented Aug 3, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 4, 2020

jomarko commented Aug 5, 2020

sonarcloud bot commented Aug 5, 2020

jomarko commented Aug 6, 2020 • edited

Rikkola commented Aug 6, 2020

mareknovotny commented Aug 6, 2020

jomarko commented Aug 6, 2020 •

edited