Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAI-173: Embed kogito-tooling editors in trusty-ai. Part 2 (trusty-ai changes) #980

Merged
merged 1 commit into from
Jun 4, 2020
Merged

FAI-173: Embed kogito-tooling editors in trusty-ai. Part 2 (trusty-ai changes) #980

merged 1 commit into from
Jun 4, 2020

Conversation

manstis
Copy link
Member

@manstis manstis commented Jun 2, 2020

@manstis manstis requested a review from ederign June 2, 2020 13:08
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

ederign
ederign reviewed Jun 4, 2020
View reviewed changes
...rmer-kogito-bridge/src/test/java/org/appformer/kogito/bridge/client/context/ChannelTest.java
@@ -30,6 +30,7 @@ public void withNameTest() {
assertEquals(Channel.ONLINE, Channel.withName("ONLine"));
assertEquals(Channel.VSCODE, Channel.withName("VSCode"));
assertEquals(Channel.DESKTOP, Channel.withName("Desktop"));
assertEquals(Channel.EMBEDDED, Channel.withName("emBedDED"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michael the weird cAsE here for the channel name is intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ederign yEs! To be honest I thought I was copying existing tests with mixed case, assuming we were verifying the case does not affect resolution of the enum member.. however now you've asked the question I see only ONLine has unexpected mixed case and accept it's probably a typo! If you'd prefer me to change (or add more) just say the word.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lEt'S meRGe tHIs

@ederign ederign merged commit 71b76c1 into kiegroup:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ederign ederign ederign left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manstis @ederign