Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DROOLS-5442: Asume column visibility during keyboard navigation #998

Merged
merged 1 commit into from Jul 16, 2020
Merged

DROOLS-5442: Asume column visibility during keyboard navigation #998

merged 1 commit into from Jul 16, 2020

Conversation

jomarko
Copy link

@jomarko jomarko commented Jul 1, 2020

@jomarko
Copy link
Author

jomarko commented Jul 1, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented Jul 1, 2020

PR is in draft state as the component is general. Checking if tests of other repositories are not affected. Then tests for actual changes will be provided.

@jomarko
Copy link
Author

jomarko commented Jul 3, 2020

Jenkins do full downstream build

@jomarko jomarko marked this pull request as ready for review July 3, 2020 11:41
@jomarko
Copy link
Author

jomarko commented Jul 7, 2020

Jenkins do full downstream build

@jomarko
Copy link
Author

jomarko commented Jul 7, 2020

Jenkins do full downstream build

@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@Rikkola
Copy link
Member

Rikkola commented Jul 8, 2020

Looks like code coverage works again :)

@jomarko
Copy link
Author

jomarko commented Jul 8, 2020

@Rikkola actually no, see my DROOLS-5496

@jomarko
Copy link
Author

jomarko commented Jul 16, 2020

@kiegroup/gatekeepers please merge

@mareknovotny
Copy link
Member

Jenkins execute compile downstream build

@jomarko
Copy link
Author

jomarko commented Jul 16, 2020

@mareknovotny seems all green now

@karreiro karreiro merged commit c73f3b8 into kiegroup:master Jul 16, 2020
jomarko pushed a commit to jomarko/appformer that referenced this pull request Jul 22, 2020
DROOLS-5442: Asume column visibility during keyboard navigation (kieg…
83f99d5 
…roup#998)

DROOLS-5442: Asume column visibility during keyboard navigation (kiegroup#998)
@jomarko jomarko mentioned this pull request Jul 22, 2020
Merged
jomarko pushed a commit to jomarko/appformer that referenced this pull request Jul 23, 2020
DROOLS-5442 & DROOLS-5521: Fix grid column keyboard control
fdda877 
DROOLS-5442: Asume column visibility during keyboard navigation (kiegroup#998)

DROOLS-5521: Handle pressing TAB when editing last cell

For more details see:
- https://issues.redhat.com/browse/DROOLS-5521
- https://issues.redhat.com/browse/DROOLS-5442
mareknovotny pushed a commit that referenced this pull request Aug 6, 2020
@mareknovotny
DROOLS-5442 & DROOLS-5521: Fix grid column keyboard control
098a8e1 
DROOLS-5442: Asume column visibility during keyboard navigation (#998)

DROOLS-5521: Handle pressing TAB when editing last cell

For more details see:
- https://issues.redhat.com/browse/DROOLS-5521
- https://issues.redhat.com/browse/DROOLS-5442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rikkola Rikkola Rikkola approved these changes

@jstastny-cz jstastny-cz jstastny-cz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@jomarko @Rikkola @mareknovotny @jstastny-cz @karreiro