Drools 3619 More property headers can have the same alias

[gitgabrio]

@kkufova @Rikkola @danielezonca

https://issues.jboss.org/browse/DROOLS-3619

[kkufova]

@gitgabrio, it does not work.

[gitgabrio]

@kkufova
Fixed.

[kkufova]

What we decided:

• it should not be possible to use the same alias for two properties within the same instance;
• it should be possible to use the same alias for two properties of two different instances;
• if a property is renamed in GIVEN, the same property must be renamed in EXPECT and vice versa;
• it should not be possible to use an alias for a property in GIVEN (Book.name) and the same alias for a different property in EXPECT (Book.copies)
  -- this means that aliases are unique within one instance, regardless of position (GIVEN or EXPECT).

[Rikkola]

Minor comment are the years 2018 in new files. I think this is because the files were just moved, but if you need to touch the PR for some other reason perhaps fix them.

[kkufova]

@gitgabrio, the last requirement is not satisfied:

it should not be possible to use an alias for a property in GIVEN (Book.name) and the same alias for a different property in EXPECT (Book.copies)

[gitgabrio]

1. GIVEN - Book - name -> rename to "huhu"
2. EXPECT - Book - numberOfCopies -> rename to "huhu"

it should not be possible

[gitgabrio]

@kkufova
Klara please retest this ( 😄 )

[kkufova]

Everything works well, I didn't discover any bugs. Approving.

👍

[kkufova]

@manstis, could you please merge this?