Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.18.x] DROOLS-3724 : Defining non default Kie Base and Kie Session results in a hang in the Test Scenario Runner #1086

Merged
merged 1 commit into from
Mar 4, 2019
Merged

[7.18.x] DROOLS-3724 : Defining non default Kie Base and Kie Session results in a hang in the Test Scenario Runner #1086

merged 1 commit into from
Mar 4, 2019

Conversation

Rikkola
Copy link
Member

@Rikkola Rikkola commented Mar 1, 2019 •
edited
Loading

@Rikkola
DROOLS-3724 : Defining non default Kie Base and Kie Session results i…
0d405a4 
…n a hang in the Test Scenario Runner

(cherry picked from commit 11f726e)
@Rikkola Rikkola changed the title DROOLS-3724 : Defining non default Kie Base and Kie Session results in a hang in the Test Scenario Runner [7.18.x] DROOLS-3724 : Defining non default Kie Base and Kie Session results in a hang in the Test Scenario Runner Mar 1, 2019
@manstis manstis requested review from manstis and kkufova March 1, 2019 21:04
@manstis
Copy link
Member

manstis commented Mar 1, 2019

@Rikkola Would you mind explaining what the issue was and why this PR fixes it?

Looking at the changes you appear to have simply changed the parameter passed to the Audit View.

manstis
manstis approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, as I guess it was a NPE that caused the problem.

@Rikkola
Copy link
Member Author

Rikkola commented Mar 1, 2019

The rule name array is null and that causes the NPE. So the fix is to check if the array is null and use an empty list in that case.

@Rikkola
Copy link
Member Author

Rikkola commented Mar 1, 2019 •
edited
Loading

The issue also only happens if you only have Stateless ksession set up and when you don't specify the session before you run it.
@kkufova best way to reproduce the fixed issue:

  1. Make a new project
  2. Make a new kbase and ksession of the type Stateless
  3. Make a new legacy test scenario and run it. (empty one works just fine)

kkufova
kkufova approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@kkufova kkufova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works well. Approving.

👍

@Rikkola
Copy link
Member Author

Rikkola commented Mar 4, 2019 •
edited
Loading

Wait wait with the merge. Double checking from @mbiarnes just to be sure

@manstis manstis merged commit 3a660d0 into kiegroup:7.18.x Mar 4, 2019
@Rikkola
Copy link
Member Author

Rikkola commented Mar 4, 2019

Yep it was fine

@Rikkola Rikkola deleted the DROOLS-3724-7.18.x branch March 4, 2019 12:01
@Rikkola Rikkola restored the DROOLS-3724-7.18.x branch January 25, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manstis manstis manstis approved these changes

@kkufova kkufova kkufova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rikkola @manstis @kkufova