-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added handling an end key for selecting bottom right cell in scenario… #1279
Added handling an end key for selecting bottom right cell in scenario… #1279
Conversation
… editor for testing purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dupliaka
Code Review: Passed
Manual Test: Done, it works for me.
jenkins please retest this |
jenkins please retest this |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@kiegroup/gatekeepers please merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, thank you @dupliaka
@jomarko - I am fully agree with you that this is a new feature and it could be lost, but I am not happy with the process when
|
@dupliaka not sure I get you point, but I would like to say, that I do not see this situation in some negative way. You came to that feature in the middle of process as new team member and realized you need this shortcut for testing with some delay. I do not see as negative thing that we are adding some code to to product to facilitate testing. Even more, the added code is completely valid for any human user. If you do not want to invest more time into this PR, fine for me, take my note just a note for future. |
@jomarko I created an jira ench:https://issues.redhat.com/browse/DROOLS-4923 |
@dupliaka thank you, please include DROOLS-4923 in the PR summary/title and we can merge |
@jomarko Done, thanks! |
@kiegroup/gatekeepers please merge |
… editor for testing purposes.
Based on:
https://issues.redhat.com/browse/DROOLS-4923