Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handling an end key for selecting bottom right cell in scenario… #1279

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

dupliaka
Copy link
Member

@dupliaka dupliaka commented Jan 8, 2020

… editor for testing purposes.
Based on:
https://issues.redhat.com/browse/DROOLS-4923

@dupliaka dupliaka requested a review from yesamer January 8, 2020 16:42
Copy link
Member

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dupliaka
Code Review: Passed
Manual Test: Done, it works for me.

@dupliaka
Copy link
Member Author

dupliaka commented Jan 9, 2020

jenkins please retest this

@dupliaka
Copy link
Member Author

dupliaka commented Jan 9, 2020

jenkins please retest this

@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dupliaka
Copy link
Member Author

dupliaka commented Jan 9, 2020

@kiegroup/gatekeepers please merge

@manstis
Copy link
Member

manstis commented Jan 9, 2020

Don't we need a QE review too @dupliaka / @yesamer?

@yesamer
Copy link
Member

yesamer commented Jan 9, 2020

@manstis Honestly in this case, where a QE opened the PR, I don't know exactly how to proceed. Probably we can ask to @jomarko to provide a QE review?

@jomarko jomarko self-requested a review January 9, 2020 15:35
Copy link

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, thank you @dupliaka

@jomarko
Copy link

jomarko commented Jan 10, 2020

However I realized one thing. We should create a jira in DROOLS project about this change, otherwise we have no record about this new feature. In that jira we can set appropriate "fix version". So if anyone reading release notes will wind out this new feature.what do you think @dupliaka @yesamer ?

@dupliaka
Copy link
Member Author

@jomarko - I am fully agree with you that this is a new feature and it could be lost, but I am not happy with the process when

  1. You need to change production code to test the feature
  2. You need to pass the full cycle of approve for the feature that is Only For Testing and not regards to the application functionality
  3. If that takes so much effort I would find another way to do that.

@jomarko
Copy link

jomarko commented Jan 10, 2020

@dupliaka not sure I get you point, but I would like to say, that I do not see this situation in some negative way.

You came to that feature in the middle of process as new team member and realized you need this shortcut for testing with some delay.

I do not see as negative thing that we are adding some code to to product to facilitate testing. Even more, the added code is completely valid for any human user.

If you do not want to invest more time into this PR, fine for me, take my note just a note for future.

@dupliaka
Copy link
Member Author

@jomarko I created an jira ench:https://issues.redhat.com/browse/DROOLS-4923

@jomarko
Copy link

jomarko commented Jan 10, 2020

@dupliaka thank you, please include DROOLS-4923 in the PR summary/title and we can merge

@dupliaka
Copy link
Member Author

@jomarko Done, thanks!

@dupliaka
Copy link
Member Author

@kiegroup/gatekeepers please merge

@manstis manstis merged commit 5707745 into kiegroup:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants