Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch OptaPlanner 8: shell script changes #1376

Merged
merged 9 commits into from Jul 1, 2020

Conversation

ge0ffrey
Copy link
Collaborator

@ge0ffrey ge0ffrey commented Jun 26, 2020

Preparation for Monday.
Note that optaplanner hasn't branched 7.x yet on master (we'll do that on Monday), so if you try this locally, you'll need to mimic that.

  • git-clone-others.sh

The word master is mentioned in these files:

  • release/kie-upgrade-branch-auxiliary-reps.sh: not relevant, because this doesn't use the repository-list.txt repo's.
  • script/checks/oldbranches.pl:
  • script/utils/revapi-clean.sh: 2 commented out lines, but adjusted anyway
  • several files in the help message: not relevant

@mareknovotny mareknovotny requested a review from Ginxo June 26, 2020 16:30
script/git-clone-others.sh Outdated Show resolved Hide resolved
@ge0ffrey ge0ffrey marked this pull request as ready for review June 30, 2020 06:54
script/git-clone-others.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@mbiarnes mbiarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geoffrey doesn't work for me - could be ralated to kiegroup
or mbiarnes as organization?

script/git-clone-others.sh Outdated Show resolved Hide resolved
script/git-clone-others.sh Outdated Show resolved Hide resolved
script/git-clone-others.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@mbiarnes mbiarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM tested and works
tests:
1.Jenkins pipeline with --branch master
2.Jenkins pipeline with --branch 7.39.x
3.Jenkins free style job without -- branch
4.Jenkins free style job with --branch master
5.Jenkins free style job with --branch 7.39.x

@ge0ffrey ge0ffrey merged commit 3733834 into kiegroup:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants