Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-9178] Immutable SpringBoot Deployment / Adding controller conne… #2220

Merged
merged 1 commit into from
Sep 8, 2020
Merged

[JBPM-9178] Immutable SpringBoot Deployment / Adding controller conne… #2220

merged 1 commit into from
Sep 8, 2020

Conversation

elguardian
Copy link
Member

under test.

@elguardian elguardian marked this pull request as ready for review September 2, 2020 14:20
@elguardian
Copy link
Member Author

elguardian commented Sep 2, 2020 •
edited
Loading

depends on kiegroup/jbpm#1749

@elguardian
Copy link
Member Author

Jenkins retest this please.

afalhambra
afalhambra suggested changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@afalhambra afalhambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes required.
I would try to cover these scenarios adding some test cases, as test coverage is quite low here.

...er-spring-boot-autoconfiguration/src/main/java/org/kie/server/springboot/EmbeddedKieJar.java Show resolved Hide resolved
...on/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java Outdated Show resolved Hide resolved
...on/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java Outdated Show resolved Hide resolved
...on/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java Show resolved Hide resolved
...on/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java Show resolved Hide resolved
...ces-common/src/main/java/org/kie/server/services/impl/InmutableContainerStartupStrategy.java Outdated Show resolved Hide resolved
...ices-common/src/main/resources/META-INF/services/org.kie.server.services.api.StartupStrategy Show resolved Hide resolved
.../main/java/org/kie/server/services/impl/storage/memory/InMemoryKieServerStateRepository.java Show resolved Hide resolved
...on/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java Outdated Show resolved Hide resolved
...on/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java Outdated Show resolved Hide resolved
afalhambra
afalhambra suggested changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@afalhambra afalhambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some previous comment not resolved yet

...ces-common/src/main/java/org/kie/server/services/impl/InmutableContainerStartupStrategy.java Outdated
import org.kie.server.services.impl.storage.KieServerState;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;


public class InmutableContainerStartupStrategy implements StartupStrategy {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this not resolved yet

...on/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java Show resolved Hide resolved
...on/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java Show resolved Hide resolved
...on/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java Show resolved Hide resolved
afalhambra
afalhambra approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@afalhambra afalhambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job! very easy and intuitive to use. well done

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 2 Security Hotspots to review)
Code Smell A 6 Code Smells

3.4% 3.4% Coverage
11.4% 11.4% Duplication

warning The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@elguardian elguardian merged commit 1df0eeb into kiegroup:master Sep 8, 2020
@elguardian elguardian deleted the JBPM-9178_bis branch September 8, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afalhambra afalhambra afalhambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elguardian @afalhambra