JBPM-9383: Mark unstable tests to be skipped by PR check #2256
Conversation
sutaakar
force-pushed
the
ignore-unstable-tests
branch
from
26d4011
to
1176aff
Compare
|
Out of curiosity, what is the difference between this annotation and just delete the test? If we don't care if they're red or green to merge them then we can as well delete the tests |
|
The difference is a downstream check for certifications. In downstream the tests pass (I guess there must be some Jenkins difference though I wasn't able to identify it). |
|
We could move this test to the downstream suite then. |
|
@lucamolteni I prefer not to split the Kie server tests, rather keep them in one place. It is easier to maintain. |
mareknovotny
changed the title
|
failed tests are related to https://github.com/kiegroup/drools/pull/3133 and DROOLS-5685 @tarilabs @mariofusco have you checked the tests here in this repository? As the PR https://github.com/kiegroup/drools/pull/3133 didn't run FDB i am not sure if this is now really broken |
|
the test failures clearly exhibited a problem which has nothing to do with kie-server, the use-case was not tested on the drools.git repo which is now done with https://github.com/kiegroup/drools/pull/3133 I will check this one locally once again (sec) |
| @@ -183,6 +185,7 @@ public void testContainerCreatedAfterStartup() throws Exception { | |||
| } | |||
|
|
|||
| @Test | |||
| @Category({UnstableOnJenkinsPrBuilder.class}) | |||
There was a problem hiding this comment.
| @Category({UnstableOnJenkinsPrBuilder.class}) |
for me kiegroup/drools@1730221
resolved the issue
as I taken the steps to reproduce indicated in https://issues.redhat.com/browse/DROOLS-5685
that is:
I get:
There was a problem hiding this comment.
ok, i will try to trigger tests again, thanks @tarilabs for checking
There was a problem hiding this comment.
@tarilabs This test is not related to the issue which you reference in your comment. Is there any specific reason for removing the unstable flag here?
There was a problem hiding this comment.
Sorry @sutaakar it indeed it appears I've been marking over something unrelated. Sorry for noise.
There was a problem hiding this comment.
(please consider this resolved, as wrong comment 🙏 )
|
Jenkins retest this please |
|
Jenkins retest this please |
|
it seems master is failing for: although "interesting" since the only related modification was #2247 which was green as still can be seen in the PR page? |
|
Further data. As mentioned previously #2256 (comment) I can confirm however I have good reasons to believe the failure is actually caused by: https://github.com/kiegroup/drools/pull/3090 Since it's also shown in the failure log of this PR on Jenkins: https://rhba-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/KIE/job/master/job/pullrequest/job/droolsjbpm-integration-master.pr/4/ so while this latter PR might have fixed the Karaf infrastructure, it is showing the test under discussion was failing at that time. I am attempting a fix taking KOGITO-2853 into consideration. |
|
verified locally and can be fixed with: |
|
Jenkins retest this please |
|
Kudos, SonarCloud Quality Gate passed!
|
|
I merged #2261 where GA CI again works as deadlock were fixed |
|
@mareknovotny Can you please merge? |
|
@sutaakar yes, i am waiting only on GA CI to finish ;) |
Thank you for submitting this pull request
JIRA:
JBPM-9383
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream