Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBPM-9383: Mark unstable tests to be skipped by PR check #2256

Merged
merged 1 commit into from
Oct 7, 2020
Merged

JBPM-9383: Mark unstable tests to be skipped by PR check #2256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .../java/org/kie/server/integrationtests/controller/KieControllerStartupIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.kie.server.api.model.KieContainerResource;
import org.kie.server.api.model.KieContainerResourceList;
import org.kie.server.api.model.KieContainerStatus;
Expand All @@ -36,6 +37,7 @@
import org.kie.server.controller.api.model.spec.ContainerSpec;
import org.kie.server.controller.api.model.spec.ServerTemplate;
import org.kie.server.controller.api.model.spec.ServerTemplateList;
import org.kie.server.integrationtests.category.UnstableOnJenkinsPrBuilder;
import org.kie.server.integrationtests.config.TestConfig;
import org.kie.server.integrationtests.shared.KieServerAssert;
import org.kie.server.integrationtests.shared.KieServerDeployer;
Expand Down Expand Up @@ -183,6 +185,7 @@ public void testContainerCreatedAfterStartup() throws Exception {
}

@Test
@Category({UnstableOnJenkinsPrBuilder.class})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@Category({UnstableOnJenkinsPrBuilder.class})

for me kiegroup/drools@1730221
resolved the issue

as I taken the steps to reproduce indicated in https://issues.redhat.com/browse/DROOLS-5685

that is:
image

I get:

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will try to trigger tests again, thanks @tarilabs for checking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarilabs This test is not related to the issue which you reference in your comment. Is there any specific reason for removing the unstable flag here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @sutaakar it indeed it appears I've been marking over something unrelated. Sorry for noise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(please consider this resolved, as wrong comment 🙏 )

public void testContainerDisposedAfterStartup() throws Exception {
// Getting info from currently started kie server.
ServiceResponse<KieServerInfo> kieServerInfo = client.getServerInfo();
Expand Down
3 changes: 2 additions & 1 deletion ...est/java/org/kie/server/integrationtests/jbpm/NotificationSaveContentIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.kie.server.api.model.ReleaseId;
import org.kie.server.api.model.instance.TaskSummary;
import org.kie.server.integrationtests.category.JEEOnly;
import org.kie.server.integrationtests.category.UnstableOnJenkinsPrBuilder;
import org.kie.server.integrationtests.shared.KieServerDeployer;
import org.kie.server.integrationtests.shared.KieServerSynchronization;

Expand All @@ -34,7 +35,7 @@
import static org.junit.Assert.assertTrue;
import static org.kie.api.task.model.Status.Reserved;

@Category(JEEOnly.class)
@Category({JEEOnly.class,UnstableOnJenkinsPrBuilder.class}) // https://issues.redhat.com/browse/JBPM-9383
public class NotificationSaveContentIntegrationTest extends JbpmKieServerBaseIntegrationTest {

private static ReleaseId releaseId = new ReleaseId("org.kie.server.testing", CONTAINER_ID_NOTIFICATION,
Expand Down