Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GSS) [7.44.x] [RHPAM-3219] No Model definition in KIE Server Swagger API #2274

Merged
merged 4 commits into from Nov 11, 2020

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Oct 9, 2020

Moving response to ApiResponse

Depends on
#droolsjbpm-build-bootstrap:1527

JIRA:

RHPAM-3219

@fjtirado fjtirado changed the title [JBPM-9410] No Model definition in KIE Server Swagger API [RHPAM-3219] No Model definition in KIE Server Swagger API Oct 13, 2020
@MarianMacik
Copy link
Member

@fjtirado can you please incorporate #2294? The explanation is in the PR description. Thanks!

@elguardian elguardian self-requested a review October 28, 2020 10:59
Copy link
Member

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjtirado plz check @MarianMacik comment.

@elguardian elguardian changed the title [RHPAM-3219] No Model definition in KIE Server Swagger API (GSS) [7.44.x] [RHPAM-3219] No Model definition in KIE Server Swagger API Oct 28, 2020
@elguardian
Copy link
Member

Jenkins retest this please.

@MarianMacik
Copy link
Member

@fjtirado Can you please add missing ignores? I think we are missing something like

{
  "code": "java.annotation.added",
  "annotationType": "io.swagger.annotations.ApiOperation",
  "elementKind": "method",
  "classSimpleName": "CaseQueryResource",
  "justification": "[JBPM-9410] No Model definition in KIE Server Swagger API"
}

for the case-mgmt module

and

{
  "code": "java.annotation.added",
  "annotationType": "io.swagger.annotations.ApiOperation",
  "elementKind": "method",
  "classSimpleName": "RuntimeDataResource",
  "justification": "[JBPM-9410] No Model definition in KIE Server Swagger API"
}

for the jbpm module.

@fjtirado
Copy link
Contributor Author

@kiegroup/gatekeepers Failed test seems unrelated, can we merge this?

@elguardian
Copy link
Member

@fjtirado needs rebase.

Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@fjtirado
Copy link
Contributor Author

jenkins retest this

fjtirado and others added 3 commits November 11, 2020 10:54
(kiegroup#2294)

Conflicts:
	kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-case-mgmt/src/build/revapi-config.json
	kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-jbpm/src/build/revapi-config.json
@elguardian
Copy link
Member

@fjtirado can you check the error ?
12:20:25 Caused by: java.lang.IllegalStateException: /home/jenkins/workspace/KIE/7.44.x/pullrequest/droolsjbpm-integration-7.44.x.pullrequests/kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-jbpm/src/main/java/org/kie/server/remote/rest/jbpm/ProcessResource.java:434:1: expecting RCURLY, found '<<'

Conflicts:
	kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-common/src/build/revapi-config.json
	kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-jbpm-ui/src/build/revapi-config.json
@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
6.6% 6.6% Duplication

warning The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11.
Read more here

@elguardian elguardian merged commit bdab641 into kiegroup:7.44.x Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants