Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-9410] Add Swagger test and fix missing methods #2300

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

gmunozfe
Copy link
Member

JIRA: JBPM-9410

referenced Pull Requests:

Added a test for checking if all get/post methods contain schema inside successful responses.
Fixed missing methods detected when adding the test.

@gmunozfe gmunozfe changed the title [JBPM-9410] Add test and fix missing methods [JBPM-9410] Add Swagger test and fix missing methods Oct 27, 2020
Copy link
Contributor

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!!!

@gmunozfe gmunozfe force-pushed the JBPM-9410 branch 2 times, most recently from 2085a9b to 7caf2ab Compare October 28, 2020 11:14
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@afalhambra afalhambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Well done!

@gmunozfe
Copy link
Member Author

gmunozfe commented Nov 3, 2020

@kiegroup/gatekeepers could you merge this?

@mareknovotny mareknovotny merged commit 64e8c40 into kiegroup:master Nov 3, 2020
fjtirado pushed a commit to fjtirado/droolsjbpm-integration that referenced this pull request Nov 10, 2020
Conflicts:
	kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-common/src/build/revapi-config.json
	kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-jbpm-ui/src/build/revapi-config.json
fjtirado pushed a commit to fjtirado/droolsjbpm-integration that referenced this pull request Nov 11, 2020
Conflicts:
	kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-common/src/build/revapi-config.json
	kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-jbpm-ui/src/build/revapi-config.json
fjtirado pushed a commit to fjtirado/droolsjbpm-integration that referenced this pull request Nov 11, 2020
Conflicts:
	kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-common/src/build/revapi-config.json
	kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-jbpm-ui/src/build/revapi-config.json
elguardian pushed a commit that referenced this pull request Nov 11, 2020
Conflicts:
	kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-common/src/build/revapi-config.json
	kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-jbpm-ui/src/build/revapi-config.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants