JBPM-9550 [GSS] (7.8.x) Business Central - Blank process diagram for … #2422
Conversation
|
Jenkins run fdb |
bxf12315
requested review from
prashuts,
nmirasch,
cristianonicolai and
elguardian
| nextUrl = loadBalancer.getUrl(); | ||
| try { | ||
| nextUrl = loadBalancer.getUrl(); | ||
| } catch (NoEndpointFoundException noEndpointFoundException) { |
There was a problem hiding this comment.
What should happen in case no endpoint is found?
According to your PR the execution flow will still run in while loop. AFAIK this is not a correct approach.
There was a problem hiding this comment.
if it does not have an endpoint, nextUrl will be null, it will break the loop[1].
The code will throw KieServerHttpRequestException [2].The KieServerHttpRequestException will catch by UI.
[1] https://github.com/kiegroup/droolsjbpm-integration/pull/2422/files/dfaf0d15e2efad5def94eb6512402a5d507253ad#diff-2e9dbb035c9f9deb6c6e3a76a2480f754db0f6221a0d5f8080eb8436b58968f4R876
[2] https://github.com/kiegroup/droolsjbpm-integration/pull/2422/files/dfaf0d15e2efad5def94eb6512402a5d507253ad#diff-2e9dbb035c9f9deb6c6e3a76a2480f754db0f6221a0d5f8080eb8436b58968f4R878
There was a problem hiding this comment.
Right, I overlooked the condition in the while, thanks
|
@elguardian @cristianonicolai The PR means, when entryponit throw timeout exception and load balancer do not have another one, loadBalancer.getUrl() will throw NoEndpointFoundException, and the NoEndpointFoundException do not catch by the client. |
| url = url.replace(failedBaseUrl, nextUrl); | ||
| logger.debug("Selecting next endpoint from load balancer - '{}'", url); | ||
| } catch (NoEndpointFoundException noEndpointFoundException) { | ||
| logger.warn(failedBaseUrl + " " + noEndpointFoundException.getMessage()); |
There was a problem hiding this comment.
| logger.warn(failedBaseUrl + " " + noEndpointFoundException.getMessage()); | |
| logger.warn("Cannot invoke request - '{}'", noEndpointFoundException.getMessage()); |
…processes with long running tasks
|
Jenkins run fdb |
|
Kudos, SonarCloud Quality Gate passed! |
…processes with long running tasks
Thank you for submitting this pull request
JIRA:
JBPM-9550
referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream