JBPM-9550 [GSS] (7.8.x) Business Central - Blank process diagram for … #1475
Conversation
bxf12315
requested review from
cristianonicolai,
nmirasch,
prashuts and
jstastny-cz
|
Jenkins run fdb |
|
Jenkins run fdb |
|
Jenkins run fdb |
| @@ -187,3 +187,4 @@ NavigationConfirmOkButtonText=Ok | |||
| NavigationConfirmMessage=Are you sure you want to go to Sub Process Diagram? | |||
| AlertPopupTitle=Can not navigate to Sub Process Diagram | |||
| AlertPopupMessage=There are multiple instances of the sub-process, please use the Sub Process Instances Panel instead. | |||
| CanNotGetTimerInstancesMessage=A long task is running and Timers cannot be displayed. Check again later. | |||
There was a problem hiding this comment.
This failure could be caused by other issues so I would recommend living it more generic, something like:
| CanNotGetTimerInstancesMessage=A long task is running and Timers cannot be displayed. Check again later. | |
| CanNotGetTimerInstancesMessage=Error trying to retrieve process instance timers details. Message: {0} |
|
Jenkins run fdb |
1 similar comment
|
Jenkins run fdb |
|
@bxf12315 Followed the steps as per ticket , I see issues after starting 'long.wait' instance - https://issues.redhat.com/browse/JBPM-9575 . |
|
Jenkins run fdb |
| }).getProcessInstanceDiagramSummary(processInstance.getProcessInstanceKey(), | ||
| preferences.getProcessInstanceDiagramCompletedNodeColor(), | ||
| preferences.getProcessInstanceDiagramCompletedNodeBorderColor(), | ||
| preferences.getProcessInstanceDiagramActiveNodeBorderColor()); | ||
| } | ||
|
|
||
| protected void loadTimerInstances() { | ||
| if (processInstance.getState() == 1) { |
There was a problem hiding this comment.
do we have the state as a constant somewhere? Would be nice to replace the literal here.
|
Jenkins run fdb |
|
Jenkins retest this |
|
@bxf12315 i see issue still persists (https://issues.redhat.com/browse/JBPM-9575) but its random , inconsistent. Please have a look |
please try again. |
|
Jenkins run fdb |
|
Build finished. 1073 tests run, 0 skipped, 8 failed. |
…processes with long running tasks
|
Jenkins run fdb |
|
@cristianonicolai @nmirasch can you please review again with regards to https://issues.redhat.com/browse/JBPM-9575 and advise? |
|
The Unexpected error dialog is considered a blocking issue, please see how the exception can be caught - I mean we're already processing it using the notifications, so we should have a fair grasp on the exception we're actually processing. |
|
@jstastny-cz the problem is not gone as to access timer info, we actually end up in a timeout sync with the process instance. If a timeout exception is not acceptable we need to look if it is possible to retrieve the same or similar information for timers without ending up in a concurrent call to the engine. |
|
@cristianonicolai I would say we want to handle the exception so that it does not bubble up into logs, nor to UI as Unexpected Error Dialog. I am considering the "Expected result" section of JBPM-9550, which states that no error log appears there (which is tied closely to the Unexpected Error Dialog showing up anyway). |
|
@bxf12315 @jstastny-cz so this is a partial fix only, it doesnt solve the entire issue. It needs to be look into further to try to avoid the exception at all. |
|
dependent on kiegroup/droolsjbpm-integration#2422 |
|
Jenkins run fdb |
|
Jenkins retest this |
|
Jenkins run fdb |
1 similar comment
|
Jenkins run fdb |
…processes with long running tasks
Thank you for submitting this pull request
JIRA:
JBPM-9550
referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)
kiegroup/droolsjbpm-integration#2422
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream