Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE DROOLS-1649 Avoid using Class.forName in static factory methods #248

Closed
wants to merge 11 commits into from

Conversation

tarilabs
Copy link
Member

@tarilabs tarilabs commented Jul 7, 2017

Opening PR to track progress and check downstream builds.

@tarilabs
Copy link
Member Author

tarilabs commented Jul 7, 2017

Jenkins execute full downstream build

[ERROR] Failed to execute goal org.revapi:revapi-maven-plugin:0.8.1:check (check) on project kie-api: The following API problems caused the build to fail:
[ERROR] java.class.externalClassExposedInAPI: interface org.slf4j.Logger: A class from supplementary archives is used in a public capacity in the API.
[ERROR] Use chain of the type in the old API: <null>
[ERROR] Use chain of the type in the new API: field org.kie.api.utils.ServiceRegistryImpl.logger has the type org.slf4j.Logger (field org.kie.api.utils.ServiceRegistryImpl.logger is part of the API) [org.slf4j:slf4j-api:jar:1.7.7]
[ERROR] java.class.externalClassExposedInAPI: interface org.slf4j.Marker: A class from supplementary archives is used in a public capacity in the API.
[ERROR] Use chain of the type in the old API: <null>
[ERROR] Use chain of the type in the new API: org.slf4j.Marker is used as a type parameter or type variable bound on method java.util.Iterator<org.slf4j.Marker> org.slf4j.Marker::iterator() <- org.slf4j.Marker is used as parameter in method void org.slf4j.Logger::info(org.slf4j.Marker, java.lang.String, java.lang.Object) <- field org.kie.api.utils.ServiceRegistryImpl.logger has the type org.slf4j.Logger (field org.kie.api.utils.ServiceRegistryImpl.logger is part of the API) [org.slf4j:slf4j-api:jar:1.7.7]
@tarilabs
Copy link
Member Author

tarilabs commented Jul 7, 2017

Added jbpm alignments.

Jenkins execute full downstream build

@tarilabs
Copy link
Member Author

tarilabs commented Jul 7, 2017

Added droolsjbpm-integration alignments.

Jenkins execute full downstream build

@tarilabs
Copy link
Member Author

tarilabs commented Jul 7, 2017

Jenkins execute full downstream build

@tarilabs
Copy link
Member Author

tarilabs commented Jul 7, 2017

Jenkins execute full downstream build

@tarilabs
Copy link
Member Author

tarilabs commented Jul 7, 2017

still todo:

@tarilabs
Copy link
Member Author

Superseded by Mario's PRs on branch mariofusco:d1649b

@tarilabs tarilabs closed this Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant