JBPM-7331 - Process and Task dashboard fail to load date based widgets #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgutierr
reviewed
May 31, 2018
| @@ -391,9 +398,13 @@ protected void handleDataSetGroup(DataSetDef def, DataSetGroup dataSetGroup, Lis | |||
| null, | |||
| Arrays.asList(groupFunction.getColumnId()))); | |||
| extraColumns.add(new DataColumnImpl(groupFunction.getSourceId(), | |||
| def.getColumnById(groupFunction.getColumnId()).getColumnType())); | |||
| getGroupFunctionColumnType(def.getColumnById(groupFunction.getColumnId()).getColumnType()))); | |||
| } | |||
There was a problem hiding this comment.
@cristianonicolai I think this DATE to LABEL "fix" must only be applied to the group column:
...
extraColumns.add(new DataColumnImpl(groupFunction.getSourceId(), getGroupFunctionColumnType(columnGroup, groupFunction)));
}
}
}
protected ColumnType getGroupFunctionColumnType(final ColumnGroup columnGroup, final GroupFunction groupFunction) {
ColumnType type = def.getColumnById(groupFunction.getColumnId()).getColumnType();
return type == ColumnType.DATE && columnGroup.getSourceId().equals(groupFunction.getSourceId()) ? ColumnType.LABEL : type;
}
wdyt?
There was a problem hiding this comment.
This makes sense to me so +1
mswiderski
approved these changes
May 31, 2018
| @@ -391,9 +398,13 @@ protected void handleDataSetGroup(DataSetDef def, DataSetGroup dataSetGroup, Lis | |||
| null, | |||
| Arrays.asList(groupFunction.getColumnId()))); | |||
| extraColumns.add(new DataColumnImpl(groupFunction.getSourceId(), | |||
| def.getColumnById(groupFunction.getColumnId()).getColumnType())); | |||
| getGroupFunctionColumnType(def.getColumnById(groupFunction.getColumnId()).getColumnType()))); | |||
| } | |||
There was a problem hiding this comment.
This makes sense to me so +1
cristianonicolai
force-pushed
the
JBPM-7331
branch
from
488bd22
to
968382d
Compare
|
@dgutierr applied changes, thanks for the help. |
|
@cristianonicolai thanks for fixing this so quickly :-) I need to verify this locally, so EDIT: Come to think of it, do you think it would be feasible to implement integration test for this? Perhaps something including kie-server with some process data and doing dataset lookup from that? Not that I'll block merging this PR, but would be interested in catching this kind of failures earlier than with UI tests.. (cc @mswiderski) |
|
For some reason there's FDB didn't start. Trying to build this locally and just in case .. |
jhrcek
suggested changes
Jun 1, 2018
There was a problem hiding this comment.
So tested this locally and the two charts that were broken are now displaying data. But there are still couple issues:
- whenever I go to Task Reports / Process Reports, the following exception appears in server.log
exception
12:51:31,486 ERROR [org.dashbuilder.exception.ExceptionManager] (default task-31) Can't lookup on specified data set: processesMonitoring: org.dashbuilder.dataset.exception.DataSetLookupException: Can't lookup on specified data set: processesMonitoring at org.dashbuilder.dataset.DataSetManagerImpl.lookupDataSet(DataSetManagerImpl.java:156) at org.dashbuilder.dataset.DataSetManagerCDI$Proxy$_$$_WeldClientProxy.lookupDataSet(Unknown Source) at org.dashbuilder.dataset.service.DataSetLookupServicesImpl.lookupDataSet(DataSetLookupServicesImpl.java:78) at org.dashbuilder.dataset.service.DataSetLookupServicesImpl$Proxy$_$$_WeldClientProxy.lookupDataSet(Unknown Source) at sun.reflect.GeneratedMethodAccessor123.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jboss.errai.bus.server.io.AbstractRPCMethodCallback.invokeMethodFromMessage(AbstractRPCMethodCallback.java:65) at org.jboss.errai.bus.server.io.ValueReplyRPCEndpointCallback.callback(ValueReplyRPCEndpointCallback.java:40) at org.jboss.errai.bus.server.io.RemoteServiceCallback.callback(RemoteServiceCallback.java:54) at org.jboss.errai.cdi.server.CDIExtensionPoints$2.callback(CDIExtensionPoints.java:448) at org.jboss.errai.bus.server.DeliveryPlan.deliver(DeliveryPlan.java:47) at org.jboss.errai.bus.server.ServerMessageBusImpl.sendGlobal(ServerMessageBusImpl.java:297) at org.jboss.errai.bus.server.SimpleDispatcher.dispatchGlobal(SimpleDispatcher.java:46) at org.jboss.errai.bus.server.service.ErraiServiceImpl.store(ErraiServiceImpl.java:96) at org.jboss.errai.bus.server.service.ErraiServiceImpl.store(ErraiServiceImpl.java:113) at org.jboss.errai.bus.server.servlet.DefaultBlockingServlet.doPost(DefaultBlockingServlet.java:144) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) at io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74) at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:129) at io.undertow.websockets.jsr.JsrWebSocketFilter.doFilter(JsrWebSocketFilter.java:130) at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61) at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131) at org.uberfire.ext.security.server.SecureHeadersFilter.doFilter(SecureHeadersFilter.java:110) at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61) at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131) at org.uberfire.ext.security.server.SecurityIntegrationFilter.doFilter(SecurityIntegrationFilter.java:70) at io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61) at io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:131) at io.undertow.servlet.handlers.FilterHandler.handleRequest(FilterHandler.java:84) at io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62) at io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:64) at io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36) at org.wildfly.extension.undertow.security.SecurityContextAssociationHandler.handleRequest(SecurityContextAssociationHandler.java:78) at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at io.undertow.servlet.handlers.security.SSLInformationAssociationHandler.handleRequest(SSLInformationAssociationHandler.java:131) at io.undertow.servlet.handlers.security.ServletAuthenticationCallHandler.handleRequest(ServletAuthenticationCallHandler.java:57) at io.undertow.server.handlers.DisableCacheHandler.handleRequest(DisableCacheHandler.java:33) at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at io.undertow.security.handlers.AuthenticationConstraintHandler.handleRequest(AuthenticationConstraintHandler.java:53) at io.undertow.security.handlers.AbstractConfidentialityHandler.handleRequest(AbstractConfidentialityHandler.java:46) at io.undertow.servlet.handlers.security.ServletConfidentialityConstraintHandler.handleRequest(ServletConfidentialityConstraintHandler.java:64) at io.undertow.servlet.handlers.security.ServletSecurityConstraintHandler.handleRequest(ServletSecurityConstraintHandler.java:59) at io.undertow.security.handlers.AuthenticationMechanismsHandler.handleRequest(AuthenticationMechanismsHandler.java:60) at io.undertow.servlet.handlers.security.CachedAuthenticatedSessionHandler.handleRequest(CachedAuthenticatedSessionHandler.java:77) at io.undertow.security.handlers.NotificationReceiverHandler.handleRequest(NotificationReceiverHandler.java:50) at io.undertow.security.handlers.AbstractSecurityContextAssociationHandler.handleRequest(AbstractSecurityContextAssociationHandler.java:43) at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at org.wildfly.extension.undertow.security.jacc.JACCContextIdHandler.handleRequest(JACCContextIdHandler.java:61) at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at org.wildfly.extension.undertow.deployment.GlobalRequestControllerHandler.handleRequest(GlobalRequestControllerHandler.java:68) at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43) at io.undertow.servlet.handlers.ServletInitialHandler.handleFirstRequest(ServletInitialHandler.java:292) at io.undertow.servlet.handlers.ServletInitialHandler.access$100(ServletInitialHandler.java:81) at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:138) at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:135) at io.undertow.servlet.core.ServletRequestContextThreadSetupAction$1.call(ServletRequestContextThreadSetupAction.java:48) at io.undertow.servlet.core.ContextClassLoaderSetupAction$1.call(ContextClassLoaderSetupAction.java:43) at org.wildfly.extension.undertow.security.SecurityContextThreadSetupAction.lambda$create$0(SecurityContextThreadSetupAction.java:105) at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1508) at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1508) at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1508) at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1508) at io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:272) at io.undertow.servlet.handlers.ServletInitialHandler.access$000(ServletInitialHandler.java:81) at io.undertow.servlet.handlers.ServletInitialHandler$1.handleRequest(ServletInitialHandler.java:104) at io.undertow.server.Connectors.executeRootHandler(Connectors.java:330) at io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:812) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.NullPointerException at org.jbpm.workbench.ks.integration.KieServerDataSetProvider.getGroupFunctionColumnType(KieServerDataSetProvider.java:413) at org.jbpm.workbench.ks.integration.KieServerDataSetProvider.handleDataSetGroup(KieServerDataSetProvider.java:401) at org.jbpm.workbench.ks.integration.KieServerDataSetProvider.lookupDataSet(KieServerDataSetProvider.java:155) at org.jbpm.workbench.ks.integration.KieServerDataSetProvider$Proxy$_$$_WeldClientProxy.lookupDataSet(Unknown Source) at org.dashbuilder.dataset.DataSetManagerImpl.lookupDataSet(DataSetManagerImpl.java:154) ... 71 more
-
"View table" link on the right in both perspectives shows this:
-
Clicking metrics displayers at the top ("Active processes" etc.) shows this:
cristianonicolai
force-pushed
the
JBPM-7331
branch
from
968382d
to
bacd82b
Compare
|
@jhrcek thanks I fixed the latest errors. |
|
Jenkins execute full downstream build |
jhrcek
approved these changes
Jun 5, 2018
There was a problem hiding this comment.
@cristianonicolai so I executed the Dashboard UI tests locally with this and they passing 100% again. Thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.