JBPM-6892 - Remove spacing between table results and controls

[cristianonicolai]

Depends on kiegroup/appformer#202

[bsremac]

@cristianonicolai I'm getting the following compilation error when trying to build jbpm-wb:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project jbpm-wb-integration-api: Compilation failure
[ERROR] /home/bsremac/Devel/github.com/bsremac/jbpm-wb/jbpm-wb-integration/jbpm-wb-integration-api/src/main/java/org/jbpm/workbench/wi/dd/type/DDResourceTypeDefinition.java:[25,8] org.jbpm.workbench.wi.dd.type.DDResourceTypeDefinition is not abstract and does not override abstract method getCategory() in org.uberfire.workbench.type.ResourceTypeDefinition

I have the dependent appformer commit in place, so not sure where is this error coming from.

[cristianonicolai]

@bsremac give it another go, I rebased this PR

[bsremac]

Spacing looks fine, but there seems to be some problems with that horizontal slider. It "eats up" the space of the last row and it doesn't always appear. Have a look at screenshots below.
Trims the last (and here the only) row:

The last rows trimmed, but the slider is not showing up:

[cristianonicolai]

@bsremac thanks, I had to increase the spacing to fix the horizontal slider issue. Strangely enough, this seems to only happen on Firefox.

See kiegroup/appformer#205

[bsremac]

@cristianonicolai I don't see the horizontal slider now at all, when I navigate to perspectives which don't have an empty list:

However, if there's more than one page, the slider appears on the next page:

Again, I see this inconsistency only in Firefox.

As an aside, what is the expected behavior with these sliders anyway. When is it expected for them to appear?
Even when I enable all the columns, in Process Instances perspective for example (the first attached screenshot), the column widths are just adjusted accordingly and the slider is not shown. This behavior is the same in Firefox and Chrome.

[cristianonicolai]

@bsremac ok, let me take another look, these sliders should not show up at any time, at least I can't find a reason for that, apart from the overall height in the table that somehow affects it.

[bsremac]

@cristianonicolai After the latest changes in appformer PR, the horizontal slider deosn't appear anymore in Firefox - that's fine.
The only thing which sort of stands out a bit is that controls drag a bit after changing the number of items per page to the lower number. Have a look at the short recording below. It's the same behavior in Firefox and Chrome.

Screencast from 27-02-18 16:20:28.zip

[cristianonicolai]

@bsremac yeah, that happens because the table height is recalculated. I tried getting away from that but it simply doesn't work for the GWT table implementation, it needs to know/calculate the table height. Ideally, the selector and paging should just be there after the table uses its space.

[bsremac]

@cristianonicolai I get it. Well, I guess we will have to live with certain limitations :)
Thanks for sharing the workings. Now I know that I will need to increase the timeout when locating control elements in Selenium tests for this type of use case.