[6.5.x] AF-1079 : Empty 'Validation errors' popup in Decision/Business Central #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 9, 2018
Rikkola
changed the title
jomarko
reviewed
Mar 12, 2018
There was a problem hiding this comment.
@Rikkola same comment as in drools-wb. PR looks good, however I would like to reduce codebase by:
AF-1079: Use default asset validated callback
jomarko
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/AF-1079
These PRs change the service visibilities to protected for testing purposes. Not how I would like to do them, but the other option is to do even more refactoring and since this is an older branch, I don't think it is worth the risk.
AppFormer/uberfire-extensions#324
dashbuilder/dashbuilder#419
kiegroup/kie-wb-common#1489
kiegroup/drools-wb#825
#992