Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-9900] RequestInfo.owner is null even if org.kie.executor.id is defined #2026

Merged
merged 1 commit into from
Oct 18, 2021
Merged

[JBPM-9900] RequestInfo.owner is null even if org.kie.executor.id is defined #2026

merged 1 commit into from
Oct 18, 2021

Conversation

elguardian
Copy link
Member

@elguardian elguardian commented Sep 17, 2021 •
edited
Loading

@elguardian
Copy link
Member Author

kiegroup/droolsjbpm-knowledge#550

@elguardian elguardian force-pushed the JBPM-9900 branch 3 times, most recently from 1f1b1d3 to 2057d8e Compare September 21, 2021 12:34
@elguardian
Copy link
Member Author

Jenkins retest this please

gmunozfe
gmunozfe approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, way to go @elguardian !
Some minor comments and a couple of suggestions for additional tests (regressions)

jbpm-services/jbpm-executor/src/test/java/org/jbpm/executor/ExtendedExecutorTest.java Outdated Show resolved Hide resolved
jbpm-services/jbpm-executor/src/test/java/org/jbpm/executor/ExtendedExecutorTest.java Outdated Show resolved Hide resolved
jbpm-services/jbpm-executor/src/test/java/org/jbpm/executor/ExtendedExecutorTest.java Outdated Show resolved Hide resolved
jbpm-services/jbpm-executor/src/test/java/org/jbpm/executor/ExtendedExecutorTest.java Outdated Show resolved Hide resolved
jbpm-services/jbpm-executor/src/test/java/org/jbpm/executor/ExtendedExecutorTest.java Show resolved Hide resolved
@gmunozfe
Copy link
Member

jenkins retest this

1 similar comment
@gmunozfe
Copy link
Member

jenkins retest this

@elguardian
Copy link
Member Author

Jenkins retest this please

1 similar comment
@elguardian
Copy link
Member Author

Jenkins retest this please

@elguardian
Copy link
Member Author

@gmunozfe I had to change one thing to make the test work in this environment.

@elguardian
Copy link
Member Author

Jenkins retest this please

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

gmunozfe
gmunozfe approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, well done @elguardian

@elguardian elguardian merged commit 9acb37a into kiegroup:main Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmunozfe gmunozfe gmunozfe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elguardian @gmunozfe