JBPM-5370 - Administration service for processes and tasks - services… #642
Conversation
… api and kie server
|
jenkins retest this |
1 similar comment
|
jenkins retest this |
|
anyone? |
|
@krisv any comments or good to be merged? starting to get stale a bit here... |
| @@ -393,7 +393,7 @@ public void triggerNode(long nodeId) { | |||
| org.jbpm.workflow.instance.NodeInstance nodeInstance = (org.jbpm.workflow.instance.NodeInstance) | |||
| ((org.jbpm.workflow.instance.NodeInstanceContainer) getNodeInstanceContainer()) | |||
| .getNodeInstance(getNode().getNodeContainer().getNode(nodeId)); | |||
| triggerNodeInstance(nodeInstance, null); | |||
| triggerNodeInstance(nodeInstance, org.jbpm.workflow.core.Node.CONNECTION_DEFAULT_TYPE); | |||
There was a problem hiding this comment.
@mswiderski what is the reason for changing this? I would expect the argument to indicate why the node was triggered, in this case the node is triggered explicitly by the user, not through an incoming connection, so wouldn't null be more adequate (to distinguish from incoming connection)?
There was a problem hiding this comment.
@krisv the reason is that some of the NodeInstances (e.g. SubProcessNodeInstance or TimerNodeInstance) throw exception if the connection is different than the default. So instead of fixing all the node instance to check if it's null I thought it's better to simply provide the default connection when retriggering.
… api and kie server (kiegroup#642)
… api and kie server
depends on kiegroup/droolsjbpm-knowledge#177