-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBPM-5370 - Administration service for processes and tasks - services… #642
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
58 changes: 58 additions & 0 deletions
58
jbpm-flow/src/main/java/org/jbpm/process/instance/command/RelativeUpdateTimerCommand.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /* | ||
| * Copyright 2016 Red Hat, Inc. and/or its affiliates. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.jbpm.process.instance.command; | ||
|
|
||
| import javax.xml.bind.annotation.XmlAccessType; | ||
| import javax.xml.bind.annotation.XmlAccessorType; | ||
| import javax.xml.bind.annotation.XmlRootElement; | ||
|
|
||
| import org.jbpm.process.instance.timer.TimerInstance; | ||
|
|
||
| @XmlRootElement(name = "relative-update-timer-command") | ||
| @XmlAccessorType(XmlAccessType.NONE) | ||
| public class RelativeUpdateTimerCommand extends UpdateTimerCommand { | ||
|
|
||
| private static final long serialVersionUID = -8252686458877022330L; | ||
|
|
||
| public RelativeUpdateTimerCommand(long processInstanceId, String timerName, long delay) { | ||
| this(processInstanceId, timerName, delay, 0, 0); | ||
| } | ||
|
|
||
| public RelativeUpdateTimerCommand(long processInstanceId, String timerName, long period, int repeatLimit) { | ||
| this(processInstanceId, timerName, 0, period, repeatLimit); | ||
| } | ||
|
|
||
| public RelativeUpdateTimerCommand(long processInstanceId, String timerName, long delay, long period, int repeatLimit) { | ||
| super(processInstanceId, timerName, delay, period, repeatLimit); | ||
| } | ||
|
|
||
| public RelativeUpdateTimerCommand(long processInstanceId, long timerId, long period, int repeatLimit) { | ||
| super(processInstanceId, timerId, period, repeatLimit); | ||
| } | ||
|
|
||
| public RelativeUpdateTimerCommand(long processInstanceId, long timerId, long delay, long period, int repeatLimit) { | ||
| super(processInstanceId, timerId, delay, period, repeatLimit); | ||
| } | ||
|
|
||
| public RelativeUpdateTimerCommand(long processInstanceId, long timerId, long delay) { | ||
| super(processInstanceId, timerId, delay); | ||
| } | ||
|
|
||
| protected long calculateDelay(long delay, TimerInstance timer) { | ||
| return delay * 1000; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mswiderski what is the reason for changing this? I would expect the argument to indicate why the node was triggered, in this case the node is triggered explicitly by the user, not through an incoming connection, so wouldn't null be more adequate (to distinguish from incoming connection)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krisv the reason is that some of the NodeInstances (e.g. SubProcessNodeInstance or TimerNodeInstance) throw exception if the connection is different than the default. So instead of fixing all the node instance to check if it's null I thought it's better to simply provide the default connection when retriggering.