DROOLS-2628: [DMN Designer] DataInput toolbox actions #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romartin I kept |
jomarko
approved these changes
Jun 27, 2018
jomarko
pushed a commit
to jomarko/kie-wb-common
that referenced
this pull request
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.jboss.org/browse/DROOLS-2628
@romartin The issue was that the
anyMatch(..)inisSourceConnectionAllowed(..)results in ALL permitted connections matching and hence the target role for all source node types are collected. I've modified the code to get permitted connections whosestartRolematches the source node's role(s) and then collect theendRole. This fixes DMN and fixes all Unit Tests that broke as a result of adding the extra permitted connection inDomainLookupFunctionsTest.