JBPM 8836 : Improve Performance of Copy/Cut and Paste Operations #2983

inodeman · 2019-10-29T02:44:03Z

JBPM 8836 : Improve Performance of Copy/Cut and Paste Operations
JBPM-8835 : Improve performance of response when user performs a click
JBPM-8806 : Stunner - Cursor movement is not smooth
JBPM-8872 : Improve Realtime Drawing When Dragging / Moving Shapes
JBPM-8891: Improve Diagram Loading Times
JBPM-8892: Performance Degradation for Large Models
JBPM-8873 : Adding Nodes to the Canvas is Slow
JBPM-8870 : Stunner - Toolboxes seem to be destroyed and redrawn each time you select the same node
JBPM-8874 : Stunner - Prevent unnecessary instances of Copy, Delete Commands to e created by CDI.
JBPM-8877 : Improve performance of Moving Shapes with Keys
JBPM-8879 : Stunner - Performing Containment takes too long
JBPM-8881 : Stunner - Catching intermediate events are displayed slower compared to other nodes
JBPM-8181 : Stunner - Events docking is very slow when Diagram properties is opened
JBPM-8817 : Prevent Unnecesary Listeners to get added everytime a user performs a click.

inodeman · 2019-10-29T02:45:34Z

Hi @romartin @hasys this is the Performance PR, please take a look and give feedback, I will work on a spreadsheet that contains the previous times and current times.

inodeman · 2019-10-29T02:46:02Z

Jenkins execute full downstream build

hasys · 2019-10-29T08:20:13Z

Hi @inodeman, sonar cloud gate is failed, and some issues looks quite relevant to me. For example missing asserts in tests and possible race condition. It is worth for investigations. Thank you!

inodeman · 2019-10-29T19:33:44Z

Jenkins execute full downstream build

inodeman · 2019-10-29T19:36:20Z

Jenkins retest please

inodeman · 2019-10-29T23:55:42Z

Jenkins execute full downstream build

inodeman · 2019-10-29T23:56:05Z

Jenkins retest please

inodeman · 2019-10-30T02:26:38Z

Jenkins retest please

inodeman · 2019-10-30T02:26:59Z

Jenkins execute full downstream build

inodeman · 2019-10-30T03:08:29Z

Jenkins retest please

inodeman · 2019-10-30T03:08:38Z

Jenkins execute full downstream build

inodeman · 2019-10-30T03:13:44Z

Jenkins retest please

hasys · 2019-10-30T07:04:28Z

Hi @inodeman,

now Sonar is happy, but some tests failing on Jenkins:

org.kie.workbench.common.stunner.core.client.session.command.impl.CopySelectionSessionCommandTest.testExecute org.kie.workbench.common.stunner.core.client.session.command.impl.DeleteSelectionSessionCommandTest.testClearSessionInvoked org.kie.workbench.common.stunner.core.client.session.command.impl.DeleteSelectionSessionCommandTest.testHandleCanvasSelectionEventWhenElementsAreSelected org.kie.workbench.common.stunner.core.client.session.command.impl.DeleteSelectionSessionCommandTest.testHandleCanvasClearSelectionEvent org.kie.workbench.common.stunner.core.client.session.command.impl.DeleteSelectionSessionCommandTest.testHandleCanvasElementsClearEvent org.kie.workbench.common.stunner.core.client.session.command.impl.DeleteSelectionSessionCommandTest.testHandleCanvasSelectionEventWhenCanvasRootIsSelected org.kie.workbench.common.stunner.core.client.session.command.impl.DeleteSelectionSessionCommandTest.checkRespondsToExpectedKeys org.kie.workbench.common.stunner.core.client.session.command.impl.DeleteSelectionSessionCommandTest.checkDoesNotRespondToExpectedKeysWhenDisabled org.kie.workbench.common.stunner.core.client.session.command.impl.DeleteSelectionSessionCommandTest.checkBindAttachesKeyHandler org.kie.workbench.common.stunner.core.client.session.command.impl.DeleteSelectionSessionCommandTest.checkDoesNotRespondToOtherKey

inodeman · 2019-10-30T16:40:37Z

Jenkins execute full downstream build

inodeman · 2019-10-30T16:40:50Z

Jenkins retest please

inodeman · 2019-10-30T17:42:47Z

Jenkins execute full downstream build

inodeman · 2019-10-30T17:42:53Z

Jenkins retest please

inodeman · 2019-10-30T18:54:09Z

Jenkins execute full downstream build

inodeman · 2019-10-30T18:54:17Z

Jenkins retest please

inodeman · 2019-10-31T03:40:26Z

Jenkins execute full downstream build

inodeman · 2019-10-31T03:40:34Z

Jenkins retest please

inodeman · 2019-10-31T06:15:40Z

Jenkins execute full downstream build

inodeman · 2019-10-31T06:15:47Z

Jenkins retest please

inodeman · 2019-10-31T17:09:30Z

Jenkins execute full downstream build

inodeman · 2019-10-31T17:09:36Z

Jenkins retest please

hasys · 2019-11-01T10:25:12Z

Hi @inodeman,

master branch and jenkins builds are broken due to #2989
Let's try again when mentioned PR will be merged. Thank you!

hasys · 2019-11-05T14:27:30Z

Jenkins retest please

inodeman · 2019-11-16T00:57:31Z

Jenkins execute full downstream build

hasys · 2019-11-18T13:28:32Z

Hi @inodeman,

so far looks good, but I found one regression. When I am adding several nodes from the pallet starting with the second node you need to perform several clicks on the canvas to add the node.

Steps To Reproduce

Create new process
Using palette add one any node
Using palette try to add one more node:
- Click on palette category to open it
- Click on any node in that category
- Move mouse somewhere on canvas
- Click left mouse button one more time

Actual Result

Node won't be added, you need to click on canvas 1-2 more times to add the node.

Expected Result

One click should be enough to add the node to the canvas.

inodeman · 2019-11-19T17:02:17Z

Jenkins execute full downstream build

inodeman · 2019-11-19T17:02:30Z

Jenkins retest please

inodeman · 2019-11-20T04:55:06Z

Jenkins execute full downstream build

inodeman · 2019-11-20T04:55:18Z

Jenkins retest please

inodeman · 2019-11-20T04:56:11Z

@hasys ?@romartin can you re-check this PR, Roger, I had to revert back the use of Timer instead of Deferred Command as it was causing draw delays on Macs

jomarko

Just out of interest I briefly checked the code and commented one line.

jomarko · 2019-11-20T07:52:37Z

...src/test/java/org/kie/workbench/common/stunner/core/client/canvas/BaseCanvasHandlerTest.java

+        final List<Element> updatedElements = new ArrayList<>();
+        updatedElements.add(mock(Element.class));


As this is single element list we could use:

final List<Element> updatedElements = Collections.singletoneList(mock(Element.class));

hasys · 2019-11-20T17:29:32Z

Hi @inodeman,

sorry, but I found a blocker. When I am open two processes at the same time, first process starts to be unusable, if you select and move any node you will see this:

I can't reproduce this issue on Master branch, so it should be caused by this PR. Please update this PR and PR for 7.30 branch as well, thank you!

Steps To Reproduce

*Create Process A

Create Process B
Open both processes at the same time (use breadcrumbs to switch from process back to library without closing the process)
move nodes in process B, switch to process A (using process name as on picture below) and move any node again

Actual Result

Error will be shown on any move of any node in the process you opened as first.

Expected Result

You should be able to open any amount of processes at the same time as you wish.

…ragging, Creating, Sequence Flow Create and More

…odes, etc

inodeman · 2019-11-20T20:01:31Z

Jenkins execute full downstream build

inodeman · 2019-11-20T20:01:46Z

Jenkins retest please

inodeman · 2019-11-20T20:04:15Z

Hi @jomarko changed that line in latest commit. @hasys fixed, seems like with the commit to show the properties on startup somehow the forms renderer was sometimes set to null which conflicted with some code. @romartin ready for review

thats why the issue is only visible with both commits but not separate

inodeman · 2019-11-21T17:42:22Z

hi @jomarko checking on your review, @romartin needs your review approval to merge it, let me know

jomarko

Checked Copying DMN nodes, GDT cells, seems working.

romartin requested review from romartin and hasys October 29, 2019 12:44

inodeman force-pushed the JBPM-8836X branch from 793bd9c to 6be5e6f Compare October 29, 2019 19:33

inodeman force-pushed the JBPM-8836X branch from b55bcde to 19d65dc Compare November 16, 2019 00:57

inodeman force-pushed the JBPM-8836X branch from a5e41be to 65d6d94 Compare November 20, 2019 04:54

jomarko reviewed Nov 20, 2019

View reviewed changes

inodeman mentioned this pull request Nov 20, 2019

[7.30.x] JBPM-8835 : Improve performance of Copy / Paste, Click Performance, Dragging, Creating, Sequence Flow Create and More #3028

Merged

inodeman added 9 commits November 20, 2019 11:53

JBPM-8835 : Improve performance of Copy / Paste, Click Performance, D…

eb94b9f

…ragging, Creating, Sequence Flow Create and More

JBPM-8835 : Improve Performance of Copy / Paste, Dragging, Creating N…

0f30074

…odes, etc

JBPM-8835 : Improve Performance of Copy / Paste, Dragging, Creating N…

0306f66

…odes, etc

JBPM-8835 : Improve Performance of Copy / Paste, Dragging, Creating N…

923057d

…odes, etc

JBPM-8835 : Improve Performance of Copy / Paste, Dragging, Creating N…

21a5cc7

…odes, etc

JBPM-8835 : Improve Performance of Copy / Paste, Dragging, Creating N…

7a73ca3

…odes, etc

JBPM-8835 : Improve Performance of Copy / Paste, Dragging, Creating N…

fa0229a

…odes, etc

JBPM-8835 : Improve Performance of Copy / Paste, Dragging, Creating N…

9d3d77b

…odes, etc

JBPM-8835 : Improve Performance of Copy / Paste, Dragging, Creating N…

c1fecd8

…odes, etc

inodeman force-pushed the JBPM-8836X branch from 65d6d94 to c1fecd8 Compare November 20, 2019 20:01

hasys approved these changes Nov 21, 2019

View reviewed changes

jomarko approved these changes Nov 25, 2019

View reviewed changes

romartin approved these changes Nov 26, 2019

View reviewed changes

romartin merged commit f15bf48 into kiegroup:master Nov 26, 2019

		final List<Element> updatedElements = new ArrayList<>();
		updatedElements.add(mock(Element.class));

JBPM 8836 : Improve Performance of Copy/Cut and Paste Operations #2983

JBPM 8836 : Improve Performance of Copy/Cut and Paste Operations #2983

Conversation

inodeman commented Oct 29, 2019 • edited

inodeman commented Oct 29, 2019

inodeman commented Oct 29, 2019

hasys commented Oct 29, 2019

inodeman commented Oct 29, 2019

inodeman commented Oct 29, 2019

inodeman commented Oct 29, 2019

inodeman commented Oct 29, 2019

inodeman commented Oct 30, 2019

inodeman commented Oct 30, 2019

inodeman commented Oct 30, 2019

inodeman commented Oct 30, 2019

inodeman commented Oct 30, 2019

hasys commented Oct 30, 2019

inodeman commented Oct 30, 2019

inodeman commented Oct 30, 2019

inodeman commented Oct 30, 2019

inodeman commented Oct 30, 2019

inodeman commented Oct 30, 2019

inodeman commented Oct 30, 2019

inodeman commented Oct 31, 2019

inodeman commented Oct 31, 2019

inodeman commented Oct 31, 2019

inodeman commented Oct 31, 2019

inodeman commented Oct 31, 2019

inodeman commented Oct 31, 2019

hasys commented Nov 1, 2019

hasys commented Nov 5, 2019

inodeman commented Nov 16, 2019

hasys commented Nov 18, 2019

Steps To Reproduce

Actual Result

Expected Result

inodeman commented Nov 19, 2019

inodeman commented Nov 19, 2019

inodeman commented Nov 20, 2019

inodeman commented Nov 20, 2019

inodeman commented Nov 20, 2019

jomarko left a comment

Choose a reason for hiding this comment

jomarko Nov 20, 2019

Choose a reason for hiding this comment

hasys commented Nov 20, 2019 • edited

Steps To Reproduce

Actual Result

Expected Result

inodeman commented Nov 20, 2019

inodeman commented Nov 20, 2019

inodeman commented Nov 20, 2019 • edited

inodeman commented Nov 21, 2019

jomarko left a comment

Choose a reason for hiding this comment

inodeman commented Oct 29, 2019 •

edited

hasys commented Nov 20, 2019 •

edited

inodeman commented Nov 20, 2019 •

edited