Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maven-enforcer-plugin issues #2989

Merged
merged 1 commit into from Nov 1, 2019
Merged

Fix maven-enforcer-plugin issues #2989

merged 1 commit into from Nov 1, 2019

Conversation

manstis
Copy link
Member

@manstis manstis commented Oct 31, 2019 •
edited

This fixes the maven-enforcer-plugin issues causing all kie-wb-common PRs to fail (if not more!)

It also address the declared/unused dependencies reported by @jomarko.

@manstis manstis force-pushed the fix-maven-enforcer-plugin-issues branch from 48f3ddd to e17d213 Compare October 31, 2019 14:29
karreiro
karreiro approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @manstis :-)

@manstis
Copy link
Member Author

manstis commented Oct 31, 2019

Thank-you @karreiro @danielzhe.

@jomarko This PR will allow all other pending PRs relying on kie-wb-common to become green!

jomarko
jomarko approved these changes Nov 1, 2019
View reviewed changes
Copy link

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue spotted during review, however probably not related.

@mareknovotny
Copy link
Member

mareknovotny commented Nov 1, 2019 •
edited

Jenkins execute full downstream build

@hasys hasys mentioned this pull request Nov 1, 2019
Merged
@manstis manstis merged commit b394382 into kiegroup:master Nov 1, 2019
@manstis
Copy link
Member Author

manstis commented Nov 1, 2019

Test failures unrelated...

Test Result (2 failures / +2)
org.kie.wb.selenium.ui.StandalonePerspectivesIntegrationTest.testLibraryPerspectiveWithHeader  
org.kie.wb.selenium.ui.StandalonePerspectivesIntegrationTest.org.kie.wb.selenium.ui.StandalonePerspectivesIntegrationTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karreiro karreiro karreiro approved these changes

@danielzhe danielzhe danielzhe approved these changes

@jomarko jomarko jomarko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@manstis @mareknovotny @karreiro @danielzhe @jomarko