KOGITO-1661 : BPMN Examples have 'null' in process type property #3258
Conversation
|
Jenkins execute full downstream build |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hey @tomasdavidorg Could you please quickly review this fix for https://issues.redhat.com/browse/KOGITO-1661 (you reported it)? this way we can include into next release asap. Thanks! |
| @@ -242,7 +242,7 @@ | |||
| * @ordered | |||
| */ | |||
| @GwtTransient | |||
| protected ProcessType processType = PROCESS_TYPE_EDEFAULT; | |||
There was a problem hiding this comment.
@inodeman so the fix is just about initializing the processType with the default public value, right? Sounds ok for me, but could then we also remove the field PROCESS_TYPE_EDEFAULT, is being used somewhere else?
There was a problem hiding this comment.
It is used on another places, shouldn't be the PROCESS_TYPE_EDEFAULT set to ProcessType.PUBLIC?
There was a problem hiding this comment.
good point @tomasdavidorg - @inodeman ?? ^^
There was a problem hiding this comment.
Hi @romartin @tomasdavidorg I tried setting the default to public, but the side effect is that if a process is set to public, then it is not saved. Then to make it work I have to change several files. Let me know
There was a problem hiding this comment.
@inodeman TBH I think it results confusing having the PROCESS_TYPE_EDEFAULT field, but not using it for the initialization of processType, although is actually working this way. Ping me and we can do a quick look at this together, np! 👍
|
Jenkins execute full downstream build |
|
Jenkins retest please |
|
Hi @romartin @LuboTerifaj can you review this PR? |
|
SonarCloud Quality Gate failed.
|
|
Jenkins execute full downstream build |
|
@tomasdavidorg @romartin any updates? |
|
Jenkins execute full downstream build |
|
please @inodeman , keep an eye on the builds and once ready, let reviews know so we can complete the review. Thanks! |
Hi @romartin can you review this PR?