Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBPM-6108 ObjectSelector should not appear in Form-modeler editor #969

Closed
wants to merge 11 commits into from
Closed

JBPM-6108 ObjectSelector should not appear in Form-modeler editor #969

wants to merge 11 commits into from

Conversation

alessioscalici
Copy link
Contributor

@alessioscalici alessioscalici commented Jul 11, 2017

WARNING: to be merged with kiegroup/appformer#93
and with #1024

Removed ObjectSelector related code from the project

@pefernan @jsoltes can you give look?

@hasys
Copy link
Member

hasys commented Jul 12, 2017

Jenkins execute full downstream build

@jsoltes
Copy link
Collaborator

jsoltes commented Jul 14, 2017

jenkins execute full downstream build

@jsoltes
Copy link
Collaborator

jsoltes commented Jul 17, 2017

@alessioscalici or @pefernan could you please also fix the full downstream build? Some changes in appformer are possibly breaking some other repo.

@jsoltes
Copy link
Collaborator

jsoltes commented Jul 18, 2017

jenkins execute full downstream build

Copy link
Collaborator

@jsoltes jsoltes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@manstis manstis requested a review from pefernan July 18, 2017 13:02
Copy link
Member

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, easy review ;)

kiereleaseuser and others added 10 commits July 25, 2017 19:52
* fix build issues and simplified/cleaned some code

* fix the version of test content

* to make jhrcek happy :)

* more generics to save code duplication :)
* GVUNOR-3350: [Stunner] Toolbox views do not enable/disable

* Changed to use stream.map(..) as suggested by Roger
* GUVNOR-3308: Error shown when going to Team metrics dashboard

* GUVNOR-3315: "Commits Per Author" always has the same values of columns "#Commits" and "#Assets"

* GUVNOR-3310: Displayers are not cleaned up after leaving Team metrics dashboard
* GUVNOR-3317: Add method for Collection types of current package

* GUVNOR-3317: Codestyle applied
@pefernan
Copy link
Member

pefernan commented Aug 2, 2017

jenkins execute full downstream build

@pefernan
Copy link
Member

pefernan commented Aug 2, 2017

@manstis could you please merge this?

@manstis
Copy link
Member

manstis commented Aug 2, 2017

@pefernan With pleasure when kiegroup/appformer#93 is approved and green.

@pefernan
Copy link
Member

pefernan commented Aug 3, 2017

@alessioscalici could you please close this PR?

@alessioscalici
Copy link
Contributor Author

alessioscalici commented Aug 3, 2017

@pefernan sorry, I thought I already closed it but it's likely the close request did never reach github 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
10 participants