Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOGITO-1567: Export source code as GitHub gist #104

Merged
merged 4 commits into from Apr 8, 2020
Merged

KOGITO-1567: Export source code as GitHub gist #104

merged 4 commits into from Apr 8, 2020

Conversation

caponetto
Copy link
Contributor

Task: KOGITO-1567

Demo
gist-it

@tiagobento tiagobento changed the title [KOGITO-1567] Export source code as GitHub gist KOGITO-1567: Export source code as GitHub gist Apr 1, 2020
tiagobento
tiagobento requested changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@tiagobento tiagobento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @caponetto! Welcome :))

Left some improvement requests inline. Please tell me if you have questions!

packages/online-editor/src/editor/EditorToolbar.tsx Outdated Show resolved Hide resolved
packages/online-editor/src/editor/EditorPage.tsx Outdated Show resolved Hide resolved
packages/online-editor/src/editor/EditorPage.tsx Outdated Show resolved Hide resolved
packages/online-editor/src/editor/EditorPage.tsx Outdated Show resolved Hide resolved
packages/online-editor/src/common/GithubTokenModal.tsx Outdated Show resolved Hide resolved
packages/online-editor/src/common/GithubTokenModal.tsx Outdated Show resolved Hide resolved
packages/online-editor/src/common/GithubTokenModal.tsx Outdated Show resolved Hide resolved
packages/online-editor/src/home/HomePage.tsx Show resolved Hide resolved
packages/online-editor/src/home/HomePage.tsx Outdated Show resolved Hide resolved
packages/online-editor/src/home/HomePage.tsx Outdated Show resolved Hide resolved
@ederign ederign requested review from ederign and jomarko April 2, 2020 14:54
tiagobento
tiagobento requested changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@tiagobento tiagobento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @caponetto, looking much better now! Just some other minor comments inline. We're almost there.

packages/online-editor/src/common/GithubService.ts Outdated Show resolved Hide resolved
packages/online-editor/src/common/GithubService.ts Outdated Show resolved Hide resolved
packages/online-editor/src/common/GithubService.ts Outdated Show resolved Hide resolved
packages/online-editor/src/common/GithubService.ts Outdated Show resolved Hide resolved
packages/online-editor/src/common/GithubService.ts Outdated Show resolved Hide resolved
packages/online-editor/src/common/GithubTokenModal.tsx Outdated Show resolved Hide resolved
packages/online-editor/src/editor/EditorPage.tsx Outdated Show resolved Hide resolved
packages/online-editor/src/home/HomePage.tsx Outdated Show resolved Hide resolved
packages/online-editor/src/home/HomePage.tsx Show resolved Hide resolved
packages/online-editor/src/index.tsx Outdated Show resolved Hide resolved
@ederign
Copy link
Contributor

ederign commented Apr 6, 2020

@jomarko when you have a chance could you please take a look at this?

jomarko
jomarko reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions

  • If user click Gist it! two times in a row, two same files with exactly same name are created. Is that intentional/appropriate?
  • If token on github is deleted, user is correctly prompted for new token, however the Reset button doesn't clear the old one, is that expected?
    Screenshot from 2020-04-07 11-51-59
  • files gisted from firefox are single line source, form chrome it works fine

packages/online-editor/src/common/GithubService.ts Show resolved Hide resolved
@caponetto
Copy link
Contributor Author

caponetto commented Apr 7, 2020 •
edited

Thanks for the review, @jomarko!

Here are the answers for your questions from my point of view:

  1. This operation is like an export, so a new gist will be generated every time you click on the button, even if you do not change anything. In other words, this feature is not meant to update an existing gist but always create a new one regardless of their content.
  2. It seems like a bug. I'll take a look on that.
  3. It seems like an issue with the infrastructure that retrieves the file content. The same happens if you download the file. I'll take a look.

@tiagobento
Copy link
Contributor

@caponetto @jomarko Thanks Jozef for the review! As a suggestion, we could simply disable the "Gist it!" button once it's clicked. WDYT?

CC @srambach is "disabling a button after clicking" a thing? Does it have UX/a11y implications we should be aware of?

@caponetto
Copy link
Contributor Author

@tiagobento IMO disabling the button would bring more confusion than benefits.
The download operation is similar if you think about it.

@caponetto
Copy link
Contributor Author

@jomarko
About your 3rd question: Is your Firefox version < 74? Apparently, the formatter only works on Firefox version >= 74. If you think this is an issue, I suggest opening a new Jira because it affects the other operations as well, such as download and copy.

@jomarko
Copy link
Contributor

jomarko commented Apr 7, 2020

@caponetto my firefox is 70

@caponetto @tiagobento about the point 1 - name of gist file, I think disabling button is not proper option. For me is also fine we will not override existing gist but creating new.

However for me was issue to distinguish which gist is latest vs. oldest, maybe just adding timestamp would help? But not sure if that is ok from UX point of view @srambach ?

@ederign
Copy link
Contributor

ederign commented Apr 7, 2020

My 2 cents on this.

@jomarko if the user created it twice, he is exporting twice, so we expect that this will generate two gist files (with same name but different ids). I would say that adding a timestamp is not ideal because it will change the expected name from gist file due to a corner case and it will make the file name (on the URL) weird.

About the formater issue on firefox < 74, @caponetto could you please create a JIRA?

jomarko
jomarko approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The firefox issue reported as https://issues.redhat.com/browse/KOGITO-1760

Thank you @caponetto

@ederign ederign merged commit eff35c3 into apache:master Apr 8, 2020
tiagobento added a commit that referenced this pull request Jan 11, 2022
@tiagobento @caponetto
@treblereel @danielzhe @Ginxo @karreiro @github-actions @hasys @yesamer @inodeman @Josephblt @romartin @mbiarnes @handreyrc @mareknovotny @kie-tools-bot @ederign @ljmotta @radtriste
KOGITO-5522: Incorporate kogito-editors-java (#729)
4251fbb 
* FDB for PRs: Merge changes from PRs. (#30)

* KOGITO-5085: Replace Blob* classes with elemental2 equivalent (#22)

* switched to elemental2 Blob implementation

* formating

* [8.0.0] KOGITO-3274: [DMN Designer] Read-only mode - Connectors appear differently on read-only mode (#31)

* BXMSPROD-1311 surefire report check to GA (#144)

* BXMSPROD-1311 action-surefire-report

* Check Surefire Report errata fixed

* BXMSPROD-1311 surefire report check to GA (#116)

* BXMSPROD-1311 action-surefire-report

* Check Surefire Report errata fixed

* KOGITO-5082: Restore the notification mechanism (#23)

* Bump version to 8.1.0-SNAPSHOT (#38)

* KOGITO-4872: Show an error page for SceSim in case `setContent` fails (#37)

* KOGITO-4872: Add ErrorPage for SceSim.

* KOGITO-4872: Fix associated test.

* Bump version script and workflow (#39)

* KOGITO-5068: Online DMN Editor won't load after several tabs are opened (#42)

* Bump version to 8.1.1-SNAPSHOT (#43)

Co-authored-by: karreiro <karreiro@users.noreply.github.com>

* Use token as input in the bump_version workflow (#45)

* KOGITO-4977: Stunner - Texts overlap toolboxes (#41)

* KOGITO-5021: Clear selection button doesn't work on Testing Tools when use click property first time (#15)

* KOGITO-5135: [SceSim Designer] HiDPI is not working as expected (#44)

* Kogito-4980 : Stunner - Palette fixes & improvements (#16)

* KOGITO-4935 : [DMN/BPMN editor] Sometimes clicking outside doesn't unselect nodes cherry-pick (#47)

Co-authored-by: Jaime Enriquez <jenrique@redhat.com>

* Add a DMN model into large models test suite (#51)

* Workflow for creating the release branch (#46)

* KOGITO-5011 - Unknown Custom tasks in Designer makes Diagram Explorer empty (#36)

If an item could not be found in the workiItemDefinitionRegistry a null exception was thrown interrupting the load process.

* [BXMSPROD-1349] point to ScaCap/action-surefire-report@v1.0.10 (#145)

* [BXMSPROD-1349] point to ScaCap/action-surefire-report@v1.0.10 (#118)

* Updating Node and Yarn on the FDB workflow (#54)

* Update ci_full_downstream_build.yml

* Fix FDB workflow

* [BXMSPROD-1350] change cache key for flows using different java versions (#119)

https://issues.redhat.com/browse/BXMSPROD-1350

* [BXMSPROD-1350] change cache key for flows using different java versions (#146)

https://issues.redhat.com/browse/BXMSPROD-1350

* KOGITO-4671 : New elements should always be connected by its central magnetic point (#18)

* KOGITO-5003: DMN editor removing edges for duplicate Decision Nodes on canvas (#52)

* KOGITO-5132: BPMN Editor - Improve SVG generated ids (#3634) (#48)

* upgraded to next 7.56.0-SNAPSHOT

* upgraded to next 7.56.0-SNAPSHOT

* Revert "upgraded to next 7.56.0-SNAPSHOT"

This reverts commit 7da188f.

* Revert "upgraded to next 7.56.0-SNAPSHOT"

This reverts commit f475cf3.

* upgrade to next SNAPSHOT version

* upgrade to next SNAPSHOT version

* Lienzo migration to J2CL

* Lienzo migration to J2CL

* Lienzo migration to J2CL

* Lienzo migration to J2CL

* KIE codestyle conventions applied

* KIE codestyle conventions applied

* KIE codestyle conventions applied

* Lienzo Core migration to J2CL & kogito editors.

* Lienzo Tests migration to J2CL & kogito editors.

* Lienzo Webapp migration to J2CL & kogito editors.

* Dependency updates for kogito lienzo artifacts.

* fix SCESIM tests

* Fix lienzo-tests - unit tests not running

* BXMSPROD-1353 nodejs v16.2.0 (#62)

* BXMSPROD-1353 nodejs v16.2.0

* Update appformer-js-monaco/pom.xml

Co-authored-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>

Co-authored-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>

* Lienzo codebsae clean ups

* KOGITO-5142: [DMN/BPMN] Sync kogito-editors-java with latest translations (#50)

* Updated Test Scenario translations (#49)

* Set missing generateJsInteropExports flag for GWT apps

* Lienzo - Fix shape exclusions in layer index

* KOGITO-4043: The nodes should be created on top of the selected node in DMN editor (#58)

* Lienzo webapp - Cleanup & fixes for examples

* Lienzo - Drop unused Metadata type

* Lienzo - Drop unused RestrictedMousePanMediator type

* Lienzo - Code Cleanup

* Bump version to 8.2.1-SNAPSHOT (#67)

* KOGITO-5225/KOGITO-5154: Support React components on Kogito Java-editors (#68)

* Fixed canvas not being automatically resized on readOnly mode

* DMN - Fixed decision service divider not working properly on drag

* Lienzo - Upgrade modules to version 8.2.1-SNAPSHOT

* KOGITO-4899: SceSim - Redraw layer after user action.

* KOGITO-4941: [DMN Editor] Ctrl-B always converts field to structure and nests (#69)

* Lienzo - Drop legacy json serialization & validation stuff.

* Lienzo - Clean up gwt compilation warns for jsinterop types.

* BXMSPROD-1340 kogito-tooling nightly

* KOGITO-5137: Conscious language initiative (#72)

* KOGITO-5489: [DMN Designer] When users create a node by using a shortcut, it's not created above (#74)

* KOGITO-4978 : Make new nodes Editable (#26)

* KOGITO-5470 : BPMN Editor - Cannot import process (#71)

* Lienzo & Stunner migration to native - Code cleanups

* KOGITO-5549 - WID files with comments and Imports can't be loaded (#76)

* KOGITO-1625: [DMN Designer] Data Types changes do not mark asset as dirty (#73)

* KOGITO-5571: No effects when assigning a not-expression Simple Type column to expression type (and viceversa) (#79)

* KOGITO-5119: [DMN Designer] Add support for bend-points on connectors (#78)

* KOGITO-5506 : BPMN Editor - Marshallers encoding issues (#75)

* KOGITO-5506 : BPMN Editor - Marshallers encoding issues

* KOGITO-5506 : BPMN Editor - Marshallers encoding issues

* KOGITO-5091: Stunner - creating connection can't be cancelled easily (#80)

* KOGITO-5557 [DMN Designer]: Boxed Expression - Move the new boxed expression to Kogito stream (#77)

* KOGITO-2313 - Support for node/events metadata attributes (#64)

* KOGITO-4765: Errors when executing models using imported inputs and/or decisions nodes - VS Code (#17)

* KOGITO-5481: JS - Solve performance gap (large boxed expressions takes too long to load - Relation 50x50) demo | branch - CSS / JS/TS/Hooks (#82)

* KOGITO-5119: Add DMN diagram bend points marshalling test (#81)

* KOGITO-4979 - Resize control points - Fixes & UX improvements (#84)

* KOGITO-5481: Add 50x50 Relation cypress test (#88)

* KOGITO-5469 : Can't connect elements vertically far from each other in a BPMN Diagram (#87)

* KOGITO-5274: Stunner - Line splicing (#85)

* KOGITO-5594: [Stunner] bend point modification causes diagram inaccessible (#92)

* KOGITO-3654: Support FEEL code completion and code highlighting on all FEEL based cells (#83)

* KOGITO-5646: [DMN Designer] New boxed expression editor - Create a mechanism to enable the new boxed expression editor as a toggle feature (#89)

* KOGITO-5648: [DMN/BPMN] Wired web apps - Fix doc screenshot (#91)

* KOGITO-5642: Fix sonnar issues: try-with-resources

* KOGITO-5642: Fix sonar issues: deprecated JsonFactory method

* KOGITO-5642: Fix sonar issues: Unused public methods

* KOGITO-5642: Fix sonar issues: disable external entities access

* KOGITO-5642: Fix sonar issues: remove not used class field

* KOGITO-5642: Fix sonar issues: remove unused import

* Remove unclosed opening quotes

* Remove not needed eq matcher

* Create CODEOWNERS

* Add CODEOWNERS

* Bump version to 8.3.1-SNAPSHOT (#96)

Co-authored-by: Kogito Tooling Bot <kietooling@gmail.com>

* KOGITO-5613: Add pre-push hooks to run prettier and eslint in kogito-editors-js (#86)

* KOGITO-5728: [DMN Designer] New Boxed Expression editor - Remove "|" grip from the new boxed expression editor (#98)

* kie-parent version bump for 7.58.0.Final (#93)

* DROOLS-6477: Collections Data Objects can be filled with expressions only. (#97)

* KOGITO-3909: Standalone DMN editor missing isDirty indication on datatype or included models change (#99)

* KOGITO-5149: Create the second step of the Wizard - Create the collapsible/expandable list of future Data Types (#101)

* KOGITO-5676: BPMN Editor - Containment not working when Node overlaps the Connector while splicing (#95)

* KOGITO-5642: Activate sonar check (#94)

* KOGITO-5642: Activate sonar check

* Add jenkinsfile to run analysis on PR

* Stabilize test on run-code-coverage profile

* Create pipeline

* Remove sonarcloud-analysis profile config

* Skip gwt compilation for run-code-coverage profile

* Convention over configuration - default repository

* Decrease from 16G nodes to 8G nodes

* skop sonar for dmn-webapp-[kogito-runtime|kogito-testing]

* KOGITO-5642 Fix CI job ID (#107)

Folders in jenkins workspace are generated according to the job ID. Whitespaces in the ID causes an issues.

* KOGITO-5642: Do not run github action for some paths (#108)

* Fix indentation in on:push sonar github action (#111)

For more details see:
- https://github.com/kiegroup/kogito-editors-java/actions/runs/1234074225

* Fix FDB build (#110)

* Bump version to 8.4.1-SNAPSHOT (#112)

* Fix FDB build

* KOGITO-3661 Integrate boxed-expression-component inside dmn-loader and define jsInterop classes for loading/saving expressions (#104)

KOGITO-3661 Integrate boxed-expression-component inside dmn-loader and define jsInterop classes for loading/saving expressions (#104)

* KOGITO-3656: Support copy/paste integration with other spreadsheets (#103)

KOGITO-3656: [DMN Designer] New boxed expression editor - Support copy/paste integration with other spreadsheets

KOGITO-5649: [DMN Designer] New boxed expression editor - Support single/multiple cells highlight

* KOGITO-5909: [DMN Designer] New Boxed Expression editor - DMN Expression column width is updated too many times in some scenarios (#116)

* Update ci_full_downstream_build.yml

* KOGITO-5901: [DMN/BPMN/SceSim] Check dependabot alerts (#115)

* KOGITO-5933: Enable the new Boxed Expression Editor in all Kogito channels (#118)

* Update codeowners file (#121)

* scesim translations update (#123)

* KOGITO-5894: Fix spotbugs issues (#106)

* Bump version to 8.4.2-SNAPSHOT (#124)

* KOGITO-5847: Fix critical issues reported by sonar (#113)

* DROOLS-4719: Change decision navigator DRG icon (#126)

For more details see:
- https://issues.redhat.com/browse/DROOLS-4719

* KOGITO-6033: Make DMN data types documentation entries readable (#125)

For more details see:
- https://issues.redhat.com/browse/KOGITO-6033

* KOGITO-6021: [DMN Designer] Multiple DRDs - Renaming a DRD freezes the browser (#127)

* KOGITO-6021: Value is updated only if changed

* KOGITO-6021: Value is updated only if changed

* KOGITO-6021: Value is updated only if changed

* KOGITO-6021: Applying Change Requests

* KOGITO-5849: use existing sonarcloud-analysis profile (#130)

* KOGITO-5849: use existing sonarcloud-analysis profile

* Actiavte sonar check for lienzo-webapp

* Peer review feedback: clarify sonarcloud-analysis definition location

* Revert "KOGITO-5909: [DMN Designer] New Boxed Expression editor - DMN Expression column width is updated too many times in some scenarios (#116)" (#132)

This reverts commit ab89715.

The reason of revert is described in comments:
- #631 (comment)
- #631 (comment)

* KOGITO-6021: test DRD rename is propagated (#131)

For more details see:
- https://issues.redhat.com/browse/KOGITO-6021

* Optimizing bundle by removing comments that were causing issue with kogito-tooling standalone editors (#137)

* KOGITO-5150: Create the mechanism for fetching fields from nest types (#122)

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Changes requests

* KOGITO-5150: Snapshots tests fixed

* KOGITO-5150: Wizard cleanup at closure

* KOGITO-5150: Wizard cleanup at closure

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Changes requests

* KOGITO-5150: Snapshots tests fixed

* KOGITO-5150: Wizard cleanup at closure

* KOGITO-5150: Wizard cleanup at closure

* KOGITO-5150: Applying Change Requests

* KOGITO-5150: Applying Change Requests

* KOGITO-5150: Applying Change Requests

* KOGITO-5150: Prettier is now happy

* KOGITO-5150: Prettier is now happy

* KOGITO-5150: Snapshots updated

* KOGITO-5150: Tests

* KOGITO-5150: Tests

* KOGITO-5150: Tests

* KOGITO-5150: Tests

* KOGITO-5150: Prettier

* KOGITO-6037: Render DMN Shapes colors (#140)

For more details see:
- https://issues.redhat.com/browse/KOGITO-6037

* Bump version to 8.4.3-SNAPSHOT (#138)

* Use try-with-resources for JavassistAdapter (#139)

* KOGITO-6083: Render new lines in DMN documentation node description (#136)

* KOGITO-6083: Render new lines in DMN documentation node description

For more details see:
- https://issues.redhat.com/browse/KOGITO-6083

* Trigger build

* Fix batch of lienzo-core issues reported by sonar (#142)

* KOGITO-5973: Stunner - Provide an initial JS/TS API to interact with nodes and connectors (#117)

* DROOLS-3300: merge background and font set (#134)

For more details see:
- https://issues.redhat.com/browse/DROOLS-3330

* KOGITO-5152: Data Types - Wizard - Create the third step of the Wizard (#133)

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Changes requests

* KOGITO-5150: Snapshots tests fixed

* KOGITO-5150: Wizard cleanup at closure

* KOGITO-5150: Wizard cleanup at closure

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Fetching mechanism

* KOGITO-5150: Changes requests

* KOGITO-5150: Snapshots tests fixed

* KOGITO-5150: Wizard cleanup at closure

* KOGITO-5150: Wizard cleanup at closure

* KOGITO-5150: Applying Change Requests

* KOGITO-5150: Applying Change Requests

* KOGITO-5150: Applying Change Requests

* KOGITO-5150: Prettier is now happy

* KOGITO-5150: Prettier is now happy

* KOGITO-5150: Snapshots updated

* KOGITO-5150: Tests

* KOGITO-5150: Tests

* KOGITO-5150: Tests

* KOGITO-5150: Tests

* KOGITO-5150: Prettier

* KOGITO-5152: Third Step

* KOGITO-5152: Third Step

* KOGITO-5152: Third Step

* KOGITO-5152: Tests

* KOGITO-5152: Tests

* KOGITO-5152: Tests

* Fix dev environment BPMN/DMN kogito-runtime, xml-apis dependency (#148)

* DROOLS-3442: Rename DMN 'Name' to 'DMN Model Name' (#135)

For more details see:
- https://issues.redhat.com/browse/DROOLS-3442

* KOGITO-5899: When editing a BKM node, clear button should not be available for the boxed Function (#141)

* LogicTypeSelector receives an external property to decide when showing or not the clear button

* The dmn-loader passes a property to the editor for showing or not the clear button on the root expression

* Based on clear support method, of HasExpression interface, passing a boolean to the dmn-loader

* Reusing the `noClearAction` property of the `ExpressionProps` interface, in order to make clear action not available on root expression

* Adding documentation to render method

* Adding documentation to BoxedExpressionEditor

* Bump version to 8.5.1-SNAPSHOT (#149)

* Removing css conflict file and hiding button for switching to new editor (#150)

* RHDM-1611: Show vertical scrollbar on small screen for data types placeholder (#153)

* KOGITO-6188: [DMN Designer] The keyboard shortcuts modal CSS from the DMN Editor is broken (#155)

* Creating a separate CSS file with rules from `base-no-reset.css` that have been wrapped to avoid potentially dangerous side effects

* Fixing showcase in order to use `base-no-reset-wrapped.css` for the remaining part of the editor

* Re-enabling `boxed-expression-component` inside `DMN Editor`

* Bump version to 8.5.2-SNAPSHOT (#157)

* Enable Included Models on Online Multi-file channel (#156)

* Avoid the activation of Boxed Expression Editor during Diagram -> Editor navigation (#163)

* KOGITO-6132: [DMN Designer] Pressing backspace when editing a node deletes the node (#146)

* KOGITO-6132: [DMN Designer] Pressing backspace when editing a node deletes the node

* Rebuild

* KOGITO-6222: [DMN Designer] Open Imported DMN from current model (#161)

* KOGITO-6222: Open a DMN included file reference in another tab

* KOGITO-6222: Test

* KOGITO-6222: Tests

* KOGITO-6222: Tests

* KOGITO-6222: Tests

* Api refactoring

* Update kie-wb-common-dmn/kie-wb-common-dmn-client/src/main/java/org/kie/workbench/common/dmn/client/editors/included/grid/BaseCardComponent.java

Co-authored-by: Jozef Marko <jomarko@redhat.com>

* KOGITO-6222: Tests

Co-authored-by: Jozef Marko <jomarko@redhat.com>

* KOGITO-6036: Use html <input type='color'> picker (#147)

* KOGITO-6036: Show colors as hex value string in forms

For more details see:
- https://issues.redhat.com/browse/KOGITO-6036

* Fix codesmell: non standard package name

* Use html5 <input type='color'/>

* Cleanup dependencies

* sonar: remove unused field

* KOGITO-5078: DMN Runner Tabular Input (#145)

* Adding modifications

* Working

* Working

* Fix FunctionExpression

* Fix RelationExpression

* Fix RelationExpression resize

* Fixing FunctionExpression resize

* WIP Fix FunctionExpression resize

* Fix resize

* Fix FunctionExpression and RelationExpression

* Update api

* Add dmn-runner-showcase

* Update tests

* Update i18n version

* Update react-table types

* Make it possible to resize the dmn runner table

* Fix dmn-runner-showcase start

* Add source maps

* Fix test

* Minor tweaks

* Fix dmn runner table resize

* Fix FunctionParameters and DmnAutoTable render

* Lint

* Fix Tests

* Fix EditableCell tests

* Fix nested ListExpression

* Move reset LogicType test to BoxedExpressionEditor

* Fix DmnRunnerTabular resize

* Fix incompatible type

* Remove dmn runner showcase

* Clean changes

* Add github action

* Fix workflow

* Fix comment

* Remove unused script

* Fix i18n version

* Fix lint

* Retrigger build

* Fix InvocationExpression

* Update on function name change

* Refactor FunctionExpression

* Remove warnings

* Remove unnecessary states

* Remove unnecessary states

* Remove unnecessary states

* Fix ResizableCell render delay

* Fix tests

* Fix FunctionExpression test

* re-trigger build

* Remove CellSelectionBox from DMN Runner Table

* Remove duplicated import

* Add css to showcase

* Stop using the document.body to search for cells

* Remove unused imports

* Fix github action, update version of all packages

* Fix tests

* Fix EditParameters

* Fix onFocus

* Refactor DecisionTable

* Fix FeelInput

* Check if state has changed before update

* Simplify content update on Java and PMML functions

* Fix tests

* Fix PMML parameters

* Revert changes on feelinput

* Fix css

* Fix FeelInput component

* Fix clean result

* Fix format

* Fix Relation column rename

* Remove unnecessary css

* Remove unused imports

* Re trigger build

* Fix DecisionExpression Cell handler

* Bump version to 8.5.4-SNAPSHOT (#165)

* Bump version to 8.5.3-SNAPSHOT

* Bump version to 8.5.4-SNAPSHOT

* KOGITO-5848: Activate sonar for kogito-editors-js module (#160)

For more details see:
- https://issues.redhat.com/browse/KOGITO-5848

* Remove duplicit gwt-maven-plugin definition (#164)

This a fix for the warning from build:
Some problems were encountered while building the effective model for org.kie.kogito:lienzo-webapp:war:8.5.2-SNAPSHOT
Warning:  'profiles.profile[GWT2].plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.codehaus.mojo:gwt-maven-plugin @ line 239, column 14
Warning:
Warning:  It is highly recommended to fix these problems because they threaten the stability of your build.
Warning:
Warning:  For this reason, future Maven versions might no longer support building such malformed projects.
Warning:

* Use lerna to change packages version (#168)

* RHPAM-3329: Increase Decision Table Output value length limit (#152)

* Measure kogito-editors-js coverage (#167)

* Measure kogito-editors-js coverage

* fix ci

* Fix `locktt` install (#172)

* Create pom.xml

* Update pom.xml

* Update pom.xml

* Upgrade frontend-maven-plugin to enable the 'npx' goal

* Fix locktt on appformer-js-monaco too

* KOGITO-6097: [New DMN Expression Editor] decision table can not be opened (#159)

* Adding exported function for generating UUID

* First column of Relation table should have 100 px of width

* Accessor for added columns is the generated uuid

* Using identifier for accessing the columns

* Identify each table row by its ID

* Identify columns and rows in Relation table, by their ID

* Fixing tests after introduction of ID

* Id for Relation table should not be generated when evaluating rows, otherwise it will be different at every render

* Generating IDs for DecisionTable's columns

* When adding a new row, a generated uuid should be used for it

* When rendering the table, if a row is missing the id, going to generate it

* Giving minimum height to label section, in order to have space when label is empty

* Edit of inline text (annotation labels) should accept empty values

* Changing props Java classes to reflect Id param

* Overriding PF label color (that on DMN Editor is white)

* Filling id of Annotation and Clause DecisionTable's props

* Id for inputClause should not be taken from its wrapped inputExpression

* Fixing test case

* Retrieve ruleId from the model

* Fixing cypress test case

* Rows in Relation table must have a dedicated ID

* Updating cypress relation test

* Changing Props java class to save rows identifiers in Relation tables

* Display JSON definition with collapsable sections

* Table's rows identifier

* Generating uuid for rows

* Table's column id

* Solving conflicts in DecisionTableExpression

* Solving conflicts in RelationExpression

* Solving issue introduced after KOGITO-5078:
when selecting Literal as Expression type, the expression definition should be updated accordingly

* Bump version to 8.5.4-SNAPSHOT (#165)

* Bump version to 8.5.3-SNAPSHOT

* Bump version to 8.5.4-SNAPSHOT

* KOGITO-5848: Activate sonar for kogito-editors-js module (#160)

For more details see:
- https://issues.redhat.com/browse/KOGITO-5848

* Remove duplicit gwt-maven-plugin definition (#164)

This a fix for the warning from build:
Some problems were encountered while building the effective model for org.kie.kogito:lienzo-webapp:war:8.5.2-SNAPSHOT
Warning:  'profiles.profile[GWT2].plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.codehaus.mojo:gwt-maven-plugin @ line 239, column 14
Warning:
Warning:  It is highly recommended to fix these problems because they threaten the stability of your build.
Warning:
Warning:  For this reason, future Maven versions might no longer support building such malformed projects.
Warning:

* Use lerna to change packages version (#168)

* RHPAM-3329: Increase Decision Table Output value length limit (#152)

* Measure kogito-editors-js coverage (#167)

* Measure kogito-editors-js coverage

* fix ci

* Extend relation and decision table coverage

* Empty dependencies array for `useEffect` - executing spread of literal expression definition only the first time the component is rendered

* Removing `useEffect` from `LiteralExpression`

* Using _.chain method instead of directly _.map/_.reduce

Co-authored-by: Yeser Amer <yamer@redhat.com>
Co-authored-by: Jozef Marko <jomarko@redhat.com>
Co-authored-by: Luiz João Motta <luizjoaomotta@gmail.com>

* KOGITO-6144: DMN Editor missing xml-prolog for UTF-8 encoding (#154)

* KOGITO-6144: add xml declaration prolog

For more details see:
- https://issues.redhat.com/browse/KOGITO-6144

* Fix sonar issues

* Start kogito-editors-js cypress tests as part of CI build (#173)

* KOGITO-6262: Extend new boxed expression editor decision table coverage (#170)

For more details see:
- https://issues.redhat.com/browse/KOGITO-6262

* KOGITO-6262: Regressions on DecisionTable, after KOGITO-5078 (#171)

* Fix new column prefix

* Fix ContextExpression reset cell

* Fix DecisionTableExpression name on nested expression

* Sync ContextEntryInfo and DecisionTable name and dataType

* Remove unnecessary states

* KOGITO-6045: The canvas now expands automatically anytime a primitive is dragged beyond control limits. (#129)

* DROOLS-5197,5744 - DMN Enumeration constraint editor small enhancements (#169)

As part of this PR we:
- prevent user from defining same enumeration item multiple times: https://issues.redhat.com/browse/DROOLS-5197
- commit all enumeration items in edit mode by click on single checkbox: https://issues.redhat.com/browse/DROOLS-5744

* Enable tests for KOGITO-6262 (#177)

* KOGITO-6326: Regressions on LiteralExpression, after KOGITO-5078 (#180)

* Fix LiteralExpression first render

* KOGITO-6326: Test a literal expression data type change

* Formater

Co-authored-by: Jozef Marko <jomarko@redhat.com>

* BXMSPROD-1558 install lock-treatment-tool exec (#184)

* BXMSPROD-1558 install lock-treatment-tool exec

* BXMSPROD-1558 lock-treatment-tool replaced by @kie/lock-treatment-tool

* BXMSPROD-1558 lock-treatment-tool replaced by @kie/lock-treatment-tool

* BXMSPROD-1558 @kie/lock-treatment-tool@^0.0.2

* trying with --

* trying double

* one single execution with --

* one single execution with --

* one single execution with --

* one single execution with --

* one single execution with --

* Update .ci conf to get sonar report (#187)

Previously there was a check of a SONARCLOUD_ENABLED variable to be sure we should run sonar checks. However this check was broken by recent change:
- kiegroup/kogito-pipelines@2724907#diff-a6b82d55b9b456d5762e2acda0ee91fb6ac26087c8eb1db4697ed1d911959671

This we decided to simplify kogito-editors-java Jenkinsfile to get sonar CI checks working again

Update .ci/jenkins/dsl/jobs.groovy

Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com>

Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com>

* Revert missing import in .ci conf (#188)

* Revert missing import in .ci conf

* Add github action to validate jenkins job definitions files

* KOGITO-3662: Boxed Expression Editor should use UIDv4 for handling identifiers of elements (#182)

* Adding exported function for generating UUID

* First column of Relation table should have 100 px of width

* Accessor for added columns is the generated uuid

* Using identifier for accessing the columns

* Identify each table row by its ID

* Identify columns and rows in Relation table, by their ID

* Fixing tests after introduction of ID

* Id for Relation table should not be generated when evaluating rows, otherwise it will be different at every render

* Generating IDs for DecisionTable's columns

* When adding a new row, a generated uuid should be used for it

* When rendering the table, if a row is missing the id, going to generate it

* Giving minimum height to label section, in order to have space when label is empty

* Edit of inline text (annotation labels) should accept empty values

* Changing props Java classes to reflect Id param

* Overriding PF label color (that on DMN Editor is white)

* Filling id of Annotation and Clause DecisionTable's props

* Id for inputClause should not be taken from its wrapped inputExpression

* Fixing test case

* Retrieve ruleId from the model

* Fixing cypress test case

* Rows in Relation table must have a dedicated ID

* Updating cypress relation test

* Changing Props java class to save rows identifiers in Relation tables

* Display JSON definition with collapsable sections

* Table's rows identifier

* Generating uuid for rows

* Table's column id

* Solving conflicts in DecisionTableExpression

* Solving conflicts in RelationExpression

* Solving issue introduced after KOGITO-5078:
when selecting Literal as Expression type, the expression definition should be updated accordingly

* Bump version to 8.5.4-SNAPSHOT (#165)

* Bump version to 8.5.3-SNAPSHOT

* Bump version to 8.5.4-SNAPSHOT

* KOGITO-5848: Activate sonar for kogito-editors-js module (#160)

For more details see:
- https://issues.redhat.com/browse/KOGITO-5848

* Remove duplicit gwt-maven-plugin definition (#164)

This a fix for the warning from build:
Some problems were encountered while building the effective model for org.kie.kogito:lienzo-webapp:war:8.5.2-SNAPSHOT
Warning:  'profiles.profile[GWT2].plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.codehaus.mojo:gwt-maven-plugin @ line 239, column 14
Warning:
Warning:  It is highly recommended to fix these problems because they threaten the stability of your build.
Warning:
Warning:  For this reason, future Maven versions might no longer support building such malformed projects.
Warning:

* Use lerna to change packages version (#168)

* RHPAM-3329: Increase Decision Table Output value length limit (#152)

* Measure kogito-editors-js coverage (#167)

* Measure kogito-editors-js coverage

* fix ci

* Extend relation and decision table coverage

* Empty dependencies array for `useEffect` - executing spread of literal expression definition only the first time the component is rendered

* Removing `useEffect` from `LiteralExpression`

* Using _.chain method instead of directly _.map/_.reduce

* Removing `react-id-generator` from peerDependencies list

* Renaming `uid` to `id` property

* Using `generateUuid` instead of `nextId` as id

* Each expression type has an `id` property

* LiteralExpression body cell id is the one related to the LiteralExpression

* Context row id is equal to the entryInfo id (variable)

* Table columns should contain column id in the <Th> class

* Wrapped LiteralExpression of Java, PMML Function must have their own ids

* PMMLLiteralExpression has his own identifier

* Spreading field ids for Java and PMML function expressions

* Specific LiteralExpression class based on function kind

* Invocation biding ids population

* Passing list expression id to props and viceversa

* Passing expression ids from model to props and viceversa

* BoxedExpressionEditor accepts the decisionNodeId parameter

* Putting decisionNodeId in the Context API

* The decisionNodeId is used as identifier for the output column at highest level

* Fixing ListExpression.test

* Passing decision node id to DMNLoader

* Fixing existing tests after PMML function improvement

* Decision node id should be set only for root expressions

* Using Nullish coalescing operator for string check

* Populating Parameter class like in LiteralExpressionPMMLDocumentModelEditorDefinition.java

* Renaming cssClasses

* Using constants for identifying the first and second entries

Co-authored-by: Yeser Amer <yamer@redhat.com>
Co-authored-by: Jozef Marko <jomarko@redhat.com>
Co-authored-by: Luiz João Motta <luizjoaomotta@gmail.com>

* KOGITO-6407: fix outdated browserlist warning (#193)

For more details see:
* https://issues.redhat.com/browse/KOGITO-6407

* Remove duplicated .gitignore entry - coverage (#190)

* KOGITO-5901: Resolving dependabot alerts (#191)

* KOGITO-5901: Removing unused netty dependency

* KOGITO-5901: Removing unused netty dependency

* KOGITO-6289: Regressions on copy/paste from other spreadsheet, after KOGITO-5078 (#181)

* Fix SelectionBox visualization

* Fix paste new values on RelationExpression

* Change listeners to boxed-expression-editor instead of document

* Omit isHeadless property

* Use document as fallback container

* Update tests snapshots

* Remove unused import

* Refactor onRowsUpdate to use object as arg instead of multiple optional ones

* Refactor to use the Boxed Expression ref instead of id

* Use boxed expression container instead of document on paste

* Use boxed expression container instead of document on resizer

* Update snapshots

* Update onRowsUpdate to use object

* Remove usage of document as fallback

* Update tests to use the editorRef and add missing containers

* Fix tests

* Fix import

* Change DecisionExpression spread parameter to object

* Change onColumnsUpdate to use args

* Linter

* Revert tsconfig

* Rename container to editorElement

* Update snapshots

* Make boxed expression to have the parent heigth

* Update test snapshot

* Automate copy and paste test

* Fix DMN boxed editor height

* Extract relation expression definition to separate logic

* Change Boxed Editor height on showcase

* Fix pom.xml command

Co-authored-by: Jozef Marko <jomarko@redhat.com>

* KOGITO-4195: [DMN Designer] New boxed expression editor - Support undo/redo in Boxed Expression Editor (#175)

* KOGITO-4195: [DMN Designer] New boxed expression editor - Support undo/redo in Boxed Expression Editor

* rebuild

* Fix tests

* rebuild

* Code Review #1

* Prettier

* rebuild

* Prettier

* Some refactor and test coverage

* Code review #2

* Move to new folder

* Building online-editor fine

* Format code

* Updates

* Remove unecessary build args in Maven packages

* Update versions to 0.0.0 and update versions script

* build:prod working without tests

* Renaming references to kogito-tooling instead of kogito-editors-java

* Consolidate .gitignores

* Add --env live option to DMN Loader

* Monorepo general enhancements

* Renaming env var

* Fix Jest tests

* Update more snapshots

* Remove maven cache on CI

* Fix PF loaders on windows

* Change Maven setup

* Fix Maven setup on CI

* Fixing READMEs and Maven config on CI

* Scripts cleanup and fix build on Windows

* Oops. Update yarn.lock

* Fix build on Windows

* Fix symlinks on Windows and Sonar workflow

* Fix maven default args on setup-env

* Fix kogito-editors-java package.json

* Update graph.dot

* Increase JVM memory

* Include dependencies on NPM Packages release job

* Fix JVM memory increase

* Pagefile on Windows

* Oops

* Setup kogito-tooling-bot before merging

* Fix showcases

* Oops. Update yarn.lock

* Oops. Dependency version mismatches

* Fix Standalone Editors tests and add test:it to build:prod on boxed-expression-component

* Fix dependency mismatches

* Oops. yarn.lock

* Paralel maven builds

* Remove paralel maven builds

* Skip IT tests for stunner-editors and testing webapps compilation

* Skip IT tests for stunner-editors build:prod

* Disable IT tests on boxed expression and remove dmn-runner-showcase from unitables

* Update graph.dot

* Enable boxed-expression-component tests

* Unskip Resizer tests on boxed-expression-component

* Update Jenkinsfile sonar checks paths (#41)

This changes are related to monorepo migration #729

* Skipping Decision Table Expression tests

* Skip DMN VS Code test

* Unskip test and increase timeout to open webview on VS Code

* Change editor name from SceSim to Test Scenario

Co-authored-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Co-authored-by: Dmitrii Tikhomirov <treblereel@users.noreply.github.com>
Co-authored-by: Daniel J dos Santos <danielzhe@users.noreply.github.com>
Co-authored-by: Enrique Mingorance Cano <emingora@redhat.com>
Co-authored-by: Guilherme Carreiro <karreiro@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: karreiro <karreiro@users.noreply.github.com>
Co-authored-by: Kirill Gaevskii <hasysin@gmail.com>
Co-authored-by: Yeser Amer <yamer@redhat.com>
Co-authored-by: Jaime Enriquez <jaime.enriquez@inodesoft.com>
Co-authored-by: Jaime Enriquez <jenrique@redhat.com>
Co-authored-by: Jozef Marko <jomarko@redhat.com>
Co-authored-by: Wagner Scholl Lemos <josephblt@gmail.com>
Co-authored-by: Roger Martínez <roger600@gmail.com>
Co-authored-by: Michael Biarnes Kiefer <mbiarnes@redhat.com>
Co-authored-by: Handrey Cunha <handrey.cunha@gmail.com>
Co-authored-by: Alberto Morales <almorale@redhat.com>
Co-authored-by: Marek Novotný <hotmana76@gmail.com>
Co-authored-by: Kirill Gaevskii <kgaevski@redhat.com>
Co-authored-by: Valentino Pellegrino <vpellegr@redhat.com>
Co-authored-by: Handreyrc <47090342+handreyrc@users.noreply.github.com>
Co-authored-by: Kogito Tooling Bot <kietooling@gmail.com>
Co-authored-by: Eder Ignatowicz <ignatowicz@gmail.com>
Co-authored-by: Luiz João Motta <luizjoaomotta@gmail.com>
Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com>
handreyrc pushed a commit to handreyrc/kie-tools that referenced this pull request Mar 11, 2022
KOGITO-3661 Integrate boxed-expression-component inside dmn-loader an…
60cb829 
…d define jsInterop classes for loading/saving expressions (apache#104)

KOGITO-3661 Integrate boxed-expression-component inside dmn-loader and define jsInterop classes for loading/saving expressions (apache#104)
jomarko pushed a commit to jomarko/kie-tools that referenced this pull request Apr 18, 2023
@danielzhe
Remove "Function" for Decision root of nodes (apache#104)
c964e94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@porcelli porcelli porcelli approved these changes

@ederign ederign ederign approved these changes

@paulovmr paulovmr paulovmr approved these changes

@tiagobento tiagobento tiagobento approved these changes

@jomarko jomarko jomarko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@caponetto @ederign @tiagobento @jomarko @porcelli @paulovmr