PLANNER-1752: Move frontend to Immutable.js #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins retest this. |
yurloc
reviewed
Nov 20, 2020
optaweb-employee-rostering-frontend/src/store/contract/reducers.ts
Outdated
Show resolved
Hide resolved
| }); | ||
| it('remove employee', () => { | ||
| expect( | ||
| reducer(state.employeeList, actions.removeEmployee(deletedEmployee)), | ||
| ).toEqual({ ...state.employeeList, | ||
| employeeMapById: mapWithoutElement(storeState.employeeList.employeeMapById, deletedEmployee) }); | ||
| employeeMapById: storeState.employeeList.employeeMapById.delete(deletedEmployee.id as number) }); |
There was a problem hiding this comment.
Alternatively, you can say delete(deletedEmployee.id!). The exclamation mark is a non-null assertion. It's more concise and maybe a more precise type assertion. But we have an ESLint rule that complains about that. Dunno which of the two is worse.
optaweb-employee-rostering-frontend/src/ui/pages/contract/ContractsPage.test.tsx
Outdated
Show resolved
Hide resolved
Christopher-Chianelli
force-pushed
the
PLANNER-1752
branch
from
5c97f69
to
f8c6cd1
Compare
yurloc
reviewed
Nov 25, 2020
optaweb-employee-rostering-frontend/src/ui/pages/shift/ExportScheduleModal.tsx
Outdated
Show resolved
Hide resolved
yurloc
reviewed
Nov 27, 2020
optaweb-employee-rostering-frontend/src/ui/pages/employee/EmployeesPage.tsx
Outdated
Show resolved
Hide resolved
Christopher-Chianelli
force-pushed
the
PLANNER-1752
branch
from
721f00a
to
8544140
Compare
|
@yurloc thoughts on the current state of the PR? |
yurloc
reviewed
Dec 11, 2020
yurloc
approved these changes
Dec 11, 2020
TODO: - Update tests
Using the ?? operator allows us to throw errors instead of erasing type infomation and sliently ignoring any problem until it is too late.
All usage in the UI already converts the list into a mutable array, and they do not modify the mutable array, so it much more useful for the selector to directly return the mutable array.
Christopher-Chianelli
force-pushed
the
PLANNER-1752
branch
from
8544140
to
57d90b8
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://issues.redhat.com/browse/PLANNER-1752
Referenced pull requests
How to retest this PR or trigger a specific build: