Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated null safety #9

Merged
merged 2 commits into from Mar 13, 2021

Conversation

nilsreichardt
Copy link
Contributor

@nilsreichardt nilsreichardt commented Mar 7, 2021

Description

I propose this pull request to migrate this plugin to null safety as it is the way to go now that Flutter 2 has been released.

Here are the changes I introduced:

  • Update SDK dependency version to 2.12.0+
  • Run dart migrate on existing code to remove unsafe nulls (for the package & example)
  • Add a new version (0.2.0) to the changelog (as recommended)
  • Moved number_col.dart and number_slide_animation_widget.dart in lib/src

Please check everything twice!

Testing

  • All existing tests are passing
  • Tested it manually on a Android emulator

Related tickets

Closes #9

@kiesman99
Copy link
Owner

Hey @nilsreichardt thank you for submitting this PR!

Do you use this library currently in one of your applications and need this NNBD change?
Depending on your answer I'll merge this request.

Some parts of this package will be changed in the near future, to tackle more animation options, floating point numbers and a cleaner structure of this package. If you do not use this package actively I'd think it's better to migrate after these changes, but if you do, I'll publish it as a intermediate step.

Thank you!

(Still have to review your code depending on your answer)

@nilsreichardt
Copy link
Contributor Author

Hi @kiesman99! We use this package for our landing page: https://sharezone.net. Null safety could improve the performance of our website.

Alternatively we can use a git reference to my PR instead of using the pub.dev reference in pubspec.yaml:

number_slide_animation:
    git:
      url: https://github.com/nilsreichardt/number_slide_animation
      ref: migrated-null-safety

Did you already started with implementing the new features? If not I recommend to first merge and then start with implementing (directly with null safety support).

@kiesman99
Copy link
Owner

LGTM

@kiesman99 kiesman99 merged commit ed4456d into kiesman99:master Mar 13, 2021
@kiesman99
Copy link
Owner

kiesman99 commented Mar 13, 2021

@nilsreichardt The null-safe version is not available here https://pub.dev/packages/number_slide_animation/versions/0.2.1

Thank you very much for your contribution!

@nilsreichardt
Copy link
Contributor Author

@kiesman99 Great!

version is not available here

I think you mean now and not not, right? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants