Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Simple macros" don't work on Mac OS Sierra #63

Closed
rjhilgefort opened this issue Oct 10, 2016 · 11 comments
Closed

"Simple macros" don't work on Mac OS Sierra #63

rjhilgefort opened this issue Oct 10, 2016 · 11 comments

Comments

@rjhilgefort
Copy link

I just upgraded to OSX Sierra to find that the "simple macros" I had configured through the input club layout layout builder no longer fire consistently (fire once every 20 key presses or something).

Anyone else having this issue? Is it a known issue- I couldn't find anything in the issues on this repo? Is this an issue I should be posting to the firmware repo instead?

@rjhilgefort
Copy link
Author

Wasn't sure where the appropriate place was, so I created an issue over there as well:

benblazak/ergodox-firmware#81

@haata
Copy link
Member

haata commented Oct 10, 2016

Interesting. macOS Sierra had a lot of changes in the USB HID stack (karabiner has to be re-written due to them...).

@rjhilgefort
Copy link
Author

Correction on cross post- posted to correct firmware repo (for infinity ergodox):

kiibohd/controller#158

@rjhilgefort
Copy link
Author

@haata Yeah, I'm fighting issues from that front as well. Both are killing my muscle memory, but I'm determined to hang on to Sierra and not downgrade. Any lead on a fix? If not, a work around?

@haata
Copy link
Member

haata commented Oct 23, 2016

I'm getting really close to implementing the firmware support for KLL 0.4. So I'm torn between trying to hack up a fix for this or just add it as part of KLL 0.4.

I have an idea on how to fix this. It will change the behaviour of sequences for all platforms.
The idea is to enable/disable modifiers exclusively then on the next packet deal with the non-modifier keys.
USB HID spec wise, this is dumb. Stupid Apple.

@rjhilgefort
Copy link
Author

rjhilgefort commented Oct 23, 2016

Your call of course. Selfishly, I'd love a patch, depending on how far out KLL 0.4. I've grown pretty dependent on the simple macros and love what they allow for in my layout.

Yeah- does seem a bit silly, but I'm guessing the change is driven by the OLED touch "keys" that will replace the function keys above the numbers. Is that the case or is this change independent of that?

As I mentioned above, I created an issue on the kiibohd/controller repo which I'm guessing your involved with as well. Would it make sense to close that issue, or are there changes that will be required there as well.

kiibohd/controller#158

@gibfahn
Copy link

gibfahn commented Oct 29, 2016

I think I'm seeing the same issue. If I use the Karabiner event viewer, when I use a Macro it's getting Ctrl instead of Shift (e.g. for % Karabiner is showing Ctrl 5 rather than Shift 5).

Just in case it helps...

@haata
Copy link
Member

haata commented Oct 29, 2016

Does this still happen when karabiner is disabled?

@rjhilgefort @gibfahn

@gibfahn
Copy link

gibfahn commented Oct 30, 2016

Ok, disabling Karabiner actually stops this issue from occurring. I also did Karabiner-Elements => Check for beta updates => install, and the new version has a Devices tab, so you can disable the Ergodox part, which fixed macros for me.

So based on this, should we raise an issue on the Karabiner Github page?

@haata
Copy link
Member

haata commented Oct 30, 2016

Yeah, this sounds like a bug in karabiner. They are re-ordering keypresses
for whatever reason. If you get push back, feel free to link me and I'll
give a detailed technical explanation in the bug. Or if they want more
details.

On Sun, Oct 30, 2016, 16:03 Gibson Fahnestock notifications@github.com
wrote:

Ok, disabling Karabiner actually stops this issue from occurring. I also
did Karabiner-Elements => Check for beta updates => install, and the new
version has a Devices tab, so you can disable the Ergodox part, which fixed
macros for me.

So based on this, should we raise an issue on the Karabiner Github page?


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#63 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABbqXpWdy9a7C5vjh6uN-LZe2OzPYyZks5q5SI5gaJpZM4KS6kq
.

@rjhilgefort
Copy link
Author

@gibfahn Can confirm that with Karabiner disabled, this issue isn't present. My apologies, should have eliminated that variable myself.

@haata Sounds good, I'll make one over there. Thanks for looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants