Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ergodox Infinty is non-functional since last commit #297

Closed
johngeorgewright opened this issue Sep 26, 2018 · 7 comments
Closed

Ergodox Infinty is non-functional since last commit #297

johngeorgewright opened this issue Sep 26, 2018 · 7 comments
Assignees

Comments

@johngeorgewright
Copy link

johngeorgewright commented Sep 26, 2018

Device:

Infinity Ergodox Left-side Master (Massdrop 2016)

Firmware Origin:

controller.git#master

OS:

macOS High Sierra

Version:

Not 100% sure how to get this.

Reproduction Steps:

Fresh install of Ergodox Infinity and install bundled ergodox infinity binaries.

  1. git clone https://github.com/kiibohd/controller.git
  2. docker build -f Dockerfiles/Dockerfile.ubuntu -t controller.ubuntu Dockerfiles
  3. docker run -it --rm -v "$(pwd):/controller" controller.ubuntu
  4. pipenv install && pipenv shell
  5. ./ergodox.bash
  6. Exit docker container and install binaries to ergodox

I should note that during the above steps I don't see any error or warning messages.

Resulting Issue:

Logo appears but keyboard is non-functional until I install old binary (downloaded from https://configurator.input.club/).

Solution

  1. git reset --hard HEAD~1
@haata haata self-assigned this Sep 26, 2018
@haata
Copy link
Member

haata commented Sep 26, 2018

I'm assuming both sides aren't working.

This is likely to do with the SAM4S (Kira) merges we're doing right now. We'll be able to take a look at this in a week or two (should be an easy fix hopefully).
If you wouldn't mind, what is the last working git hash?

@johngeorgewright
Copy link
Author

No worries. I forked it and reverted that last merge. Working commit is currently 164a8f86004645a9ae36367c6a9044f577263d86.

@ganthern
Copy link

I'm still having this problem with commit 56cdf53. Was this supposed to be fixed and broke again or are we still "in a week or two"?

@haata
Copy link
Member

haata commented Nov 11, 2018

Just to confirm, both sides are not working (both sides were flashed)? I can look at this in the next few days I think (Kira is now stabilized so I'm going through the unit test failures now).

@ganthern
Copy link

Just confirmed it with an up-to-date master branch: both sides were flashed with their respective firmware. Both sides are lighting up and showing logos, but no usb codes are sent (in left- and right master configuration).

haata added a commit that referenced this issue Nov 12, 2018
- Commented out an ISR error message that seemed to clobber other ISRs
- This should help with typing on the Infinity Ergodox
@haata
Copy link
Member

haata commented Nov 12, 2018

Just pushed a small fix that helped on my Infinity Ergodox. I'm not done testing yet, but this should fix some of the problems.

@haata
Copy link
Member

haata commented Dec 15, 2018

I've done more fixes (e7b5587) and have included some basic Animation support as well.

@haata haata closed this as completed Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants